Re: [Mesa3d-dev] [PATCH] Fix u_pack_color.h rgb pack/unpack functions

2009-12-15 Thread Roland Scheidegger
On 15.12.2009 18:02, michal wrote: > Roland Scheidegger pisze: >> On 15.12.2009 14:14, michal wrote: >> >>> Guys, >>> >>> Does the attached patch make sense to you? >>> >>> I replaced the incomplete switch-cases with calls to u_format_access >>> functions that are complete but are going to be a

Re: [Mesa3d-dev] [PATCH] Fix u_pack_color.h rgb pack/unpack functions

2009-12-15 Thread michal
Roland Scheidegger pisze: > On 15.12.2009 14:14, michal wrote: > >> Guys, >> >> Does the attached patch make sense to you? >> >> I replaced the incomplete switch-cases with calls to u_format_access >> functions that are complete but are going to be a bit more expensive to >> call. Since they a

Re: [Mesa3d-dev] [PATCH] Fix u_pack_color.h rgb pack/unpack functions

2009-12-15 Thread Roland Scheidegger
On 15.12.2009 14:14, michal wrote: > Guys, > > Does the attached patch make sense to you? > > I replaced the incomplete switch-cases with calls to u_format_access > functions that are complete but are going to be a bit more expensive to > call. Since they are used not very often in mesa state t

Re: [Mesa3d-dev] [PATCH] Fix u_pack_color.h rgb pack/unpack functions

2009-12-15 Thread José Fonseca
On Tue, 2009-12-15 at 05:14 -0800, michal wrote: > Guys, > > Does the attached patch make sense to you? > > I replaced the incomplete switch-cases with calls to u_format_access > functions that are complete but are going to be a bit more expensive to > call. Since they are used not very often i

Re: [Mesa3d-dev] [PATCH] Fix u_pack_color.h rgb pack/unpack functions

2009-12-15 Thread Keith Whitwell
On Tue, 2009-12-15 at 05:14 -0800, michal wrote: > Guys, > > Does the attached patch make sense to you? > > I replaced the incomplete switch-cases with calls to u_format_access > functions that are complete but are going to be a bit more expensive to > call. Since they are used not very often i

[Mesa3d-dev] [PATCH] Fix u_pack_color.h rgb pack/unpack functions

2009-12-15 Thread michal
Guys, Does the attached patch make sense to you? I replaced the incomplete switch-cases with calls to u_format_access functions that are complete but are going to be a bit more expensive to call. Since they are used not very often in mesa state tracker, I thought it's a good compromise. Tha