Re: [Mesa3d-dev] [PATCH] Honor LD_LIBRARY_PATH getting EGL drivers

2010-02-02 Thread Chia-I Wu
On Wed, Feb 3, 2010 at 1:55 PM, Mike Stroyan wrote: >> The patch looks good.  But when I tried to make EGL_DRIVER and the default >> driver also honor EGL_DRIVERS_PATH, it turned out that I need to overhaul >> both >> the existing code and your patch. >> I've attached my version in this mail.  It

Re: [Mesa3d-dev] [PATCH] Honor LD_LIBRARY_PATH getting EGL drivers

2010-02-02 Thread Mike Stroyan
On Tue, Feb 2, 2010 at 9:17 PM, Chia-I Wu wrote: > On Tue, Feb 2, 2010 at 11:43 AM, Mike Stroyan wrote: >> On Mon, Feb 1, 2010 at 7:34 PM, Chia-I Wu wrote: >>> On Tue, Feb 2, 2010 at 2:49 AM, Mike Stroyan wrote:  Here is a version of the patch that uses EGL_DRIVERS_PATH and checks for

Re: [Mesa3d-dev] [PATCH] Honor LD_LIBRARY_PATH getting EGL drivers

2010-02-02 Thread Chia-I Wu
On Tue, Feb 2, 2010 at 11:43 AM, Mike Stroyan wrote: > On Mon, Feb 1, 2010 at 7:34 PM, Chia-I Wu wrote: >> On Tue, Feb 2, 2010 at 2:49 AM, Mike Stroyan wrote: >>>  Here is a version of the patch that uses EGL_DRIVERS_PATH and checks >>> for setuid/setgid >>> before using EGL_DRIVER or EGL_DRIVER

Re: [Mesa3d-dev] [PATCH] Honor LD_LIBRARY_PATH getting EGL drivers

2010-02-01 Thread Mike Stroyan
On Mon, Feb 1, 2010 at 7:34 PM, Chia-I Wu wrote: > On Tue, Feb 2, 2010 at 2:49 AM, Mike Stroyan wrote: >>  Here is a version of the patch that uses EGL_DRIVERS_PATH and checks >> for setuid/setgid >> before using EGL_DRIVER or EGL_DRIVERS_PATH. > The patch seems to be missing :) Here is the miss

Re: [Mesa3d-dev] [PATCH] Honor LD_LIBRARY_PATH getting EGL drivers

2010-02-01 Thread Chia-I Wu
On Tue, Feb 2, 2010 at 2:49 AM, Mike Stroyan wrote: >  Here is a version of the patch that uses EGL_DRIVERS_PATH and checks > for setuid/setgid > before using EGL_DRIVER or EGL_DRIVERS_PATH. The patch seems to be missing :) I want to avoid suffix matching somehow. > I am not clear about the m

Re: [Mesa3d-dev] [PATCH] Honor LD_LIBRARY_PATH getting EGL drivers

2010-02-01 Thread Mike Stroyan
olv, Here is a version of the patch that uses EGL_DRIVERS_PATH and checks for setuid/setgid before using EGL_DRIVER or EGL_DRIVERS_PATH. >>> I want to avoid suffix matching somehow. I am not clear about the motive for a less than exact check for the library suffix in EGL_DRIVER. Are you intere

Re: [Mesa3d-dev] [PATCH] Honor LD_LIBRARY_PATH getting EGL drivers

2010-02-01 Thread Mike Stroyan
On Mon, Feb 1, 2010 at 10:35 AM, tom fogal wrote: > Mike Stroyan writes: >>   The changes to load EGL drivers by pattern matching had the side >> effect of not looking in the directories specified by LD_LIBRARY_PATH >> or -rpath or ldconfig . > > This is silly.  If you give dlopen a library name:

Re: [Mesa3d-dev] [PATCH] Honor LD_LIBRARY_PATH getting EGL drivers

2010-02-01 Thread tom fogal
Mike Stroyan writes: > The changes to load EGL drivers by pattern matching had the side > effect of not looking in the directories specified by LD_LIBRARY_PATH > or -rpath or ldconfig . This is silly. If you give dlopen a library name: dlopen("libWhatever.so", flags); then *it* will automa

Re: [Mesa3d-dev] [PATCH] Honor LD_LIBRARY_PATH getting EGL drivers

2010-01-31 Thread Chia-I Wu
On Mon, Feb 1, 2010 at 11:19 AM, Mike Stroyan wrote: > On Sun, Jan 31, 2010 at 7:46 PM, Chia-I Wu wrote: >> On Mon, Feb 1, 2010 at 9:15 AM, Mike Stroyan wrote: >>>  The changes to load EGL drivers by pattern matching had the side effect of >>> not >>> looking in the directories specified by LD_

Re: [Mesa3d-dev] [PATCH] Honor LD_LIBRARY_PATH getting EGL drivers

2010-01-31 Thread Mike Stroyan
On Sun, Jan 31, 2010 at 7:46 PM, Chia-I Wu wrote: > On Mon, Feb 1, 2010 at 9:15 AM, Mike Stroyan wrote: >>  The changes to load EGL drivers by pattern matching had the side effect of >> not >> looking in the directories specified by LD_LIBRARY_PATH or -rpath or >> ldconfig. >> This patch change

Re: [Mesa3d-dev] [PATCH] Honor LD_LIBRARY_PATH getting EGL drivers

2010-01-31 Thread Chia-I Wu
On Mon, Feb 1, 2010 at 9:15 AM, Mike Stroyan wrote: >  The changes to load EGL drivers by pattern matching had the side effect of > not > looking in the directories specified by LD_LIBRARY_PATH or -rpath or ldconfig. > This patch changes the search to first look in the directories listed in > LD_

[Mesa3d-dev] [PATCH] Honor LD_LIBRARY_PATH getting EGL drivers

2010-01-31 Thread Mike Stroyan
The changes to load EGL drivers by pattern matching had the side effect of not looking in the directories specified by LD_LIBRARY_PATH or -rpath or ldconfig. This patch changes the search to first look in the directories listed in LD_LIBRARY_PATH. To do that it moves the possible addition of a p