tom fogal writes:
> Chia-I Wu writes:
> > On Tue, Jul 28, 2009 at 11:10:43AM -0600, tom fogal wrote:
> > > Hrm. I would argue that both places should read something more like:
> > > #if C99 is supported
> > > # include
> > > #else
> > > /* some typedefs */
> > > #endif
> >
> > I
Chia-I Wu wrote:
> On Thu, Jul 30, 2009 at 10:37:15AM -0600, Brian Paul wrote:
>> Chia-I Wu wrote:
>>> On Wed, Jul 29, 2009 at 09:21:15AM -0600, tom fogal wrote:
> -#if defined(_MSC_VER)
> +#if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L
> +# include
> +#elif defined(
On Thu, Jul 30, 2009 at 10:37:15AM -0600, Brian Paul wrote:
> Chia-I Wu wrote:
> >On Wed, Jul 29, 2009 at 09:21:15AM -0600, tom fogal wrote:
> >>>-#if defined(_MSC_VER)
> >>>+#if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L
> >>>+# include
> >>>+#elif defined(_MSC_VER)
> >>>typede
Chia-I Wu wrote:
> On Wed, Jul 29, 2009 at 09:21:15AM -0600, tom fogal wrote:
>>> -#if defined(_MSC_VER)
>>> +#if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L
>>> +# include
>>> +#elif defined(_MSC_VER)
>>> typedef __int8 int8_t;
>>> typedef unsigned __int8uint
On Wed, Jul 29, 2009 at 09:21:15AM -0600, tom fogal wrote:
> > -#if defined(_MSC_VER)
> > +#if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L
> > +# include
> > +#elif defined(_MSC_VER)
> > typedef __int8 int8_t;
> > typedef unsigned __int8uint8_t;
> > typede
Chia-I Wu writes:
>
> On Tue, Jul 28, 2009 at 09:14:04PM -0600, tom fogal wrote:
> > Chia-I Wu writes:
> > > On Tue, Jul 28, 2009 at 11:10:43AM -0600, tom fogal wrote:
> > > > Hrm. I would argue that both places should read something more like:
> > > > #if C99 is supported
> > > > # inclu
On Tue, Jul 28, 2009 at 09:14:04PM -0600, tom fogal wrote:
> Chia-I Wu writes:
> > On Tue, Jul 28, 2009 at 11:10:43AM -0600, tom fogal wrote:
> > > Hrm. I would argue that both places should read something more like:
> > > #if C99 is supported
> > > # include
> > > #else
> > > /* s
Chia-I Wu writes:
> On Tue, Jul 28, 2009 at 11:10:43AM -0600, tom fogal wrote:
> > Hrm. I would argue that both places should read something more like:
> > #if C99 is supported
> > # include
> > #else
> > /* some typedefs */
> > #endif
> > Or perhaps something more robust / maint
On Tue, Jul 28, 2009 at 11:10:43AM -0600, tom fogal wrote:
> Hrm. I would argue that both places should read something more like:
> #if C99 is supported
> # include
> #else
> /* some typedefs */
> #endif
> Or perhaps something more robust / maintained by a third party entity
> (li
Chia-I Wu writes:
> On Mon, Jul 27, 2009 at 10:07:37AM -0600, tom fogal wrote:
> > > /**
> > > + * Get standard integer types
> > > + */
> > > +#if defined(_MSC_VER)
> > > + typedef __int8 int8_t;
> > > + typedef unsigned __int8uint8_t;
> > [snip]
> > > +#else
> > > +# includ
On Mon, Jul 27, 2009 at 10:07:37AM -0600, tom fogal wrote:
> > /**
> > + * Get standard integer types
> > + */
> > +#if defined(_MSC_VER)
> > + typedef __int8 int8_t;
> > + typedef unsigned __int8uint8_t;
> [snip]
> > +#else
> > +# include
> > +#endif
> I think this would mak
Chia-I Wu writes:
> /**
> + * Get standard integer types
> + */
> +#if defined(_MSC_VER)
> + typedef __int8 int8_t;
> + typedef unsigned __int8uint8_t;
[snip]
> +#else
> +# include
> +#endif
I think this would make more sense predicated on __STDC_VERSION__
compared to 19990
Casting an unsigned int to or from a pointer directly gives warnings on
x86-64. Add wrappers to silence the warnings.
Signed-off-by: Chia-I Wu
---
src/egl/main/eglcompiler.h | 30 ++
src/egl/main/eglconfig.c |2 +-
src/egl/main/egldisplay.c | 19 +
13 matches
Mail list logo