Re: [Mingw-w64-public] [PATCH 1/2] stdlib.h: Add mkstemp implementation.

2015-01-07 Thread Dongsheng Song
On Wed, Jan 7, 2015 at 4:50 PM, niXman i.nix...@autistici.org wrote: Dongsheng Song 2015-01-07 11:34: Since the last 6 characters must be XX is mandatory, I think no need such tricks. You do not know what will change through the 1,5,10 years. No, it should not changed, this is widely

Re: [Mingw-w64-public] [PATCH 1/2] stdlib.h: Add mkstemp implementation.

2015-01-07 Thread Dongsheng Song
On Wed, Jan 7, 2015 at 4:00 PM, niXman i.nix...@autistici.org wrote: +int __cdecl mkstemp (char *template_name) +{ +errno_t ec; +int i, j, fd, len, index; + +/* These are the (62) characters used in temporary filenames. */ +static const char letters[] =

Re: [Mingw-w64-public] [PATCH 1/2] stdlib.h: Add mkstemp implementation.

2015-01-07 Thread niXman
Dongsheng Song 2015-01-07 11:34: Since the last 6 characters must be XX is mandatory, I think no need such tricks. You do not know what will change through the 1,5,10 years. I think the merged condition statement is not very complicated. But why is it deliberately complicated? ps I

Re: [Mingw-w64-public] [PATCH 1/2] stdlib.h: Add mkstemp implementation.

2015-01-07 Thread niXman
dongsheng.s...@gmail.com 2015-01-07 10:29: From: 宋冬生 songdongsh...@live.cn Hi, --- mingw-w64-crt/Makefile.am | 2 +- mingw-w64-crt/misc/mkstemp.c | 91 ++ mingw-w64-headers/crt/stdlib.h | 1 + 3 files changed, 93 insertions(+), 1

[Mingw-w64-public] asctime_r duplications

2015-01-07 Thread Alexey Pavlov
Ladt changes to time functions lead to multiple definitions of asctime_r in some programs. For example, libtool: link: x86_64-w64-mingw32-g++ -shared -nostdlib C:/msys64/mingw64/lib/gcc/x86_64-w64-mingw32/4.9.2/../../../../x86_64-w64-mingw32/lib/../lib/dllcrt2.o

Re: [Mingw-w64-public] asctime_r duplications

2015-01-07 Thread Jacek Caban
Hi Alexey, On 01/07/15 09:06, Alexey Pavlov wrote: Ladt changes to time functions lead to multiple definitions of asctime_r in some programs. For example, I just pushed a fixup: http://sourceforge.net/p/mingw-w64/mingw-w64/ci/9f52135b2fa1336d63cda12c502f1790797387fa I wonder why it didn't

Re: [Mingw-w64-public] [patch]: Preparations and bug-fixing

2015-01-07 Thread Jacek Caban
Hi Kai, Patches look good to me. I have only clean up suggestions (feel free to ignore): On 01/07/15 12:46, Kai Tietz wrote: typedef struct _EAP_CRED_EXPIRY_REQ { EAP_CONFIG_INPUT_FIELD_ARRAY curCreds; EAP_CONFIG_INPUT_FIELD_ARRAY newCreds; -} EAP_CRED_EXPIRY_REQ,

Re: [Mingw-w64-public] [PATCH 2/2] pthread.h: Remove duplicate declaration of pthread_delay_np

2015-01-07 Thread Kai Tietz
Patch is ok. Thanks, Kai 2015-01-07 8:29 GMT+01:00 dongsheng.s...@gmail.com: From: 宋冬生 songdongsh...@live.cn --- mingw-w64-libraries/winpthreads/include/pthread.h | 1 - 1 file changed, 1 deletion(-) diff --git a/mingw-w64-libraries/winpthreads/include/pthread.h

[Mingw-w64-public] [PATCH] dwrite.h: Added missing DWRITE_INFORMATIONAL_STRING_ID values.

2015-01-07 Thread Jacek Caban
Those were added in SDK 8.1. OK to apply? --- mingw-w64-headers/include/dwrite.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mingw-w64-headers/include/dwrite.h b/mingw-w64-headers/include/dwrite.h index 3267977..0f6df58 100644 --- a/mingw-w64-headers/include/dwrite.h

Re: [Mingw-w64-public] asctime_r duplications

2015-01-07 Thread Jon
I slip-streamed Jacek's patch into time.h and successfully built go1.4 flavors (windows/amd64, windows/386, linux/amd64, linux/386, darwin/amd64, darwin/386) from my local C:\Apps\go-git repo. I currently don't use the MSYS2 mingw-w64-{i686,x86_64}-go pkgs. Now that I know about the them I'll try

[Mingw-w64-public] [patch]: Preparations and bug-fixing

2015-01-07 Thread Kai Tietz
This patch does some updates and bug-fixes required for iphlpapi.h, netioapi.h, ntddndis.h, and windot11.h updates on pipeline. Ok for apply? Regards, Kai From c0f2525ac5acf95e50aa762ab1ecfc7c20330ff1 Mon Sep 17 00:00:00 2001 From: Kai Tietz ktiet...@googlemail.com Date: Mon, 22 Dec 2014

Re: [Mingw-w64-public] asctime_r duplications

2015-01-07 Thread Dongsheng Song
On Wed, Jan 7, 2015 at 7:33 PM, Jacek Caban ja...@codeweavers.com wrote: Hi Alexey, On 01/07/15 09:06, Alexey Pavlov wrote: Ladt changes to time functions lead to multiple definitions of asctime_r in some programs. For example, I just pushed a fixup:

Re: [Mingw-w64-public] asctime_r duplications

2015-01-07 Thread Ray Donnelly
On Wed, Jan 7, 2015 at 2:45 PM, Jon jon.for...@gmail.com wrote: Looks to be the issue behind my recent go build fail... $ pacman -Q | grep mingw mingw-w64-x86_64-binutils-git 2.25.r81689.f30b244-3 mingw-w64-x86_64-bzip2 1.0.6-2 mingw-w64-x86_64-cloog 0.18.1-3 mingw-w64-x86_64-crt-git

Re: [Mingw-w64-public] asctime_r duplications

2015-01-07 Thread Ray Donnelly
On Wed, Jan 7, 2015 at 11:45 AM, Dongsheng Song dongsheng.s...@gmail.com wrote: On Wed, Jan 7, 2015 at 7:33 PM, Jacek Caban ja...@codeweavers.com wrote: Hi Alexey, On 01/07/15 09:06, Alexey Pavlov wrote: Ladt changes to time functions lead to multiple definitions of asctime_r in some

Re: [Mingw-w64-public] asctime_r duplications

2015-01-07 Thread Jon
Looks to be the issue behind my recent go build fail... $ pacman -Q | grep mingw mingw-w64-x86_64-binutils-git 2.25.r81689.f30b244-3 mingw-w64-x86_64-bzip2 1.0.6-2 mingw-w64-x86_64-cloog 0.18.1-3 mingw-w64-x86_64-crt-git 4.0.0.4388.c7e4f8f-1 mingw-w64-x86_64-gcc 4.9.2-2 mingw-w64-x86_64-gcc-libs

Re: [Mingw-w64-public] [PATCH] dwrite.h: Added missing DWRITE_INFORMATIONAL_STRING_ID values.

2015-01-07 Thread Kai Tietz
Yes, patch looks good. Thanks, Kai 2015-01-07 16:06 GMT+01:00 Jacek Caban ja...@codeweavers.com: Those were added in SDK 8.1. OK to apply? --- mingw-w64-headers/include/dwrite.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)