Re: [Mingw-w64-public] [PATCH] crt: Fix comments in msvcrt-common.def.in

2024-03-03 Thread Martin Storsjö
On Sun, 3 Mar 2024, Pali Rohár wrote: On Sunday 03 March 2024 23:38:57 Martin Storsjö wrote: On Sun, 3 Mar 2024, Pali Rohár wrote: Ok, do you need me to resend this patch? Or would you fix this one missing semicolon during applying patch? I can fix the missing semicolon. And... I do not

Re: [Mingw-w64-public] [PATCH] crt: Fix comments in msvcrt-common.def.in

2024-03-03 Thread Pali Rohár
On Sunday 03 March 2024 23:38:57 Martin Storsjö wrote: > On Sun, 3 Mar 2024, Pali Rohár wrote: > > > Ok, do you need me to resend this patch? Or would you fix this one > > missing semicolon during applying patch? > > I can fix the missing semicolon. > > > And... I do not know how to better

Re: [Mingw-w64-public] [PATCH] crt: Fix comments in msvcrt-common.def.in

2024-03-03 Thread Martin Storsjö
On Sun, 3 Mar 2024, Pali Rohár wrote: Ok, do you need me to resend this patch? Or would you fix this one missing semicolon during applying patch? I can fix the missing semicolon. And... I do not know how to better write the commit message, so I would be happy if give me example of how to

Re: [Mingw-w64-public] [PATCH] crt: Fix comments in msvcrt-common.def.in

2024-03-03 Thread Pali Rohár
On Thursday 29 February 2024 10:16:47 Martin Storsjö wrote: > On Thu, 29 Feb 2024, Pali Rohár wrote: > > > On Wednesday 28 February 2024 23:24:25 Martin Storsjö wrote: > > > On Wed, 28 Feb 2024, Pali Rohár wrote: > > > > > > > All commented lines refers to non-underscore aliases for underscored

Re: [Mingw-w64-public] [PATCH] crt: Fix comments in msvcrt-common.def.in

2024-02-29 Thread Martin Storsjö
On Thu, 29 Feb 2024, Pali Rohár wrote: On Wednesday 28 February 2024 23:24:25 Martin Storsjö wrote: On Wed, 28 Feb 2024, Pali Rohár wrote: All commented lines refers to non-underscore aliases for underscored variant of functions. Aliases for some reasons are not prevent, e.g. because some

Re: [Mingw-w64-public] [PATCH] crt: Fix comments in msvcrt-common.def.in

2024-02-28 Thread Pali Rohár
On Wednesday 28 February 2024 23:24:25 Martin Storsjö wrote: > On Wed, 28 Feb 2024, Pali Rohár wrote: > > > All commented lines refers to non-underscore aliases for underscored > > variant of functions. Aliases for some reasons are not prevent, e.g. > > because some aliases are defined in other

Re: [Mingw-w64-public] [PATCH] crt: Fix comments in msvcrt-common.def.in

2024-02-28 Thread Martin Storsjö
On Wed, 28 Feb 2024, Pali Rohár wrote: All commented lines refers to non-underscore aliases for underscored variant of functions. Aliases for some reasons are not prevent, e.g. because some aliases are defined in other files (CRT_fp10.c and CRT_fp8.c). I don't understand what the second

[Mingw-w64-public] [PATCH] crt: Fix comments in msvcrt-common.def.in

2024-02-28 Thread Pali Rohár
All commented lines refers to non-underscore aliases for underscored variant of functions. Aliases for some reasons are not prevent, e.g. because some aliases are defined in other files (CRT_fp10.c and CRT_fp8.c). --- mingw-w64-crt/def-include/msvcrt-common.def.in | 15 --- 1 file