Re: [Mingw-w64-public] [PATCH] variadic functions can't be stdcall

2016-08-22 Thread Kai Tietz
2016-08-22 9:11 GMT+02:00 Martin Storsjö : > On Sun, 21 Aug 2016, David Wohlferd wrote: > >> As my expert on patch etiquette, I have a question for you. When >> posting a patch, does one traditionally include all the files that will >> be in the push? Or do you skip the 'generated' files to make

Re: [Mingw-w64-public] [PATCH] variadic functions can't be stdcall

2016-08-22 Thread Martin Storsjö
On Sun, 21 Aug 2016, David Wohlferd wrote: > As my expert on patch etiquette, I have a question for you. When > posting a patch, does one traditionally include all the files that will > be in the push? Or do you skip the 'generated' files to make the review > easier? I guess it depends on the p

Re: [Mingw-w64-public] [PATCH] variadic functions can't be stdcall

2016-08-22 Thread David Wohlferd
On 8/21/2016 11:19 PM, Martin Storsjö wrote: > On Sun, 21 Aug 2016, David Wohlferd wrote: > >> By definition, functions with variable numbers of parameters cannot be >> stdcall. Clang complains (warning: stdcall calling convention ignored on >> variadic function). >> >> Attached. > Seems ok to me.

Re: [Mingw-w64-public] [PATCH] variadic functions can't be stdcall

2016-08-21 Thread Martin Storsjö
On Sun, 21 Aug 2016, David Wohlferd wrote: > By definition, functions with variable numbers of parameters cannot be > stdcall. Clang complains (warning: stdcall calling convention ignored on > variadic function). > > Attached. Seems ok to me. I assume GCC did the same, ignored the attribute si

[Mingw-w64-public] [PATCH] variadic functions can't be stdcall

2016-08-21 Thread David Wohlferd
By definition, functions with variable numbers of parameters cannot be stdcall. Clang complains (warning: stdcall calling convention ignored on variadic function). Attached. dw diff --git a/mingw-w64-headers/include/strsafe.h b/mingw-w64-headers/include/strsafe.h index 8d26b6a..36c7796 10064