Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-15 Thread Jacek Caban
On 06/14/12 11:55, Yaakov (Cygwin/X) wrote: On 2012-06-12 03:51, Jacek Caban wrote: On 06/12/12 07:06, Yaakov (Cygwin/X) wrote: On 2012-06-04 04:04, Jacek Caban wrote: Where? I don't see any. There is one change to propkeydef.h, but and I believe incorrect. Generally, this patch makes REFIID

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-15 Thread Yaakov (Cygwin/X)
On 2012-06-15 03:46, Jacek Caban wrote: On 06/14/12 11:55, Yaakov (Cygwin/X) wrote: Both mingw.org and Wine support CINTERFACE wrt the REF*ID defines. Thanks for the report, I've fixed Wine [1]. Not AFAICS. Look at all the places where REF*ID is taken as an argument which are conditional on

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-15 Thread Jacek Caban
On 06/15/12 11:42, Yaakov (Cygwin/X) wrote: On 2012-06-15 03:46, Jacek Caban wrote: On 06/14/12 11:55, Yaakov (Cygwin/X) wrote: Both mingw.org and Wine support CINTERFACE wrt the REF*ID defines. Thanks for the report, I've fixed Wine [1]. Not AFAICS. Look at all the places where REF*ID is

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-14 Thread Yaakov (Cygwin/X)
On 2012-06-12 03:51, Jacek Caban wrote: On 06/12/12 07:06, Yaakov (Cygwin/X) wrote: On 2012-06-04 04:04, Jacek Caban wrote: Where? I don't see any. There is one change to propkeydef.h, but and I believe incorrect. Generally, this patch makes REFIID and similar typedefs depend on CINTERFACE,

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-14 Thread Yaakov (Cygwin/X)
On 2012-06-12 04:37, Kai Tietz wrote: 2012/6/12 Yaakov (Cygwin/X): Currently I get: /usr/i686-w64-mingw32/sys-root/mingw/lib/libmsvcrt.a(daqubs01139.o):(.text+0x0): multiple definition of `_swprintf' io_stream_file.o:/usr/i686-w64-mingw32/sys-root/mingw/include/wchar.h:547: first defined

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-12 Thread Yaakov (Cygwin/X)
On 2012-06-04 02:10, Kai Tietz wrote: The change in crt/wchar.h about __mingw_ovr macro looks wrong to me, or at least inconsistent. As stdio.h has same macro. At least a libstdc++ bootstrap test is required for this change. Currently I get:

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-12 Thread Yaakov (Cygwin/X)
On 2012-06-04 04:04, Jacek Caban wrote: Where? I don't see any. There is one change to propkeydef.h, but and I believe incorrect. Generally, this patch makes REFIID and similar typedefs depend on CINTERFACE, which is not present in MSVC. According to these, it is:

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-12 Thread Jacek Caban
On 06/12/12 07:06, Yaakov (Cygwin/X) wrote: On 2012-06-04 04:04, Jacek Caban wrote: Where? I don't see any. There is one change to propkeydef.h, but and I believe incorrect. Generally, this patch makes REFIID and similar typedefs depend on CINTERFACE, which is not present in MSVC. According

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-12 Thread Jacek Caban
On 06/12/12 10:51, Jacek Caban wrote: On 06/12/12 07:06, Yaakov (Cygwin/X) wrote: On 2012-06-04 04:04, Jacek Caban wrote: Where? I don't see any. There is one change to propkeydef.h, but and I believe incorrect. Generally, this patch makes REFIID and similar typedefs depend on CINTERFACE,

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-12 Thread Earnie Boyd
On Tue, Jun 12, 2012 at 5:11 AM, Jacek Caban wrote: On 06/12/12 10:51, Jacek Caban wrote: On 06/12/12 07:06, Yaakov (Cygwin/X) wrote: On 2012-06-04 04:04, Jacek Caban wrote: Where? I don't see any. There is one change to propkeydef.h, but and I believe incorrect. Generally, this patch makes

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-12 Thread Earnie Boyd
On Tue, Jun 12, 2012 at 6:53 AM, Earnie Boyd wrote: We (mingw.org) doesn't support COM and never has.  A GCC supported IDL compiler would be great but whose going to pick up the support on that? Please excuse my improper English, s/doesn't/do not/ -- Earnie --

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-12 Thread Jacek Caban
On 06/12/12 12:53, Earnie Boyd wrote: On Tue, Jun 12, 2012 at 5:11 AM, Jacek Caban wrote: On 06/12/12 10:51, Jacek Caban wrote: On 06/12/12 07:06, Yaakov (Cygwin/X) wrote: On 2012-06-04 04:04, Jacek Caban wrote: Where? I don't see any. There is one change to propkeydef.h, but and I believe

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-11 Thread Kai Tietz
Yaakov, ping. Not sure if you still have interest to get your patch into our repository. The part about hiding dllimport needs a change in your patch. Also your changes about MIDL part (see Jacek's comment for this) need adjustment. I am still waiting for a revised version or it. As soon as

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-06 Thread JonY
On 6/4/2012 18:00, JonY wrote: On 6/4/2012 17:04, Jacek Caban wrote: On 06/03/12 17:45, JonY wrote: Forwarding to mingw-w64 list. Some of the headers modified is generated from WINE widl, so the preprocessor should be changed instead, jacek? Where? I don't see any. There is one change to

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-04 Thread Kai Tietz
Hello, here is my review about Yaakov's patch. The change in crt/wchar.h about __mingw_ovr macro looks wrong to me, or at least inconsistent. As stdio.h has same macro. At least a libstdc++ bootstrap test is required for this change. The hunks about guiddef.h are ok. The hunk about ntdef.h is

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-04 Thread Ozkan Sezer
On Mon, Jun 4, 2012 at 10:10 AM, Kai Tietz ktiet...@googlemail.com wrote: Hello, here is my review about Yaakov's patch. The change in crt/wchar.h about __mingw_ovr macro looks wrong to me, or at least inconsistent.  As stdio.h has same macro.  At least a libstdc++ bootstrap test is

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-04 Thread Jacek Caban
On 06/03/12 17:45, JonY wrote: Forwarding to mingw-w64 list. Some of the headers modified is generated from WINE widl, so the preprocessor should be changed instead, jacek? Where? I don't see any. There is one change to propkeydef.h, but and I believe incorrect. Generally, this patch makes

[Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-03 Thread JonY
Forwarding to mingw-w64 list. Some of the headers modified is generated from WINE widl, so the preprocessor should be changed instead, jacek? Kai, Ozkan, what do you make of these changes (mingw64-headers.patch)? Original Message Subject: [PATCH v1] setup: allow building with

Re: [Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

2012-06-03 Thread JonY
On 6/3/2012 23:45, JonY wrote: Resending because of Cygwin-apps block, accidentally left an email address in. Forwarding to mingw-w64 list. Some of the headers modified is generated from WINE widl, so the preprocessor should be changed instead, jacek? Kai, Ozkan, what do you make of