Re: KNF for usr.bin?

2009-06-08 Thread Aaron W. Hsu
Hey Otto, Thanks for your message. From o...@drijf.net Fri Jun 5 10:56:27 2009 One other thing you need to consider: does the code in question need to be diffed with another repository, upstream or other BSD, for example. In the case of nvi it is.

Re: KNF for usr.bin?

2009-06-08 Thread patrick keshishian
On Mon, Jun 8, 2009 at 8:16 PM, Aaron W. Hsuarcf...@sacrideo.us wrote: Hey Otto, Thanks for your message. B B B B From o...@drijf.net Fri Jun B 5 10:56:27 2009 B B B B One other thing you need to consider: does the code in B B B B question need to be diffed with another

KNF for usr.bin?

2009-06-04 Thread Aaron W. Hsu
Hey all, I've been planning on doing some hacking on nvi in the tree, but I wanted to play around with style(9) first. Am I correct in assuming that KNF style is preferred for all code in the tree? -- Aaron W. Hsu arcf...@sacrideo.us | http://www.sacrideo.us Government is the great fiction,

Re: KNF for usr.bin?

2009-06-04 Thread Nick Holland
Aaron W. Hsu wrote: Hey all, I've been planning on doing some hacking on nvi in the tree, but I wanted to play around with style(9) first. Am I correct in assuming that KNF style is preferred for all code in the tree? yes, but... when you see developers doing KNF commits, they aren't

Re: KNF for usr.bin?

2009-06-04 Thread Aaron W. Hsu
Hey Nick, Thanks for your feedback. From n...@holland-consulting.net Thu Jun 4 23:58:12 2009 when you see developers doing KNF commits, they aren't doing it as the end goal, [...] Changing the whitespace in the source code doesn't improve OpenBSD.