Re: [Mixxx-devel] [PATCH] Add SSE3 optimized version of EngineFilterIIR

2011-01-06 Thread Owen Williams
Building on linux I get: src/engine/enginefilteriir.cpp:93: error: expected ‘,’ or ‘...’ before ‘FILTER’ referring to: EngineFilterIIR::EngineFilterIIR(const double *pCoefs, int iOrder FILTER) Owen On Wed, 2011-01-05 at 23:49 -0600, Gabriel M. Beddingfield wrote: Below was originally

Re: [Mixxx-devel] [PATCH] Add SSE3 optimized version of EngineFilterIIR

2011-01-06 Thread Gabriel M. Beddingfield
On Thu, 6 Jan 2011, Albert Santoni wrote: Thanks for the patch Gabriel. Great stuff. Has anyone benchmarked this vs. -O2 and -O3? Yes. I'll send my test setup where I tested speeds as well as fidelity. Long story short... I get about 20-50% performance boost on the filter. (Atom gets

Re: [Mixxx-devel] [PATCH] Add SSE3 optimized version of EngineFilterIIR

2011-01-06 Thread Gabriel M. Beddingfield
Gentlemen: On Thu, 6 Jan 2011, Owen Williams wrote: Building on linux I get: src/engine/enginefilteriir.cpp:93: error: expected ‘,’ or ‘...’ before ‘FILTER’ referring to: EngineFilterIIR::EngineFilterIIR(const double *pCoefs, int iOrder FILTER) Please disregard this patch. It does not

Re: [Mixxx-devel] [PATCH] Add SSE3 optimized version of EngineFilterIIR

2011-01-06 Thread Philip Whelan
This work needs to be done, so thanks a lot for taking a stab at it. Hopefully with time you can finally get it right. I'll see what I can do with it, although unfortunately this stuff is not my forte. -- Learn how

Re: [Mixxx-devel] [PATCH] Add SSE3 optimized version of EngineFilterIIR

2011-01-06 Thread Sean M. Pappalardo - D.J. Pegasus
Waitasec, if your patch was not being applied, how were you seeing speed improvements? Differences in optimization options? -- Gaining the trust of online customers is vital for the success of any company that requires

Re: [Mixxx-devel] [PATCH] Add SSE3 optimized version of EngineFilterIIR

2011-01-06 Thread Gabriel M. Beddingfield
On Friday, January 07, 2011 01:05:18 am Sean M. Pappalardo - D.J. Pegasus wrote: Waitasec, if your patch was not being applied, how were you seeing speed improvements? Differences in optimization options? I isolated enginefilteriir.cpp and wrote a test program for it and any new versions of