Re: [mkgmap-dev] link-pois-to-ways tags

2014-03-21 Thread Gerd Petermann
Hi Andrzej, fine :-) The previous patch worked for me as well, but r3117 is the cleaner solution, as it is closer to the alternative that uses continue in the style to create additional ways. Gerd > Date: Fri, 21 Mar 2014 23:33:47 +0100 > From: po...@poczta.onet.pl > To: mkgmap-dev@lists.mkgmap

Re: [mkgmap-dev] link-pois-to-ways tags

2014-03-21 Thread Andrzej Popowski
Hi Gerd, release r3117 seems to be correct, thanks! -- Best regards, Andrzej ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] link-pois-to-ways tags

2014-03-21 Thread Andrzej Popowski
Hi Gerd, > Attached is a patch for the 2nd approach. Unfortunately it doesn't solve the problem. See for example this node in previously provided sample: http://www.openstreetmap.org/node/2650495573 If I use whole tile from my map, then even the node, which is removed in sample, still remai

[mkgmap-dev] Commit: r3117: use same osm id for way that is added with makeCycleWay().

2014-03-21 Thread svn commit
Version mkgmap-r3117 was committed by gerd on Fri, 21 Mar 2014 use same osm id for way that is added with makeCycleWay(). This reduces the number of points which are converted to routing nodes and allows better optimization of bad angles. ___ mkgmap-d

Re: [mkgmap-dev] link-pois-to-ways tags

2014-03-21 Thread Steve Ratcliffe
On 21/03/14 20:10, Gerd Petermann wrote: @Steve: svn blame says the code with the CYCLEWAY_ID_OFFSET was added by you. Please check if that is (still) needed, I think it was just added to be able to identify these special ways when debugging? It was really added to Osm5XmlHandler in r1044. So

Re: [mkgmap-dev] mkgmap --check-styles and line count

2014-03-21 Thread Steve Ratcliffe
Hi Gerd As a result, empty lines are not counted. @Steve: I know that this part in TokenScanner is critical, so I don't dare to change it: if (c == '\n' || c == '\r') { while ((c = readChar()) == '\n' || c == '\r') val.append(c); .. } Thanks, good catc

Re: [mkgmap-dev] mkgmap --check-styles and line count

2014-03-21 Thread Gerd Petermann
Hi Bernd, the problem is caused by the empty lines in your style file and a routine which tries to detect all kinds of line feed and carriage return combinations (0x0a, 0x0d) as "end of line". As a result, empty lines are not counted. @Steve: I know that this part in TokenScanner is critical,

Re: [mkgmap-dev] link-pois-to-ways tags

2014-03-21 Thread Gerd Petermann
Hi Andrzej, ah, yes, that one shows the problem. The additional cycle way is added with a different (OSM) id (osm id incremented by CYCLEWAY_ID_OFFSET (0x1000)). Therefore all points of the original way appear on two different roads, all highway counts are incremented and thus the obsolete po

Re: [mkgmap-dev] mkgmap --check-styles and line count

2014-03-21 Thread Bernd Weigelt
Am Freitag, 21. März 2014, 20:21:33 schrieb Gerd Petermann: > please send the file with the error. I assume the line count is completely > wrong in case of these stack 0 errors. I have send the file in a PM thx Bernd ___ mkgmap-dev mailing list mkgmap-de

Re: [mkgmap-dev] link-pois-to-ways tags

2014-03-21 Thread Andrzej Popowski
Hi Gerd, > I see no hardcoded handling of highway=crossing. My bad, wrong guess and wrong thread. Problem is due to option make-opposite-cycleway. When used, way gets additional nodes, which accidentally happen to be crossing. Without crossing tag, mkgmap behave the same. See attached sampl

Re: [mkgmap-dev] mkgmap --check-styles and line count

2014-03-21 Thread Carlos Dávila
El 21/03/14 20:11, Bernd Weigelt escribió: Hi my style include a lot of rules like this: highway=footway[0x1200d resolution 23-23 continue] highway=footway[0x1100d resolution 24 continue] highway=footway & (bicycle=designated | bicycle=perm

Re: [mkgmap-dev] mkgmap --check-styles and line count

2014-03-21 Thread Gerd Petermann
Hi Bernd, please send the file with the error. I assume the line count is completely wrong in case of these stack 0 errors. Gerd > From: weigelt.be...@web.de > To: mkgmap-dev@lists.mkgmap.org.uk > Date: Fri, 21 Mar 2014 20:11:14 +0100 > Subject: [mkgmap-dev] mkgmap --check-styles and line count

[mkgmap-dev] mkgmap --check-styles and line count

2014-03-21 Thread Bernd Weigelt
Hi my style include a lot of rules like this: highway=footway[0x1200d resolution 23-23 continue] highway=footway[0x1100d resolution 24 continue] highway=footway & (bicycle=designated | bicycle=permissive | bicycle=official |

Re: [mkgmap-dev] link-pois-to-ways tags

2014-03-21 Thread GerdP
Hi Andrzej, I see no hardcoded handling of highway=crossing. Do you see this problem also with the default style? If yes, please post the id of the node. Gerd popej wrote > Hi Gerd, > > is there any hard-coded processing of points "highway=crossing"? I can > get ride of deformation of roads a

Re: [mkgmap-dev] link-pois-to-ways tags

2014-03-21 Thread Andrzej Popowski
Hi Gerd, is there any hard-coded processing of points "highway=crossing"? I can get ride of deformation of roads at these points. I have tried: highway=crossing {delete highway} and compilation without link-pois-to-ways option. I use mkgmap r3116, I always get roads like on attached picture.

Re: [mkgmap-dev] highway=path only for pedestrians?

2014-03-21 Thread Marko Mäkelä
Hi Gerd, AFAIU the rule highway=path {set highway=footway} should be removed. Yes, that sounds correct. One reason for the current situation could be that you might not want to route bicycles to a narrow forest path, especially in the autumn when it is muddy, or in the winter when there is

[mkgmap-dev] highway=path only for pedestrians?

2014-03-21 Thread Gerd Petermann
Hi all, for a way that has only the tag highway=path the default style (lines) rule highway=path {set highway=footway} fires. I think that's wrong, the wiki says "A route open to the public which is not intended for motor vehicles, unless so tagged separately." so we should also allow bikes. Th

Re: [mkgmap-dev] mkgmap and route restrictions

2014-03-21 Thread nwillink
Thanks both of you for putting me right ! r Nick -- View this message in context: http://gis.19327.n5.nabble.com/mkgmap-and-route-restrictions-tp5800402p5800533.html Sent from the Mkgmap Development mailing list archive at Nabble.com. ___ mkgmap-dev

Re: [mkgmap-dev] mkgmap and route restrictions

2014-03-21 Thread Minko
Nick, designation= public_footpath is not enough, you should add foot=yes or foot=designated to the OSM data. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] mkgmap and route restrictions

2014-03-21 Thread Gerd Petermann
Hi Nick, yes, if your style allows pedestrians for designation= public_footpath ways. With r3116 and the default style and original data I see the same long way for both start points. When I add the tag foot=yes to way 20138647 I see the same short route for both start points. Gerd > Date: Fri

Re: [mkgmap-dev] mkgmap and route restrictions

2014-03-21 Thread nwillink
Hi Gerd yes, I didn't use the default style - apologies for having lead you up the 'garden path' It does have 'designation= public_footpath' which should allow pedestrians? Thanks for your Time r Nick -- View this message in context: http://gis.19327.n5.nabble.com/mkgmap-and-route-restrict

Re: [mkgmap-dev] mkgmap and route restrictions

2014-03-21 Thread Gerd Petermann
Hi Nick, I can't reproduce the result with r3116 and default style. The first part of road Highlands Park http://www.openstreetmap.org/way/20138647 is forbidden for all vehicles and pedestrian! The default style doesn't evaluate tag designation=* I think that should be changed. Besides that I