Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-08 Thread Greg Troxel
Marko Mäkelä writes: > On Tue, Oct 04, 2011 at 07:18:43PM +0200, WanMil wrote: >>> Maybe it would be a good solution, to look at first, if one node of the >>> polygon is tagged as building=entrance. If there is one, use this node >>> as POI-node, else create an node in the centre of the polygon.

Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-07 Thread Minko
I guess osmpbf.jar must be renamed first to osmprotobuf.jar? ;-) ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-07 Thread Minko
Wanmil, osmpbf.jar and protobuf.jar are included in your zip file, but that didnt help. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-07 Thread WanMil
Hi Minko, you must put the two jar files osmprotobuf.jar and protobuf.jar into the same directory like mkgmap.jar. WanMil > Hi Wanmil, > > I still get an error parsing file... > > wanmil wrote: > > my build file contained a wrong path to the pfb jars. I got no warning > because the build file d

Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-06 Thread Minko
Hi Wanmil, I still get an error parsing file... wanmil wrote: my build file contained a wrong path to the pfb jars. I got no warning because the build file detects automatically if the pbf jars are not available and deactivates the pbf support. The new file http://files.mkgmap.org.uk/detail/3

Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-06 Thread WanMil
Henning, my build file contained a wrong path to the pfb jars. I got no warning because the build file detects automatically if the pbf jars are not available and deactivates the pbf support. The new file http://files.mkgmap.org.uk/detail/35 should work now. WanMil > Hi Wanmil, > I tried to t

Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-04 Thread Charlie Ferrero
On 05/10/2011 00:48, WanMil wrote: > ... and will also tell you where it is uploaded to... ;-) > http://files.mkgmap.org.uk/detail/34 > > (my send button finger is too fast...) > > WanMil > Looking good to me: http://cferrero.net/maps/img/patch.html In the second example you can see how the POI fo

Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-04 Thread Henning Scholland
Hi Wanmil, I tried to test your uploaded version, but it seems not to work with pbf. Is it just a compiler-thing or is this an error caused by your patch? Henning Error at line 1, col 1 Bad file format: 1701.osm.pbf Error parsing file ___ mkgmap-

Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-04 Thread WanMil
... and will also tell you where it is uploaded to... ;-) http://files.mkgmap.org.uk/detail/34 (my send button finger is too fast...) WanMil > I have uploaded a mkgmap.jar r2045+patch for easier testing purposes. > > WanMil > >> The patch realizes the reimplementation of the add-pois-to-areas op

Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-04 Thread WanMil
I have uploaded a mkgmap.jar r2045+patch for easier testing purposes. WanMil > The patch realizes the reimplementation of the add-pois-to-areas option > as discussed in thread > http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2011q3/012391.html > > Some notes: > * Each POI created by the new Area2P

Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-04 Thread Marko Mäkelä
On Tue, Oct 04, 2011 at 07:18:43PM +0200, WanMil wrote: >> Maybe it would be a good solution, to look at first, if one node of the >> polygon is tagged as building=entrance. If there is one, use this node >> as POI-node, else create an node in the centre of the polygon. > >That would be easy to rea

Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-04 Thread WanMil
> Maybe it would be a good solution, to look at first, if one node of the > polygon is tagged as building=entrance. If there is one, use this node > as POI-node, else create an node in the centre of the polygon. That would be easy to realize. For mulitpolygons one could also check if there is a p

Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-04 Thread Henning Scholland
Maybe it would be a good solution, to look at first, if one node of the polygon is tagged as building=entrance. If there is one, use this node as POI-node, else create an node in the centre of the polygon. @WanMil: Do you see a more or less easy way to control the creation of POI out of areas w

Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-04 Thread Marko Mäkelä
On Tue, Oct 04, 2011 at 09:32:40AM +0300, Bartosz Fabianowski wrote: >>Therefore, I have been tagging the main entrance with the same tags as >>the building polygon, replacing building=yes with building=entrance. >>Is this really tagging for renderers? > >I would say it is not tagging for the ren

Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-03 Thread Bartosz Fabianowski
> Therefore, I have been tagging the main entrance with the same tags as > the building polygon, replacing building=yes with building=entrance. Is > this really tagging for renderers? I would say it is not tagging for the renderer but it is odd tagging nonetheless. A building=entrance should be a

Re: [mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-03 Thread Marko Mäkelä
On Mon, Oct 03, 2011 at 10:09:28PM +0200, WanMil wrote: > 3. Skip areas which contains a POI with the same name > => If you follow the rule "don't tag for renders" there should >be an area OR a POI but not both. I would like to keep this, if possible. For large buildings, the location of th

[mkgmap-dev] [PATCH v1] Reimplementation of add-pois-to-areas option

2011-10-03 Thread WanMil
The patch realizes the reimplementation of the add-pois-to-areas option as discussed in thread http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2011q3/012391.html Some notes: * Each POI created by the new Area2POIHook is tagged with mkgmap:area2poi=true * For each multipolygon one POI is created