Re: [mkgmap-dev] [PATCH v3] Mp merge: generate-sea: bugfix for generate-sea=multipolygon

2010-01-17 Thread Mark Burton
WanMil, > Good news - I don't think it's your problem. I disabled the sea > generation completely and the lines on the tile edges are still there. Oops, I may have spoken too soon. With your v3 patch in place, I made a new map with generate-sea=polygons and not only are the lines still there, al

Re: [mkgmap-dev] [PATCH v3] Mp merge: generate-sea: bugfix for generate-sea=multipolygon

2010-01-17 Thread Felix Hartmann
> Another idea is to introduce a kind of ShapeDetector which tries to > regenerate the original shape of a tile / OSM dump. I don't have a good > idea how to do this and I have less idea how to do this in acceptable time. > Maybe we can use an java.awt.geom.Area object and add all lines with a > d

Re: [mkgmap-dev] [PATCH v3] Mp merge: generate-sea: bugfix for generate-sea=multipolygon

2010-01-17 Thread WanMil
> > WanMil, > > Good news - I don't think it's your problem. I disabled the sea > generation completely and the lines on the tile edges are still there. > > Haven't a clue what's causing them (and I don't care because they don't > show up when I use generate-sea=polygons). > > One issue that I don'

Re: [mkgmap-dev] [PATCH v3] Mp merge: generate-sea: bugfix for generate-sea=multipolygon

2010-01-17 Thread Mark Burton
WanMil, Good news - I don't think it's your problem. I disabled the sea generation completely and the lines on the tile edges are still there. Haven't a clue what's causing them (and I don't care because they don't show up when I use generate-sea=polygons). One issue that I don't think you can

Re: [mkgmap-dev] [PATCH v3] Mp merge: generate-sea: bugfix for generate-sea=multipolygon

2010-01-17 Thread Mark Burton
WanMil, > My workaround was based on the assumption that all polygons created by > the mp code will be clipped to the bounding box later (by the style > code). Can you confirm that? Yes, polys are clipped in StyledConverter.addShape(). I looked at the output using mapedit and the land has no

Re: [mkgmap-dev] [PATCH v3] Mp merge: generate-sea: bugfix for generate-sea=multipolygon

2010-01-17 Thread WanMil
> It's interesting that the line is not visible in the sea polygons. > My workaround was based on the assumption that all polygons created by the mp code will be clipped to the bounding box later (by the style code). Can you confirm that? ___ mkgmap-d

Re: [mkgmap-dev] [PATCH v3] Mp merge: generate-sea: bugfix for generate-sea=multipolygon

2010-01-17 Thread Mark Burton
WanMil, > at the moment I have no idea why tile boundaries are visible. What do > you see if you zoom in? Do you see any kind of line style or is it just > an empty line? Just a line with a bluey-purpley colour. Look at the image in the last email and zoom right in to that and you will see it'

Re: [mkgmap-dev] [PATCH v3] Mp merge: generate-sea: bugfix for generate-sea=multipolygon

2010-01-17 Thread WanMil
> > Hi WanMil, > > The v3 patch is working well with the Baltic map. The main land masses > are there and I haven't yet spotted any missing islands. > > One issue, the boundaries of the tiles are visible on the land at all > zoom levels (see visible-tile-boundaries.png). The boundaries are not > vi

Re: [mkgmap-dev] [PATCH v3] Mp merge: generate-sea: bugfix for generate-sea=multipolygon

2010-01-17 Thread Mark Burton
Hi WanMil, The v3 patch is working well with the Baltic map. The main land masses are there and I haven't yet spotted any missing islands. One issue, the boundaries of the tiles are visible on the land at all zoom levels (see visible-tile-boundaries.png). The boundaries are not visible on the se

[mkgmap-dev] [PATCH v3] Mp merge: generate-sea: bugfix for generate-sea=multipolygon

2010-01-17 Thread WanMil
Sorry, I forgot to include one class in the last patch so that it did not compile. WanMil Index: src/uk/me/parabola/mkgmap/reader/osm/xml/Osm5XmlHandler.java === --- src/uk/me/parabola/mkgmap/reader/osm/xml/Osm5XmlHandler.java