Re: [mkgmap-dev] conditional includes in style

2014-03-28 Thread Henning Scholland
Hi Felix Am 27.03.2014 19:59, schrieb Felix Hartmann: That is also quite nice, my main problem with this approach is - can we by now assume that the mkgmap:country tag is 99.9% available correctly when using precompiled bounds? I haven't heard about any complaints about this. if not

[mkgmap-dev] conditional includes in style

2014-03-27 Thread Gerd Petermann
Hi Felix, I've started a new thread for this as your post was a bit off topic here: http://gis.19327.n5.nabble.com/Patch-v5-correct-make-cycleways-tp5800981p5801182.html I had the same idea when I tried to find a solution for the --make-opposite-cycleways option in the style, but then I

Re: [mkgmap-dev] conditional includes in style

2014-03-27 Thread Thorsten Kukuk
On Thu, Mar 27, Gerd Petermann wrote: Your proposition sounds like #ifdef / #endif in a c /c++ prepro combined with defines passed to the compiler. This is what I'm doing with my style already. I use #ifdef/#endif and before executing mkgmap I create a local copy of the style with help of

Re: [mkgmap-dev] conditional includes in style

2014-03-27 Thread Henning Scholland
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Gerd, I quote a mail, which I wrote some month ago to the list: while cycling in New Zealand I found out, thats a little bit to easy just taking a style (routing and map-look) and use it in parts of the world, which are very different to

Re: [mkgmap-dev] conditional includes in style

2014-03-27 Thread Gerd Petermann
Hi Henning, where would you want to set the value for key ? Gerd Date: Thu, 27 Mar 2014 08:24:51 +0100 From: o...@aighes.de To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] conditional includes in style -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Gerd, I quote

Re: [mkgmap-dev] conditional includes in style

2014-03-27 Thread Gerd Petermann
Hi Thorsten, This is what I'm doing with my style already. I use #ifdef/#endif and before executing mkgmap I create a local copy of the style with help of cpp. I like that more, because I can check the resulting style and find errors much easier then if I would need to guess what mkgmap is

Re: [mkgmap-dev] conditional includes in style

2014-03-27 Thread Andrzej Popowski
Hi Gerd, here my idea: 1. Allow for nested conditions in style. For example current lines: mkgmap:country=NLD mkgmap:region!=* ... mkgmap:country=NLD mkgmap:city!=* ... could be rewritten as: mkgmap:country=NLD { do { mkgmap:region!=* ... mkgmap:city!=* ... } } 2. Allow for

Re: [mkgmap-dev] conditional includes in style

2014-03-27 Thread Henning Scholland
Hi Gerd, maybe it gets a little bit clearer if I gave an example. if ( mkgmap:country=DEU ) { include 'deu_highway_rules'; } or if (mkgmap:country=DEU) { highway=primary { set mkgmap:access=no } highway=... {...} ... } Henning ___

Re: [mkgmap-dev] conditional includes in style

2014-03-27 Thread Marko Mäkelä
First, the conditional rules or includes sounds like a good idea. I guess we should only allow the new syntax for key=value or maybe key=*. Should we introduce a new type of keys (global keys) that are not associated with any OSM object? Or, should the global keys be the default on every

Re: [mkgmap-dev] conditional includes in style

2014-03-27 Thread Andrzej Popowski
Hi Marko, Should we introduce a new type of keys (global keys) that are not associated with any OSM object? This would be handy for conditional interpreting of style. java -jar mkgmap.jar --add-default-way-tag=name=unknown Or maybe that way: mkgmap.jar --style-option=default_name=unknown

Re: [mkgmap-dev] conditional includes in style

2014-03-27 Thread Felix Hartmann
That is also quite nice, my main problem with this approach is - can we by now assume that the mkgmap:country tag is 99.9% available correctly when using precompiled bounds? if not passing options from commandline is in this case more reliable - because if you know that you only have input

Re: [mkgmap-dev] conditional includes in style

2014-03-27 Thread Marko Mäkelä
On Thu, Mar 27, 2014 at 07:59:24PM +0100, Felix Hartmann wrote: That is also quite nice, my main problem with this approach is - can we by now assume that the mkgmap:country tag is 99.9% available correctly when using precompiled bounds? [snip] if ( mkgmap:country=DEU ) { include

Re: [mkgmap-dev] conditional includes in style

2014-03-27 Thread Michał Rogala
2014-03-27 19:59 GMT+01:00 Felix Hartmann extremecar...@gmail.com: That is also quite nice, my main problem with this approach is - can we by now assume that the mkgmap:country tag is 99.9% available correctly when using precompiled bounds? I wouldn't take that for granted - I use my own