Re: [9] RFR (S): 8057657: Annotate LambdaForm parameters with types

2014-09-09 Thread Paul Sandoz
+1 to both. On Sep 9, 2014, at 3:22 PM, Vladimir Ivanov wrote: >>> http://cr.openjdk.java.net/~vlivanov/8057657/webrev.00/ >>> https://bugs.openjdk.java.net/browse/JDK-8057657 >>> >> >> - BoundMethodHandle >> >> 57 assert(speciesData() == speciesData(form)); >> >> I am missing som

Re: [9] RFR (L): Improve LambdaForm sharing by using LambdaFormEditor more extensively

2014-09-09 Thread Paul Sandoz
On Sep 9, 2014, at 3:39 PM, Vladimir Ivanov wrote: > Paul, thanks for review! > +1 Paul. > Updated webrev in place. > >>> http://cr.openjdk.java.net/~vlivanov/8057922/webrev.00 >>> https://bugs.openjdk.java.net/browse/JDK-8057922 >>> >>> Introduce more sharing on LambdaForm level by rewr

Re: [9] RFR (L): Improve LambdaForm sharing by using LambdaFormEditor more extensively

2014-09-09 Thread Vladimir Ivanov
Paul, thanks for review! Updated webrev in place. http://cr.openjdk.java.net/~vlivanov/8057922/webrev.00 https://bugs.openjdk.java.net/browse/JDK-8057922 Introduce more sharing on LambdaForm level by rewriting most of the MH combinators using LambdaFormEditor. The new code is guarded by USE_

Re: [9] RFR (S): 8057657: Annotate LambdaForm parameters with types

2014-09-09 Thread Vladimir Ivanov
http://cr.openjdk.java.net/~vlivanov/8057657/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8057657 - BoundMethodHandle 57 assert(speciesData() == speciesData(form)); I am missing some context here as to how that assert would pass for anything other than Species_L, namely for

Re: [9] RFR (L): Improve LambdaForm sharing by using LambdaFormEditor more extensively

2014-09-09 Thread Paul Sandoz
On Sep 9, 2014, at 12:51 PM, Vladimir Ivanov wrote: > http://cr.openjdk.java.net/~vlivanov/8057922/webrev.00 > https://bugs.openjdk.java.net/browse/JDK-8057922 > > Introduce more sharing on LambdaForm level by rewriting most of the MH > combinators using LambdaFormEditor. > > The new code is

Re: [9] RFR (S): 8057657: Annotate LambdaForm parameters with types

2014-09-09 Thread Paul Sandoz
On Sep 5, 2014, at 12:12 PM, Vladimir Ivanov wrote: > http://cr.openjdk.java.net/~vlivanov/8057657/webrev.00/ > https://bugs.openjdk.java.net/browse/JDK-8057657 > - BoundMethodHandle 57 assert(speciesData() == speciesData(form)); I am missing some context here as to how that asser

Re: usage of Class#getSimpleName() in MethodType#toString()

2014-09-09 Thread Jochen Theodorou
thanks Am 09.09.2014 12:13, schrieb Vladimir Ivanov: Jochen, Thanks for the report. I agree with your evaluation. I filed JDK-8057919 [1] to track that. Best regards, Vladimir Ivanov [1] https://bugs.openjdk.java.net/browse/JDK-8057919 On 9/9/14, 1:33 PM, Jochen Theodorou wrote: so there is

[9] RFR (L): Improve LambdaForm sharing by using LambdaFormEditor more extensively

2014-09-09 Thread Vladimir Ivanov
http://cr.openjdk.java.net/~vlivanov/8057922/webrev.00 https://bugs.openjdk.java.net/browse/JDK-8057922 Introduce more sharing on LambdaForm level by rewriting most of the MH combinators using LambdaFormEditor. The new code is guarded by USE_LAMBDA_FORM_EDITOR flag and turned off by default b

Re: usage of Class#getSimpleName() in MethodType#toString()

2014-09-09 Thread Vladimir Ivanov
Jochen, Thanks for the report. I agree with your evaluation. I filed JDK-8057919 [1] to track that. Best regards, Vladimir Ivanov [1] https://bugs.openjdk.java.net/browse/JDK-8057919 On 9/9/14, 1:33 PM, Jochen Theodorou wrote: so there is no good reason for that? Am 02.09.2014 10:59, schrieb

Re: [9] RFR (S) 8057656: Improve MethodType.isCastableTo() & MethodType.isConvertibleTo() checks

2014-09-09 Thread Vladimir Ivanov
Thank you, Paul. Best regards, Vladimir Ivanov On 9/9/14, 2:05 PM, Paul Sandoz wrote: On Sep 5, 2014, at 6:42 PM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8057656/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8057656 854 if (!canConvert(returnType(), new

Re: [9] RFR (S) 8057656: Improve MethodType.isCastableTo() & MethodType.isConvertibleTo() checks

2014-09-09 Thread Paul Sandoz
On Sep 5, 2014, at 6:42 PM, Vladimir Ivanov wrote: > >> http://cr.openjdk.java.net/~vlivanov/8057656/webrev.00/ >>> https://bugs.openjdk.java.net/browse/JDK-8057656 >>> >> >> 854 if (!canConvert(returnType(), newType.returnType())) >> 855 return false; >> 856 Clas

Re: usage of Class#getSimpleName() in MethodType#toString()

2014-09-09 Thread Jochen Theodorou
so there is no good reason for that? Am 02.09.2014 10:59, schrieb Jochen Theodorou: Hi, I just wanted to ask, why Class#getSimpleName() is used in MethodType#toString(). People knowing this method from Class will also know that getSimpleName makes assumption about the inner class names, that ar

Re: Unloading LambdaForm bytecode

2014-09-09 Thread John Rose
On Sep 9, 2014, at 12:11 AM, Martin Traverso wrote: > Hi John, > > Thanks for the detailed explanation. > > I ran a few additional experiments after I wrote a simpler program to try to > reproduce the issue. I don't see the permgen leak, so something else must be > causing it in Presto. I do

Re: Unloading LambdaForm bytecode

2014-09-09 Thread Martin Traverso
Hi John, Thanks for the detailed explanation. I ran a few additional experiments after I wrote a simpler program to try to reproduce the issue. I don't see the permgen leak, so something else must be causing it in Presto. I do see the "Loaded..." messages without a corresponding "Unloaded...", so