product bug then.
-Konstantin
On 06/03/2015 11:47 PM, Igor Ignatyev wrote:try to reproduce failres
Konstantin,
do you have an explanation why the test passes on jdk 9?
from my point of view, it indicates there is a product bug in 8u which
should be fixed and your fix just hides it.
Igor
On 06
Konstantin,
do you have an explanation why the test passes on jdk 9?
from my point of view, it indicates there is a product bug in 8u which
should be fixed and your fix just hides it.
Igor
On 06/03/2015 10:14 PM, Seán Coffey wrote:
I bumped into this failure myself today. I think you've got
long.class,
int.class,
byte.class,
Integer[].class,
double[].class,
String.class,
Best regards,
Vladimir Ivanov
On 5/18/15 8:51 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev/8055269/webrev.00/
23 lines
http://cr.openjdk.java.net/~iignatyev/8055269/webrev.00/
23 lines changed: 8 ins; 9 del; 6 mod
Hi all,
please review the tiny fix for CatchExceptionTest test.
problem: the tests generates a target w/ 255 parameters, so a
corresponding handler should have 256 parameters. that violates
restrict
http://cr.openjdk.java.net/~iignatyev/8039953/webrev.01/
to have TimeLimitedRunner more general, I've added 'factor' argument to
its ctor.
Thanks,
Igor
On 12/01/2014 02:39 PM, Igor Ignatyev wrote:
Paul/Vladimir,
thanks for review.
On 12/01/2014 01:29 PM, Vladimir Ivanov wro
don't think that it's a right way, but it's the best that we
can do now. Even if jtreg provides startup time, it won't help us w/ vm
shutdown time estimation.
Otherwise, looks good.
Best regards,
Vladimir Ivanov
Paul.
On Nov 29, 2014, at 5:36 PM, Igor Ignatyev
wrot
http://cr.openjdk.java.net/~iignatyev/8039953/webrev.00
98 lines changed: 93 ins; 3 del; 2 mod;
Hi all,
Please review the patch:
Problem:
on some configurations,
java/lang/invoke/MethodHandles/CatchExceptionTest.java can timeout
before all test cases are run
Fix:
interrupt test execution if
here
JDK-8046809 is fixed?
Igor
On 11/06/2014 06:20 PM, Konstantin Shefov wrote:
Igor,
Thanks for your comment!
Here is the updated webrev:
http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/
-Konstantin
On 06.11.2014 17:36, Igor Ignatyev wrote:
Konstantin,
please use 'java.vm.i
Konstantin,
please use 'java.vm.info' instead of iteration over flags.
Igor
On 11/06/2014 01:44 PM, Konstantin Shefov wrote:
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8062904
Webrev is http://cr.openjdk.java.net/~kshefov/8062904/webrev.00/
Thanks
-Konsta
) from TestMethods(String) instead of
copy&paste.
Thanks,
Igor
On 10/01/2014 05:46 PM, Konstantin Shefov wrote:
Thanks for reviewing
http://cr.openjdk.java.net/~kshefov/8058695/webrev.02
-Konstantin
On 01.10.2014 17:30, Igor Ignatyev wrote:
Hi Konstantin,
0. could you please introduce a
Hi Konstantin,
0. could you please introduce a ctor which sets the default value for
'maxArity' and use it instead of explicitly passed 'Helper.MAX_ARITY'?
1. there is a existing solution for your case w/ access to an private field of
an outer class:
> int desiredArity = Helper.RNG.nextInt(super
Hi,
looks good to me.
how have you tested your changes?
Thanks,
Igor
On 09/19/2014 01:50 PM, Konstantin Shefov wrote:
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058728
Webrev is http://cr.openjdk.java.net/~kshefov/8058728/webrev.00
Thanks
-Konstantin
_
Vladimir/Alan,
Yes, only WB.fullGC() is needed, I replaced it w/ System.gc() and
removed whitebox from the changes.
updated webrev :
http://cr.openjdk.java.net/~iignatyev/kshefov/8057707/webrev.00/
Thanks
Igor
On 09/12/2014 05:41 PM, Vladimir Ivanov wrote:
Alan,
I wasn't aware about such
Paul,
thanks for your review. I'll take care about this change, since
Konstantin is on vacation.
updated webrev:
http://cr.openjdk.java.net/~iignatyev/kshefov/8057719/webrev.00/
please see inline answers.
Igor
On 09/11/2014 05:12 PM, Paul Sandoz wrote:
On Sep 5, 2014, at 7:52 PM, Konsta
Vladimir,
instead of the trick w/ 'ClassFileInstaller', you can use
'bootclasspath' option[1] which adds all paths to the bootclasspath:
* @run main/bootclasspath java.lang.invoke.VarargsArrayTest
* @run main/bootclasspath
* -DVarargsArrayTest.MAX_ARITY=255 -DVarargsArrayTest.S
John,
unfortunately, I've already pushed my changes w/o junit annotation. But
I have the dirty patch which adds "jtreg support" to netbeans:
1. add test.single action for test folder to 'ide-actions' section in
JDK project -- jdk/make/netbeans/j2se/nbproject/project.xml:
e int droped;
Should be “dropped”.
Otherwise seems ok... But more comments would be appreciated. It’s huge and
really hard to understand.
igor
On Mar 28, 2014, at 9:04 AM, Igor Ignatyev wrote:
Vladimir,
as we'd arranged, I moved ThrowMode into TestCase and give my word that I&
xception
in JDK9 TF.
updated webrev: http://cr.openjdk.java.net/~iignatyev/8038186/webrev.03/
Thanks,
Igor
On 03/28/2014 03:31 PM, Igor Ignatyev wrote:
Vladimir, thanks for review, please my comments inline.
On 03/28/2014 01:29 PM, Vladimir Ivanov wrote:
Igor, thanks for improving the tests on met
. I'm not sure it'll improve
the code in any way (maybe TestNG will?). I hope John will express his
opinion on this, if it's important.
I hope the code's still quite readable and understandable.
Also I've added array return type.
http://cr.openjdk.java.net/~iignatyev/8038186/w
e added array return type.
http://cr.openjdk.java.net/~iignatyev/8038186/webrev.02/
Thanks,
Igor
On 03/27/2014 12:46 AM, Igor Ignatyev wrote:
Hi Chris,
This is very nice. Are there plans to do this for the other existing
tests as well?
sure, but we didn't have enough time to do it in 8u
be rewrite later. I hope we'll have
time in jdk 9 to refactor all tests in MethodHandles.
Thanks,
Igor
On 03/27/2014 12:38 AM, Christian Thalinger wrote:
On Mar 24, 2014, at 1:33 PM, Igor Ignatyev wrote:
Hi all,
Please review the patch:
Problems:
- MethodHandlesTest::testCatchEx
Hi all,
Please review the patch:
Problems:
- MethodHandlesTest::testCatchException() doesn't provide enough testing
of j.l.i.MethodHandles::catchException().
- MethodHandlesTest contains more than 3k lines, an auxiliary code
together w/ a test code, many methods aren't connected w/ each other,
22 matches
Mail list logo
