Thanks, Paul!
Best regards,
Vladimir Ivanov
On 1/12/15 9:42 PM, Paul Sandoz wrote:
On Jan 12, 2015, at 7:06 PM, Vladimir Ivanov
wrote:
Paul,
Thanks for the review!
Look good, +1,
Paul.
Updated webrev:
http://cr.openjdk.java.net/~vlivanov/8067344/webrev.02
70 TestMethod
On Jan 12, 2015, at 7:06 PM, Vladimir Ivanov
wrote:
> Paul,
>
> Thanks for the review!
>
Look good, +1,
Paul.
> Updated webrev:
> http://cr.openjdk.java.net/~vlivanov/8067344/webrev.02
>
>> 70 TestMethods testCase = getTestMethod();
>> 71 if (testCase == TestMetho
Paul,
Thanks for the review!
Updated webrev:
http://cr.openjdk.java.net/~vlivanov/8067344/webrev.02
70 TestMethods testCase = getTestMethod();
71 if (testCase == TestMethods.EXACT_INVOKER || testCase ==
TestMethods.INVOKER) {
72 // Invokers ar
Hello,
I don't have a comment on the changes to the test per se, but as someone
who keeps an eye on test failures that occur in regression tests in the
jdk repo of the JDK 9 dev forest, I'd like to see this test stop
failing, either by the test being fixed for, barring that, the testing
being
Hi
70 TestMethods testCase = getTestMethod();
71 if (testCase == TestMethods.EXACT_INVOKER || testCase ==
TestMethods.INVOKER) {
72 // Invokers aren't collected.
73 return;
74 }
Can you just filter those test cases out
Peter,
Thanks for the feedback!
Your idea to use SoftReferences and check the referent sounds interesting.
However, I'm in favor of PhantomReferences here. Though SoftRefs have
some benefits w.r.t. current LF cache implementation, they unnecessarily
leak implementation details into the test.
Hi Vladimir,
I just wanted to ask about the reason you used PhantomReference to
detect that a referent is not softly reachable any more. You could use
another SoftReference or a WeakReference for the same effect, since it
is guaranteed that all SoftReferences for same referent are cleared
ato
Spotted some more problems:
- need to skip identity operations (identity_* LambdaForms) in the
test, since corresponding LambdaForms reside in a permanent cache;
- need to keep original test data for diagnostic purposes, since
getTestCaseData() produces new instance.
Updated version:
htt
http://cr.openjdk.java.net/~vlivanov/8067344/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8067344
LFGarbageCollectedTest should be adjusted after JDK-8057020.
There are a couple of problems with the test.
(1) Existing logic to test that LambdaForm instance is collected isn't
stable enou
