[WikimediaMobile] Removing wfIncrStats from MobileFrontend's Special:MobileOptions page

2017-01-25 Thread Sam Smith
Hullo, Some time ago, the Reading Web team noticed that the Special:MobileOptions page is instrumented in two distinct ways: using EventLogging and wfIncrStats. We had a little spare bandwidth this sprint and got around to removing the wfIncrStats

Re: [WikimediaMobile] Getting link to a contact form to work using mobile view

2016-08-01 Thread Sam Smith
On Fri, Jul 29, 2016 at 11:22 PM, Bryan Davis wrote: > It would be a nice thing for someone to document this hook on > mediawiki.org. It seems that there are several hooks for > MobileFrontend that are currently undocumented [3]. > Duly Phabricated! [0] -Sam [0]: https://phabricator.wikimedia.

Re: [WikimediaMobile] Fwd: geo search is now live

2016-07-15 Thread Sam Smith
Nice work Erik (and any other folks that worked on this)! -Sam On Thu, Jul 14, 2016 at 11:07 PM, Corey Floyd wrote: > Super excited to start working on the UI for this. Thanks again for > getting this implemented! 🎉 > > On Thu, Jul 14, 2016 at 5:51 PM, Erik Bernhardson < > ebernhard...@wikimedi

Re: [WikimediaMobile] Tilman is joining the Reading Team!

2015-10-16 Thread Sam Smith
Awesome! Welcome Tilman! -Sam On Fri, Oct 16, 2015 at 6:27 AM, Florian Schmidt < florian.schmidt.wel...@t-online.de> wrote: > Welcome Tilman! :) > > > > -Original-Nachricht- > > Betreff: [WikimediaMobile] Tilman is joining the Reading Team! > > Datum: Fri, 16 Oct 2015 02:08:14 +0200 > >

[WikimediaMobile] Fwd: Mobile event log sampling

2015-10-02 Thread Sam Smith
Sharing with mobile-l. -Sam -- Forwarded message -- From: Sam Smith Date: Thu, Oct 1, 2015 at 9:29 AM Subject: Re: Mobile event log sampling To: Bernd Sitzmann Cc: Neil Quinn , Jon Katz I can confirm that MobileWebEditing (now Edit [0]) wasn't (isn't) sampled eit

Re: [WikimediaMobile] [Web] Minor drop in some EventLogging data last week

2015-09-08 Thread Sam Smith
> > The deployment schedule is not quite that simple. If you open the > 'Included in' section of the breaking commit, you can see it was included > in wmf/1.26wmf21. According to > https://www.mediawiki.org/wiki/MediaWiki_1.26/Roadmap that was deployed > to mediawiki.org, zero.wikimedia.org and som

[WikimediaMobile] [Web] Minor drop in some EventLogging data last week

2015-09-08 Thread Sam Smith
Hey y'all, Yesterday (Monday, 7th) Alex Monk submitted and subsequently back-ported and deployed a fix for an annoying bug in the code that registers the EventLogging schemas in the MobileFrontend extension [0]. The bug resulted in browse and diff click events failing to log as associated schemas

[WikimediaMobile] Breaking apart MobileFrontend's front and back ends

2015-09-01 Thread Sam Smith
Hey all, I've been encouraged to write an update on a 1%* project that I've been working on: separating the HTML formatter and APIs from the Minerva skin. Right now, I've created a new extension, which contains the code, associated configuration variables, and unit/integration tests [0] and am ru

Re: [WikimediaMobile] [reading-wmf] Is Schema:MobileWebClickTracking dead?

2015-07-31 Thread Sam Smith
Until we get a definite yes or no on whether talk pages should be used to track the status of the schemas, I've made the following changes: - I marked the MobileWatchlistInteraction and MobileWebUploads schemas as inactive, and - I marked the MobileOptionsTracking, MobileWebBrowse, Mob

Re: [WikimediaMobile] [Web] Outstanding branches

2015-07-06 Thread Sam Smith
Thanks both. The branch list is looking much neater. –Sam On Mon, Jul 6, 2015 at 5:52 PM, Max Semenik wrote: > esisupport is not needed anymore, I've nuked it, along with old deployment > branches. > > On Mon, Jul 6, 2015 at 8:47 AM, Sam Smith wrote: > >> Hey y'

[WikimediaMobile] [Web] Outstanding branches

2015-07-06 Thread Sam Smith
Hey y'all, There are a bunch of (stale?) branches open against MobileFrontend. Do we need to keep any of the following around? - esisupport - photouploads3 - sandbox/jdlrobson/ds - sandbox/jgonera/backbone - sandbox/jgonera/backbone-watchlist - sandbox/jgonera/edit - sandbox/

[WikimediaMobile] [video club] RailsConf 2015 - Implementing a Strong Code Review Culture

2015-06-29 Thread Sam Smith
Hey y'all, I watch a lot of talks in my downtime. I even post the ones I like to a Tumblr… sometimes [0]. I felt like sharing Derek Prior's "Implementing a Strong Code Review Culture" from RailsConf 2015 in particular because it's relevant to the conversations that the Reading Web team are having

[WikimediaMobile] [Web] Monday: QA Day

2015-06-26 Thread Sam Smith
The Reading Web team will be taking time every Monday to QA the mobile site. We're currently lining up work around improving our development, testing, and release processes. In fact, work on improving our browser testing infrastructure has already begun [0]. This work is all about reducing the siz

Re: [WikimediaMobile] [Update] Browser tests per patch

2015-06-18 Thread Sam Smith
I agree with Florian everything that you've written should be in a public version control system. Second, I'd ask that you document your experiences so far in getting this set up *and* how it works so that other members of the vertical can help to maintain it moving forward. Third, great work!!1

Re: [WikimediaMobile] [reading-wmf] [Web] Reverting commits

2015-06-16 Thread Sam Smith
t; the less sensible/feasible to revert it but I'm not sure. > > Just stuff to think about. I agree in principle we need to be more > diligent and extreme when regressions happen. > > > On Fri, Jun 12, 2015 at 8:38 AM, Adam Baso wrote: > >> Moving to mobile-l. >>

Re: [WikimediaMobile] Wikigrok code no longer being worked on

2015-06-16 Thread Sam Smith
> > Should they all get set to lowest priority to communicate to people > following WikiGrok > tasks that no-one plans to work on them > currently? > If so, please feel free to go ahead. Yes. Done. Thanks for adding me to the Triagers project Andre. –Sam On Thu, Jun 4, 2015 at 9:46 PM, Andre

Re: [WikimediaMobile] hacks I particularly liked at Lyon

2015-06-02 Thread Sam Smith
Dmitry's and Joaquin's hacks stand out for me both because of their quality and the obvious benefits we'd gain by following up on them. Aaron Halfaker's work, as usual, was great. I'm loath to call any of the projects that were presented "hacks", because they were all really high quality – apart f

Re: [WikimediaMobile] Removing upload interface code from MobileFrontend

2015-05-12 Thread Sam Smith
Neato! Could you create a task to get rid of the upload code if there isn't one already? The task you've linked from your patch [0] only covers not loading the styles [1]. –Sam [0] https://gerrit.wikimedia.org/r/#/c/210084/ [1] https://phabricator.wikimedia.org/T98402 On Tue, May 12, 2015 at 12:

Re: [WikimediaMobile] Removing upload interface code from MobileFrontend

2015-05-12 Thread Sam Smith
I agree that we should get Special:Upload working suitably well on mobile too. I'd consider that a blocker for removing the code. We have to act responsibly when removing code, regardless of how much we dislike it. –Sam On Tue, May 12, 2015 at 10:22 AM, Joaquin Oltra Hernandez < jhernan...@wikim

Re: [WikimediaMobile] Knowledge Transfer on MaxSem's API / Extension Work to Reading

2015-05-12 Thread Sam Smith
It's great to see this written down. I'd assumed that the Mobile Web *teams* were now responsible for maintaining those extensions and had been triaging bugs that landed in the mediawiki-extension-MobileFrontend and mobile-web projects as such. Max: would you be up for a doing a techmosis – a reco

Re: [WikimediaMobile] Skynet is winning the battle on IRC

2015-05-01 Thread Sam Smith
I'm in favour of moving the bots to another channel (or back to #wikimedia-dev) too. –Sam On Thu, Apr 30, 2015 at 11:00 PM, Monte Hurd wrote: > +1 > > > On Apr 30, 2015, at 10:29 AM, Joaquin Oltra Hernandez < > jhernan...@wikimedia.org> wrote: > > > > Hi! > > > > I've been feeling that the sign

Re: [WikimediaMobile] API Phabricator cards, list threads, other

2015-04-30 Thread Sam Smith
A simple first step would be to tag the FIXMEs with a small set of tags, like half of Jon's examples already are. –Sam On Wed, Apr 29, 2015 at 7:10 PM, Brian Gerstle wrote: > Great thinking, Jon! I'm sure that didn't even catch everything. I know > there are some comments like that in the iOS r

[WikimediaMobile] [Web] I ran this one Python script and look at all the Wikidata edits it made

2015-04-22 Thread Sam Smith
Hey folks, One of the tasks that the Readership* team committed to this sprint was running the WikiGrok bot [0] to aggregate and push all previously recorded claims to Wikidata [1]. We agreed that for this first run, the bot should use a conservative threshold to judge what qualifies as a pushable

Re: [WikimediaMobile] [Web] Existing MF data series in Graphite/on gdash

2015-04-15 Thread Sam Smith
uch the same as desktop despite being an environment which should >> explicitly do better? >> >> >> On Wed, Apr 15, 2015 at 7:02 AM, Sam Smith >> wrote: >> > Hey y'all, >> > >> > As part of Mobile Web Sprint 45: Snakes on a Plane, the Reade

[WikimediaMobile] [Web] Existing MF data series in Graphite/on gdash

2015-04-15 Thread Sam Smith
Hey y'all, As part of Mobile Web Sprint 45: Snakes on a Plane, the Readership team picked up a spike to investigate what data, if any, we were logging around site speed [0], given the existence of the mobile graphs over at WMF stats [1]. After a little poking around I found that all of the Naviga

[WikimediaMobile] [Web] MediaWiki: MobileFrontend dashboard

2015-04-14 Thread Sam Smith
Hey y'all, Anyone know what powers, or more correctly what *should* power, the MediaWiki: MobileFrontend dashboard [0]? I'm hoping that it's data from the NavigationTiming extension but I've been known to be wrong. –Sam [0] https://gdash.wikimedia.org/dashboards/mobext/ _

Re: [WikimediaMobile] Templates in core, let's use them

2015-04-06 Thread Sam Smith
Yes! On Mon, Apr 6, 2015 at 10:52 AM, Joaquin Oltra Hernandez < jhernan...@wikimedia.org> wrote: > Given templates are in core now, usable from both JS and PHP, do you guys > think we should halt HTML generation with PHP and make all future HTML > generation with templates, and slowly migrate exi

Re: [WikimediaMobile] DHH Testing Key Note at Railsconf 2014

2015-04-01 Thread Sam Smith
There's a great set of recorded hangouts between Kent Beck, Martin Fowler, and DHH titled "Is TDD dead?": http://martinfowler.com/articles/is-tdd-dead/ As with that talk, I'd highly encourage you to take the time to watch them. –Sam On Wed, Apr 1, 2015 at 6:07 PM, Corey Floyd wrote: > This is

Re: [WikimediaMobile] No one cares about browser tests [Re: [QA] MobileFrontend QA job]

2015-03-31 Thread Sam Smith
Dan, Jon, I got caught up in meetings yesterday – you'll see this email a lot during Q4 ;) – so I delayed sending this email, so forgive the repetitions of some of Dan's points/questions: Here are a few ways I can think of: > >- include feedback on browser tests – or lack thereof – during cod

Re: [WikimediaMobile] Fwd: Versioning MobileFrontend

2015-03-24 Thread Sam Smith
> > My biggest concern is blocking merges on badly formatted release notes. I > see this all the time with core and the merge conflicts associated due to > multiple people editing the text file. > Yeah. That sucks. How about we push a single change to VERSIONS.txtmediawikidown at the end of every

Re: [WikimediaMobile] Versioning MobileFrontend

2015-03-24 Thread Sam Smith
> > Seems sensible, but knowing history I don't think it will be updated > correctly. We're a different team now. Whaddya say we give it a try? > I think the updating of VERSION.txt really needs to be automated. Can we > have a script that can be run bumps the version number and generates thes

[WikimediaMobile] Jury duty

2015-03-23 Thread Sam Smith
Hey y'all, Just a reminder that I've been doing jury duty today and will be for up to two weeks – I found this out today – which is far from ideal. The court sits until 4:30 PM so there's time for me to do some code review in the evening, which'll be a welcome break from, well, everything else.

Re: [WikimediaMobile] [Web] WikiGrok code review session

2015-02-19 Thread Sam Smith
Grok version consolidation) > until we have a clean idea of how we're going to move forward with the UI. > > Kaldari > > On Thu, Feb 19, 2015 at 7:46 AM, Sam Smith wrote: > >> Hey, >> >> I've been working on removing WikiGrok version A from the code

[WikimediaMobile] [Web] WikiGrok code review session

2015-02-19 Thread Sam Smith
Hey, I've been working on removing WikiGrok version A from the codebase (per [0]). During a round of code review Baha mentioned that there are some changes that he'd like to make, which I definitely agree with. AFAICT there's one card that tracks cleaning up one part of WikiGrok [1]. How about we

Re: [WikimediaMobile] WikiGrok: yay, more redoing

2015-02-11 Thread Sam Smith
Hey folks, I'm disappointed – but not surprised, given what we've already experienced – to hear this. Given this new information and that we've got our story review/estimation meeting coming up I feel like I should ask the following questions: - As a team, how and do we evaluate whether our p

Re: [WikimediaMobile] Collections storage/api spike

2015-02-04 Thread Sam Smith
I've left some comments on PS8. The race condition is a result of the way the data is structured and stored: the entire collection and its metadata is stored in one wiki page as a JSON blob, which can't be updated without reading and writing the complete manifest. In the example you've provided,

Re: [WikimediaMobile] Face detection service?

2015-02-04 Thread Sam Smith
I hear the Foundation uses Node.js. Have some OpenCV Node.js bindings: https://github.com/peterbraden/node-opencv Like Brian, I agree with Corey's comments. First, create the API that allows us to ask the question that we want to ask, then, with the API in place, start with a simple solution and i

Re: [WikimediaMobile] Developer tools and workflows

2015-02-03 Thread Sam Smith
Nice job Joaquin! I've already started tweaking my workflow with all of the tips and tricks from last time. –Sam On Tue, Feb 3, 2015 at 11:32 AM, Joaquin Oltra Hernandez < jhernan...@wikimedia.org> wrote: > Hi! > > The mobile web team and contributors met while in San Francisco and had a > sess

Re: [WikimediaMobile] Increasing mobile beta audience

2015-01-27 Thread Sam Smith
> > Have we thought about automatically opting people into beta mode e.g. > a sample of our users in a certain geographic region / certain zero > enabled area/ all users in a certain bucket based on their user id ? I like this idea. In fact, I'm for it, provided that we make it clear to the user

Re: [WikimediaMobile] WikiGrok test in stable now live

2014-12-12 Thread Sam Smith
> > w00t! Congrats, all, and thanks for overcoming all the obstacles to get > this live :) +1 Any chance we could have a *brief* post-mortem to talk about the obstacles and how we might avoid 'em next time? –Sam On Fri, Dec 12, 2014 at 9:04 AM, Maryana Pinchuk wrote: > > w00t! Congrats, all,