Re: [PATCH 1/6] introspection: new 'Stats' property in the bearer object

2015-11-30 Thread Dan Williams
On Fri, 2015-11-27 at 14:51 +0100, Aleksander Morgado wrote: > The new property is a dictionary which may include different > parameters, > depending on what is actually supported by the underlying modem. For > now, > just bytes RX/TX. > > Note that this object will expose the stats *as reported b

Re: [PATCH 5/6] base-bearer: setup periodic stats loading

2015-11-30 Thread Dan Williams
On Fri, 2015-11-27 at 14:51 +0100, Aleksander Morgado wrote: > If the bearer implementation supports it, load stats periodically. By > default > every 30s for now. > --- > src/mm-base-bearer.c | 123 > +-- > src/mm-base-bearer.h | 16 +-- > 2 fi

Re: [PATCH 1/6] introspection: new 'Stats' property in the bearer object

2015-11-30 Thread Aleksander Morgado
On Mon, Nov 30, 2015 at 5:21 PM, Dan Williams wrote: > On Fri, 2015-11-27 at 14:51 +0100, Aleksander Morgado wrote: >> The new property is a dictionary which may include different >> parameters, >> depending on what is actually supported by the underlying modem. For >> now, >> just bytes RX/TX. >>

Re: [PATCH 5/6] base-bearer: setup periodic stats loading

2015-11-30 Thread Aleksander Morgado
On Mon, Nov 30, 2015 at 5:33 PM, Dan Williams wrote: >> +static gboolean >> +stats_update_cb (MMBaseBearer *self) >> +{ >> +/* If the implementation knows how to update stat values, run it >> */ >> +if (MM_BASE_BEARER_GET_CLASS (self)->reload_stats && >> +MM_BASE_BEARER_GET_CLASS (