Re: Fwd: Cinterion plugin patch

2016-11-24 Thread Reinhard Speyerer
On Thu, Nov 24, 2016 at 11:58:28AM +0100, Aleksander Morgado wrote: > [...] > BTW; I'm worried that we're binding the logic too much to a specific > device with 2 interfaces; I've seen some online AT command reference > that doesn't even talk about the third parameter to specify interface > index i

Re: Fwd: Cinterion plugin patch

2016-11-24 Thread Aleksander Morgado
On Thu, Nov 24, 2016 at 6:04 PM, matthew stanger wrote: > Uggg I am very sorry but that patch is not the right patch. It has none of > the fixes I worked on :(. Very sorry and terribly embarrassed. As soon as I > get back to my home computer I will mail out the correct one. I'd avoid > doing any w

Re: Fwd: Cinterion plugin patch

2016-11-24 Thread matthew stanger
Uggg I am very sorry but that patch is not the right patch. It has none of the fixes I worked on :(. Very sorry and terribly embarrassed. As soon as I get back to my home computer I will mail out the correct one. I'd avoid doing any work on this one for the next 24h. On Thu, Nov 24, 2016 at 8:54 A

Re: Fwd: Cinterion plugin patch

2016-11-24 Thread matthew stanger
Alexsander, I'm traveling right now will test as soon as I get back tomorrow. On Nov 24, 2016 2:58 AM, "Aleksander Morgado" wrote: > Hey Matthew, > > On Wed, Nov 23, 2016 at 10:28 PM, Aleksander Morgado > wrote: > > Great work! it looks really good now, although there are some small > > things

Re: Fwd: Cinterion plugin patch

2016-11-24 Thread Aleksander Morgado
Hey Matthew, On Wed, Nov 23, 2016 at 10:28 PM, Aleksander Morgado wrote: > Great work! it looks really good now, although there are some small > things that could still be fixed. Let me prepare a branch with your > patch and I'll include some additional patches for you to review. Please check th