Re: API Call proposal

2015-07-27 Thread Aleksander Morgado
On Mon, Jul 27, 2015 at 1:56 PM, Marco Bascetta wrote: > we test voice branch also with the Huawei ME-909s-120 modem with firmware > 23.613.61.00.00. > > This modem/firmware provides a new unsolicited command (^CSCHANNELINFO) > received twice between ATD and OK replies. > With this sequence MM par

Re: API Call proposal

2015-07-27 Thread Marco Bascetta
Hi, we test voice branch also with the Huawei ME-909s-120 modem with firmware 23.613.61.00.00. This modem/firmware provides a new unsolicited command (^CSCHANNELINFO) received twice between ATD and OK replies. With this sequence MM parser seems to miss the "OK" reply. In order to resolve thi

Re: API Call proposal

2015-05-11 Thread Riccardo Vangelisti
Il 11/05/2015 17:19, Aleksander Morgado ha scritto: We have tested new mm with these modems: * Simcom SIM7250E * Telit GT863-PY * Falcom Twist * Huawei MU709S-2 all modems works ! :) Quick question; how do all these modems implement the actual voice channel? Is it a physical audio chan

Re: API Call proposal

2015-05-11 Thread Aleksander Morgado
> > We have tested new mm with these modems: > * Simcom SIM7250E > * Telit GT863-PY > * Falcom Twist > * Huawei MU709S-2 > > all modems works ! :) > Quick question; how do all these modems implement the actual voice channel? Is it a physical audio channel? Is it an audio channel going through

Re: API Call proposal

2015-05-11 Thread Riccardo Vangelisti
We added on voicecall branch a working version of mm that implements all voice call functionalities. The voice capability is implemented on mm core but the only state permitted on an outgoing call is MM_CALL_STATE_ACTIVE because MM_CALL_STATE_DIALING and MM_CALL_STATE_RINGING_OUT states are no

Re: API Call proposal

2015-04-27 Thread Dan Williams
On Mon, 2015-04-27 at 16:07 +0200, Aleksander Morgado wrote: > On Mon, Apr 27, 2015 at 12:36 PM, Riccardo Vangelisti > wrote: > > Dear everyone, > > we've pushed on our branch ( > > https://bitbucket.org/riccardovangelisti/modemmanager/branch/voicecall ) > > these features: > > > > * Proposal of

Re: API Call proposal

2015-04-27 Thread Aleksander Morgado
On Mon, Apr 27, 2015 at 12:36 PM, Riccardo Vangelisti wrote: > Dear everyone, > we've pushed on our branch ( > https://bitbucket.org/riccardovangelisti/modemmanager/branch/voicecall ) > these features: > > * Proposal of call api in introspection (xml and enums) > * Added Modem.Voice and Call sup

Re: API Call proposal

2015-04-27 Thread Riccardo Vangelisti
Dear everyone, we've pushed on our branch ( https://bitbucket.org/riccardovangelisti/modemmanager/branch/voicecall ) these features: * Proposal of call api in introspection (xml and enums) * Added Modem.Voice and Call support in libmm-glib library * Added Modem.Voice and Call support in mmc

Re: API Call proposal

2015-04-23 Thread Dan Williams
On Wed, 2015-04-22 at 17:36 +0200, Riccardo Vangelisti wrote: > Hi all, > > I attach'd a new patch and schema with your latest suggestions. > > Note that Voice.StateChanged signal has "reason" argument but, by the > way, I had to create the MMCallStateChangedReason property in order to > permit

Re: API Call proposal

2015-04-22 Thread Riccardo Vangelisti
Hi all, I attach'd a new patch and schema with your latest suggestions. Note that Voice.StateChanged signal has "reason" argument but, by the way, I had to create the MMCallStateChangedReason property in order to permits user to retrieve that information also from the call object. This propert

Re: [SPAM] Re: API Call proposal

2015-04-22 Thread Aleksander Morgado
Hey Dan & Riccardo, Some comments from my side. > For states: > > + * MM_CALL_STATE_UNKNOWN: default state for a new outgoing call > > Should we have a MM_CALL_STATE_DIALING in between here for outgoing > calls? The call isn't really RINGING until the dialing request is > complete, and that can

Re: [SPAM] Re: API Call proposal

2015-04-22 Thread Aleksander Morgado
On Wed, Apr 22, 2015 at 10:27 AM, Riccardo Vangelisti wrote: > > (In the meanwhile, could you already create a git branch with access for me > and a colleague of mine that helps me in this project?) Can I suggest you clone the repo in e.g. github or bitbucket, and keep the working branch there? O

Re: [SPAM] Re: API Call proposal

2015-04-22 Thread Riccardo Vangelisti
Hi Dan, I agree in almost all of your opinion; see my comments inline. (In the meanwhile, could you already create a git branch with access for me and a colleague of mine that helps me in this project?) Riccardo Vangelisti - Sadel SpA Software Development Via Se

Re: API Call proposal

2015-04-21 Thread Dan Williams
On Tue, 2015-04-21 at 11:59 +0200, Aleksander Morgado wrote: > On Tue, Apr 21, 2015 at 11:42 AM, Riccardo Vangelisti > wrote: > > Fiuu... ;) > > > > I've attach'd the previuosly patch with CallLog renamed to Voice as you want > > :) > > > > I think this is already a good start for an API. > > Da

Re: API Call proposal

2015-04-21 Thread Aleksander Morgado
On Tue, Apr 21, 2015 at 11:42 AM, Riccardo Vangelisti wrote: > Fiuu... ;) > > I've attach'd the previuosly patch with CallLog renamed to Voice as you want > :) > I think this is already a good start for an API. Dan, what do you think? > Let me know what's the next step. Next steps would be:

Re: API Call proposal

2015-04-21 Thread Riccardo Vangelisti
Fiuu... ;) I've attach'd the previuosly patch with CallLog renamed to Voice as you want :) Let me know what's the next step. Thanks, Riccardo Vangelisti - Sadel SpA Software Development Via Serenari 1, Castel Maggiore (BO) Il 21/04/2015 11:15, Aleksander Morgado ha scritto: On Tue, Apr 21,

Re: API Call proposal

2015-04-21 Thread Aleksander Morgado
On Tue, Apr 21, 2015 at 10:30 AM, Riccardo Vangelisti wrote: > In spite of the last proposal was very similar, for my opinion, to > Messaging/SMS style, I've attach'd > a new patch with your last suggestions. And you're right; your previous proposal was actually more inline to what I originally a

Re: API Call proposal

2015-04-21 Thread Riccardo Vangelisti
In spite of the last proposal was very similar, for my opinion, to Messaging/SMS style, I've attach'd a new patch with your last suggestions. If you think I don't understand what you said yet, send me your modified patch. Thanks, Riccardo Vangelisti - S

Re: API Call proposal

2015-04-20 Thread Dan Williams
On Mon, 2015-04-20 at 19:03 +0200, Aleksander Morgado wrote: > On Mon, Apr 20, 2015 at 6:47 PM, Riccardo Vangelisti < > riccardo.vangeli...@sadel.it> wrote: > > > Thanks for you support. > > > > I agree with your opinion and I changed my proposal with your advices. > > I follow the SMS and Messagi

Re: API Call proposal

2015-04-20 Thread Aleksander Morgado
On Mon, Apr 20, 2015 at 6:47 PM, Riccardo Vangelisti < riccardo.vangeli...@sadel.it> wrote: > Thanks for you support. > > I agree with your opinion and I changed my proposal with your advices. > I follow the SMS and Messaging implementation and I create two new > interfaces named CallLog and Call.

Re: API Call proposal

2015-04-20 Thread Riccardo Vangelisti
Thanks for you support. I agree with your opinion and I changed my proposal with your advices. I follow the SMS and Messaging implementation and I create two new interfaces named CallLog and Call. CallLog contains all Call objects created. All Call state are described in a schema that I've att

Re: API Call proposal

2015-04-20 Thread Aleksander Morgado
Hey Riccardo, > in refer to opened bug https://bugs.freedesktop.org/show_bug.cgi?id=84981 > I propose the attached patch, to implement voice or data call in MM core. > > Please let me know what you think. > Thanks for moving this forward :) From my POV, this API should be managed very similar

API Call proposal

2015-04-20 Thread Riccardo Vangelisti
Hi, in refer to opened bug https://bugs.freedesktop.org/show_bug.cgi?id=84981 I propose the attached patch, to implement voice or data call in MM core. Please let me know what you think. Regards, -- Riccardo Vangelisti - Sadel SpA Software Development Via Serenari 1, Castel Maggiore (BO) >Fro