Re: Fwd: Cinterion plugin patch

2016-11-30 Thread Reinhard Speyerer
On Wed, Nov 30, 2016 at 10:16:42AM +0100, Aleksander Morgado wrote: > On Mon, Nov 28, 2016 at 10:41 PM, Reinhard Speyerer wrote: > > using CID 1 when this CID could be used for RAT LTE when used with > > AT!SCACT or AT^SWWAN may generally be problematic for the following > > reason: when the mobil

Re: Fwd: Cinterion plugin patch

2016-11-30 Thread Aleksander Morgado
On Mon, Nov 28, 2016 at 10:41 PM, Reinhard Speyerer wrote: > using CID 1 when this CID could be used for RAT LTE when used with > AT!SCACT or AT^SWWAN may generally be problematic for the following > reason: when the mobile is registering to LTE CID 1 is used by most > mobiles to handle the defaul

Re: Fwd: Cinterion plugin patch

2016-11-28 Thread matthew stanger
Hi Reinhard > Can we please get back QMI as an alternative to AT^SWWAN & CDC ECM for the > next PLS8 firmware update FYI we told Gelmalto that, for us, moving away from QMI seemed like a step in the wrong direction. It seems like they want to support building modules with chipsets from other ve

Re: Fwd: Cinterion plugin patch

2016-11-28 Thread Reinhard Speyerer
On Mon, Nov 28, 2016 at 08:23:23PM +0100, Aleksander Morgado wrote: > On Mon, Nov 28, 2016 at 7:03 PM, matthew stanger wrote: > >> Ah, yeah. If the plugin does its own logic to select which CID to use, > >> it should not rely on the parent's connection status check. In our > >> case, though, I thi

Re: Fwd: Cinterion plugin patch

2016-11-28 Thread Aleksander Morgado
On Mon, Nov 28, 2016 at 7:03 PM, matthew stanger wrote: >> Ah, yeah. If the plugin does its own logic to select which CID to use, >> it should not rely on the parent's connection status check. In our >> case, though, I think we should default back to letting the generic >> logic decide the CID to

Re: Fwd: Cinterion plugin patch

2016-11-28 Thread matthew stanger
> > Ah, yeah. If the plugin does its own logic to select which CID to use, > it should not rely on the parent's connection status check. In our > case, though, I think we should default back to letting the generic > logic decide the CID to use (i.e. don't fix to use the CIDs 1 and 3). > If we do so

Re: Fwd: Cinterion plugin patch

2016-11-28 Thread Aleksander Morgado
On Sun, Nov 27, 2016 at 4:27 AM, matthew stanger wrote: > Sorry I sent that last email a little prematurely, was still targeting my > email client and ctrl-entered for another window. You can disregard that > second comment, I see what you did for IP config. Last little things: > >> /* Get a t

Re: Fwd: Cinterion plugin patch

2016-11-28 Thread Aleksander Morgado
On Sun, Nov 27, 2016 at 3:47 AM, matthew stanger wrote: > attempt to be as detailed as you >> >> >> * The PDP context mapping is as suggested by Cinterion, although it looks >> like >> * this isn't strictly enforced by the modem; i.e. SWWAN could work fine >> with >> * any PDP context vs SWWAN

Re: Fwd: Cinterion plugin patch

2016-11-27 Thread Reinhard Speyerer
On Sat, Nov 26, 2016 at 12:46:21AM +, Andrew Bird wrote: > On Fri, 25 Nov 2016 21:16:55 +0100 > Reinhard Speyerer wrote: > > > On Fri, Nov 25, 2016 at 10:13:08AM +0100, Aleksander Morgado wrote: > > > Hey Reinhard & Matthew, > > > > > > On Thu, Nov 24, 2016 at 10:34 PM, Reinhard Speyerer >

Re: Fwd: Cinterion plugin patch

2016-11-26 Thread matthew stanger
Sorry I sent that last email a little prematurely, was still targeting my email client and ctrl-entered for another window. You can disregard that second comment, I see what you did for IP config. Last little things: /* Get a tet port to setup the connection on */ > > > net* There is also som

Re: Fwd: Cinterion plugin patch

2016-11-26 Thread matthew stanger
Code looks awesome (*¬*), so much to learn for me. A few comments which are all trivial and really don't need to be included but in attempt to be as detailed as you > > > * The PDP context mapping is as suggested by Cinterion, although it looks > like > * this isn't strictly enforced by the modem

Re: Fwd: Cinterion plugin patch

2016-11-25 Thread Andrew Bird
On Fri, 25 Nov 2016 21:16:55 +0100 Reinhard Speyerer wrote: > On Fri, Nov 25, 2016 at 10:13:08AM +0100, Aleksander Morgado wrote: > > Hey Reinhard & Matthew, > > > > On Thu, Nov 24, 2016 at 10:34 PM, Reinhard Speyerer wrote: > > [...] > > > PLS8-E REVISION 02.011: > > > +CUSD: 1,"Hauptmen~:\0A1

Re: Fwd: Cinterion plugin patch

2016-11-25 Thread Andrew Bird
On Fri, 25 Nov 2016 21:27:57 +0100 Reinhard Speyerer wrote: > On Fri, Nov 25, 2016 at 09:55:41AM +, Andrew Bird wrote: > > On Fri, 25 Nov 2016 10:13:08 +0100 > > Aleksander Morgado wrote: > > > > > Hey Reinhard & Matthew, > > > > > > > > > > One further difference I noticed is that USSD

Re: Fwd: Cinterion plugin patch

2016-11-25 Thread Reinhard Speyerer
On Fri, Nov 25, 2016 at 09:55:41AM +, Andrew Bird wrote: > On Fri, 25 Nov 2016 10:13:08 +0100 > Aleksander Morgado wrote: > > > Hey Reinhard & Matthew, > > > > > > One further difference I noticed is that USSD responses for AT+CSCS="GSM" > > > contain a non-standard \xx escaping for non-pr

Re: Fwd: Cinterion plugin patch

2016-11-25 Thread Reinhard Speyerer
On Fri, Nov 25, 2016 at 10:13:08AM +0100, Aleksander Morgado wrote: > Hey Reinhard & Matthew, > > On Thu, Nov 24, 2016 at 10:34 PM, Reinhard Speyerer wrote: > [...] > > PLS8-E REVISION 02.011: > > +CUSD: 1,"Hauptmen~:\0A1 Guthabenkonto\0A2 Guthaben Verf~gbarkeit\0A3 > > Gutschein einl|sen\0A4 Pa

Re: Fwd: Cinterion plugin patch

2016-11-25 Thread matthew stanger
> > Ah, understood. I probably have at home the 01.x version which is the > one I tested QMI with. Are there steps somewhere on how to upgrade a > PLS8 to a newer firmware? Yes the 1.x vs. 2.x & 3.x are very different and further it seems Cinterion is going to drop QMI from all their new modems a

Re: Fwd: Cinterion plugin patch

2016-11-25 Thread Andrew Bird
On Fri, 25 Nov 2016 10:13:08 +0100 Aleksander Morgado wrote: > Hey Reinhard & Matthew, > > One further difference I noticed is that USSD responses for AT+CSCS="GSM" > > contain a non-standard \xx escaping for non-printable characters (unless > > I missed some recent TS 27.007 changes). > > > >

Re: Fwd: Cinterion plugin patch

2016-11-25 Thread Aleksander Morgado
Hey Reinhard & Matthew, On Thu, Nov 24, 2016 at 10:34 PM, Reinhard Speyerer wrote: > this documentation seems to refer to PLS8-E with firmware 01.x and > USB ID 1e2d:0060 where the serial ports were handled by the option > driver and which had one QMI-based network interface. With PLS8-E > firmwa

Re: Fwd: Cinterion plugin patch

2016-11-24 Thread Reinhard Speyerer
On Thu, Nov 24, 2016 at 11:58:28AM +0100, Aleksander Morgado wrote: > [...] > BTW; I'm worried that we're binding the logic too much to a specific > device with 2 interfaces; I've seen some online AT command reference > that doesn't even talk about the third parameter to specify interface > index i

Re: Fwd: Cinterion plugin patch

2016-11-24 Thread Aleksander Morgado
On Thu, Nov 24, 2016 at 6:04 PM, matthew stanger wrote: > Uggg I am very sorry but that patch is not the right patch. It has none of > the fixes I worked on :(. Very sorry and terribly embarrassed. As soon as I > get back to my home computer I will mail out the correct one. I'd avoid > doing any w

Re: Fwd: Cinterion plugin patch

2016-11-24 Thread matthew stanger
Uggg I am very sorry but that patch is not the right patch. It has none of the fixes I worked on :(. Very sorry and terribly embarrassed. As soon as I get back to my home computer I will mail out the correct one. I'd avoid doing any work on this one for the next 24h. On Thu, Nov 24, 2016 at 8:54 A

Re: Fwd: Cinterion plugin patch

2016-11-24 Thread matthew stanger
Alexsander, I'm traveling right now will test as soon as I get back tomorrow. On Nov 24, 2016 2:58 AM, "Aleksander Morgado" wrote: > Hey Matthew, > > On Wed, Nov 23, 2016 at 10:28 PM, Aleksander Morgado > wrote: > > Great work! it looks really good now, although there are some small > > things

Re: Fwd: Cinterion plugin patch

2016-11-24 Thread Aleksander Morgado
Hey Matthew, On Wed, Nov 23, 2016 at 10:28 PM, Aleksander Morgado wrote: > Great work! it looks really good now, although there are some small > things that could still be fixed. Let me prepare a branch with your > patch and I'll include some additional patches for you to review. Please check th

Re: Fwd: Cinterion plugin patch

2016-11-23 Thread Aleksander Morgado
On Sun, Nov 20, 2016 at 7:26 PM, matthew stanger wrote: > Ok, so clearly I'm not as fast as I wish, but another patch never the less. > This should be pretty close but I'll keep at it if there are any changes > still needed so let me know :). Here are the changes since the first patch > of this ch

Re: Fwd: Cinterion plugin patch

2016-11-20 Thread matthew stanger
Ok, so clearly I'm not as fast as I wish, but another patch never the less. This should be pretty close but I'll keep at it if there are any changes still needed so let me know :). Here are the changes since the first patch of this chain: Converted Enum types from all caps to camel case. Changed p

Re: Fwd: Cinterion plugin patch

2016-10-26 Thread Aleksander Morgado
Hey! This looks much much better :) See comments next, in no particular order. On Mon, Oct 24, 2016 at 7:13 AM, matthew stanger wrote: > Here is finally the update... to the above code reviewed patch. A big thank > you Dan and Aleksander for the detail in the review it was really a great > learn

Re: Cinterion plugin patch

2016-08-29 Thread matthew stanger
Thanks Dan for the very helpful feedback. I will get update the patch with the changes. It may take me some time to squeeze it in as our dev sprints allow but I'll get it back up here. On Mon, Aug 29, 2016 at 1:19 PM, Dan Williams wrote: > On Mon, 2016-08-29 at 09:44 -0600, matthew stanger wrote

Re: Cinterion plugin patch

2016-08-29 Thread Dan Williams
On Mon, 2016-08-29 at 09:44 -0600, matthew stanger wrote: > Attached is the patch, gmail is the culprit. Thanks! A couple general comments. If it's possible, could the GPS stuff be split out into a separate patch?  Makes for easier review of both that and the SWWAN stuff. For feature detection,