[mp2] Apache2::SizeLimit should be using $s->rss, not $s->size for Linux::Smaps

2010-02-02 Thread Max Kanat-Alexander
All of my processes kept exiting with a report that they had a 300M unshared size, which was clearly untrue, even from looking at top. After some investigation, I discovered that Apache2::SizeLimit was calling $s->size on the Linux::Smaps object, when instead it should be returning $s->rss

Re: [mp2] Apache2::SizeLimit should be using $s->rss, not $s->size for Linux::Smaps

2010-02-02 Thread Fred Moyer
Can you submit these patches inline? http://perl.apache.org/docs/2.0/devel/help/help.html#Submitting_Patches When they are attachments like this, people tend to not read them. Whereas when they are inline, people tend to be able to read them and comment very easily. On Tue, Feb 2, 2010 at 1:58 P

Re: [mp2] Apache2::SizeLimit should be using $s->rss, not $s->size for Linux::Smaps

2010-02-03 Thread Torsten Förtsch
On Tuesday 02 February 2010 22:58:13 Max Kanat-Alexander wrote: > All of my processes kept exiting with a report that they had a 300M > unshared size, which was clearly untrue, even from looking at top. After > some investigation, I discovered that Apache2::SizeLimit was calling > $s->size on the L

Re: [mp2] Apache2::SizeLimit should be using $s->rss, not $s->size for Linux::Smaps

2010-02-03 Thread Max Kanat-Alexander
On 02/03/2010 04:57 AM, Torsten Förtsch wrote: > Well, I tend to disagree. (Fred, Adam please read on.) Okay. Have you looked at the actual output of test.cgi? Here's an example of these values just on my local machine, for my bash interpreter: [mka...@es-compy ~]$ cat /proc/self

Re: [mp2] Apache2::SizeLimit should be using $s->rss, not $s->size for Linux::Smaps

2011-02-09 Thread Max Kanat-Alexander
So, I just recently installed the very latest release of SizeLimit, and this is still a problem. SizeLimit **definitely** returns the wrong unshared size for processes on any modern Linux system. -Max On 02/03/2010 12:05 PM, Max Kanat-Alexander wrote: > On 02/03/2010 04:57 AM, Tor

Re: [mp2] Apache2::SizeLimit should be using $s->rss, not $s->size for Linux::Smaps

2011-02-09 Thread Max Kanat-Alexander
On 02/02/2010 02:19 PM, Fred Moyer wrote: > Can you submit these patches inline? Here is the patch inline: Index: lib/Apache/SizeLimit/Core.pm === --- lib/Apache/SizeLimit/Core.pm(revision 905815) +++ lib/Apache/SizeL

Re: [mp2] Apache2::SizeLimit should be using $s->rss, not $s->size for Linux::Smaps

2011-02-09 Thread Fred Moyer
On Wed, Feb 9, 2011 at 5:24 PM, Max Kanat-Alexander wrote: > On 02/02/2010 02:19 PM, Fred Moyer wrote: >> Can you submit these patches inline? > >        Here is the patch inline: Thanks - expect 0.96 in the next day. > > Index: lib/Apache/SizeLimit/Core.pm >