Re: version.pm development model strikes back

2007-07-16 Thread Michael G Schwern
I just realized that most of the code in Module/Build/Version.pm is in package version, not Module::Build::Version. I thought an MBV object delegated to a version object and was doing verification checks on it. My mistake. That eliminates most of my practical objections having to do with _verify

Re: version.pm development model strikes back

2007-07-16 Thread John Peacock
Michael G Schwern wrote: > Just because there is a new version on CPAN doesn't mean everyone updates in > lock step or should not have to *especially* for a toolchain module which > should strive to avoid interdependencies. It should be possible to update MB > without updating version.pm and vice

Re: version.pm development model strikes back

2007-07-16 Thread Andreas J. Koenig
> On Mon, 16 Jul 2007 11:23:36 -0700, Eric Wilhelm <[EMAIL PROTECTED]> said: > # from John Peacock > # on Monday 16 July 2007 03:18 am: >> think I can justify adding such a special case to the version.pm code >> more than adding it to a consumer of that code (e.g. M::B itself). > I'm

Re: version.pm development model strikes back

2007-07-16 Thread Michael G Schwern
John Peacock wrote: > Michael G Schwern wrote: >> Its a verbatim copy of version.pm *now*, but things change and fall >> out of >> sync. What happens when version.pm 0.8 changes its guts and >> Module::Build::Version 0.7203 tries to load and "verify" it? Kersplooy! > > A) the code in M::B is alw

Re: version.pm development model strikes back

2007-07-16 Thread Eric Wilhelm
# from John Peacock # on Monday 16 July 2007 03:18 am: >think I can justify adding such a special case to the version.pm code > more than adding it to a consumer of that code (e.g. M::B itself). I'm not sure that's justified either. Andreas? What does it need to do? --Eric -- "You can't win.

Re: version.pm development model strikes back

2007-07-16 Thread John Peacock
Michael G Schwern wrote: Its a verbatim copy of version.pm *now*, but things change and fall out of sync. What happens when version.pm 0.8 changes its guts and Module::Build::Version 0.7203 tries to load and "verify" it? Kersplooy! A) the code in M::B is always going to be the same as the rel

Re: version.pm development model strikes back

2007-07-16 Thread Michael G Schwern
John Peacock wrote: > Michael G Schwern wrote: >> Also, what's _verify() doing sniffing around in the guts of version.pm >> objects >> anyway? > > The code in Module::Build::Version is a verbatim copy of the version.pm pure > Perl code, so it is acceptable to peer through the veil here. Its a ve

Re: version.pm development model strikes back

2007-07-16 Thread John Peacock
Michael G Schwern wrote: > Also, what's _verify() doing sniffing around in the guts of version.pm objects > anyway? The code in Module::Build::Version is a verbatim copy of the version.pm pure Perl code, so it is acceptable to peer through the veil here. > While I'm looking at it, META.yml recomm

Re: version.pm development model strikes back

2007-07-16 Thread John Peacock
Eric Wilhelm wrote: > Possibly I don't understand the issue well enough, but ... > > It sounds like we're fixing a bug which only exists in a specific set of > bleadperl revisions which are only of interest for internal > development. That is, it will never appear in the wild? > > If so, is th

Re: version.pm development model strikes back

2007-07-16 Thread Eric Wilhelm
# from Andreas J. Koenig # on Sunday 15 July 2007 07:50 am: >I hope this can go into Module::Build. Possibly I don't understand the issue well enough, but ... It sounds like we're fixing a bug which only exists in a specific set of bleadperl revisions which are only of interest for internal de

Re: irc.perl.org/#toolchain

2007-07-16 Thread Michael G Schwern
Eric Wilhelm wrote: > [1] given that we form a majority of those present in our two-person > discussion :-D Unanimous, even!