Re: MANIFEST.SKIP deleted on distclean?

2010-04-16 Thread David Golden
On Fri, Apr 16, 2010 at 10:11 PM, Eric Wilhelm wrote: > Dancing around some old clunky code that just looks like a pile of > monkey patches swinging from a tree of assumptions is a lot more > maintainable than a pile of monkey patches to make it take input via > variables instead of the filesystem

Re: MANIFEST.SKIP deleted on distclean?

2010-04-16 Thread Eric Wilhelm
# from David Golden # on Friday 16 April 2010 10:54: >On Fri, Apr 16, 2010 at 1:47 PM, Eric Wilhelm wrote: >> Or, dirty hacks: >> >>  my $orig = \&ExtUtils::Manifest::maniskip; >>  local *ExtUtils::Manifest::maniskip = sub { > >-1 Dirty hacks lead to maintenance headaches later. > # But befor

Re: Repository commit notifications?

2010-04-16 Thread David Golden
On Fri, Apr 16, 2010 at 6:01 PM, Curtis Jewell wrote: > I'd like to see, at a minimum, a Twitter feed and some sort of IRC > notification. After that, hmmm... What IRC channel? #toolchain? Something more specific to Module::Build? -- David

Re: MANIFEST.SKIP deleted on distclean?

2010-04-16 Thread David Golden
Pushed to the repo the following changes: * When generating MANIFEST.SKIP for distcheck, it will be removed immediately when the action is completed. (This means that subsequently added MANIFEST.SKIP will not be deleted during "clean".) * Added "Build manifest_skip" to generate one permanently i

Repository commit notifications?

2010-04-16 Thread David Golden
Now that Module-Build has migrated to git and is hosted on github, there are several options for post-commit hooks to post commits to various channels. Here's a list of what's available: * Post-Receive URLs (0) * Basecamp * CIA * Campfire * Email * FogBugz * Freckle

Re: MANIFEST.SKIP deleted on distclean?

2010-04-16 Thread David Golden
I'm looking to see if we can make the generated one temporary easily. David On Fri, Apr 16, 2010 at 10:53 AM, Curtis Jewell wrote: >> And if people really need a skeleton MANIFEST.SKIP, we can add "Build >> manifest_skip" to generate a default one (that then persists) >> >> -- David > > Easy eno

Re: MANIFEST.SKIP deleted on distclean?

2010-04-16 Thread Curtis Jewell
> And if people really need a skeleton MANIFEST.SKIP, we can add "Build > manifest_skip" to generate a default one (that then persists) > > -- David Easy enough. Practically a one-liner. sub ACTION_manifest_skip { if (not -e 'MANIFEST.SKIP') { # I'm assuming we're already in the rig

Re: MANIFEST.SKIP deleted on distclean?

2010-04-16 Thread Steffen Schwigon
David Golden writes: > On Thu, Apr 15, 2010 at 4:57 AM, Steffen Schwigon > wrote: >> Hi! >> >> I did not expect that my MANIFEST.SKIP file (either self-written or >> auto-generated) gets deleted during ./Build distclean. >> >> What is the rationale behind that? >> I couldn't read that out of the

Re: MANIFEST.SKIP deleted on distclean?

2010-04-16 Thread David Golden
On Fri, Apr 16, 2010 at 1:47 PM, Eric Wilhelm wrote: > Or, dirty hacks: > >  my $orig = \&ExtUtils::Manifest::maniskip; >  local *ExtUtils::Manifest::maniskip = sub { -1 Dirty hacks lead to maintenance headaches later. I'd rather not clean up the MANIFEST.SKIP before monkeypatching things. Dav

Re: MANIFEST.SKIP deleted on distclean?

2010-04-16 Thread Eric Wilhelm
# from David Golden # on Friday 16 April 2010 07:00: >I'm wondering if the "answer" is to generate MANIFEST.SKIP for the >duration of distcheck and related activities *only* and not let it >hang around all the way to be cleaned later.  That would avoid all the >confusion, I think. Or replace ExtU

Re: MANIFEST.SKIP deleted on distclean?

2010-04-16 Thread David Golden
On Fri, Apr 16, 2010 at 9:54 AM, Zefram wrote: > That would piss me off.  I don't use MANIFEST.SKIP files: I maintain > the MANIFEST manually.  If M:B really needs a MANIFEST.SKIP to exist, > for its internal use, then that is a temporary build file and must be > cleaned up no later than "./Build

Re: MANIFEST.SKIP deleted on distclean?

2010-04-16 Thread Zefram
Michael G Schwern wrote: >The third order solution is for MB to recognize that the MANIFEST.SKIP >has been altered and leave it alone. Sounds good to me. >Alternatively, just don't delete it. That would piss me off. I don't use MANIFEST.SKIP files: I maintain the MANIFEST manually. If M:B rea

Re: MANIFEST.SKIP deleted on distclean?

2010-04-16 Thread Michael G Schwern
David Golden wrote: The only reason MANIFEST.SKIP should be deleted is if Module::Build created it because you didn't have one. In that case, it would actually get removed with "Build clean" (which distclean calls). There is a subtle wrinkle that the cleanup list that "Build clean" uses is pers