Re: [Mono-dev] Bug in System.Web.UI.WebControls.BoundColumn

2006-02-17 Thread Chris Toshok
yeah, I figured it was more efficient (for ms at least - do we inline the getter?).. my argument was more a consistency thing - there are other != "" usages in that file. Change them all or change none, basically :) actually running FxCop or something over the current System.Web might not be a b

Re: [Mono-dev] Bug in System.Web.UI.WebControls.BoundColumn

2006-02-17 Thread Jonathan Pryor
On Thu, 2006-02-16 at 20:51 -0500, Chris Toshok wrote: > This patch looks okay, except for the switch from 'df != ""' to > 'df.Length != 0'. I'd prefer the former (and in general I'd rather > adapt whatever my thoughts are on the matter to what the original author > wrote.) `df != ""' may make mo

Re: [Mono-dev] Bug in System.Web.UI.WebControls.BoundColumn

2006-02-16 Thread Chris Toshok
This patch looks okay, except for the switch from 'df != ""' to 'df.Length != 0'. I'd prefer the former (and in general I'd rather adapt whatever my thoughts are on the matter to what the original author wrote.) Chris On Thu, 2006-02-16 at 05:46 -0800, Vladimir Krasnov wrote: > Hi All, > > I've

[Mono-dev] Bug in System.Web.UI.WebControls.BoundColumn

2006-02-16 Thread Vladimir Krasnov
Hi All, I've found a bug in InitializeCell function of BoundColumn. The problem is that if DataField is null or empty string, the cell should not be bound. Test case url: /System_Web_UI_WebControls/BoundColumn/BoundColumn_DataField.aspx Please approve attached patch. If no one objects, I will co