Re: [Mono-dev] Question about Mono.Security.X509

2008-06-26 Thread Sebastien Pouliot
Hello David, On Mon, 2008-06-16 at 12:56 -0400, David Wolinsky wrote: > Many apologies for the mistakes! I appreciate the thoroughness and > have > hopefully not looked over any issues in this patch. Everything was committed (r106667-9) except for this... > mono-1.9.1/mcs/class/Mono.Security/M

Re: [Mono-dev] Question about Mono.Security.X509

2008-06-16 Thread David Wolinsky
Many apologies for the mistakes! I appreciate the thoroughness and have hopefully not looked over any issues in this patch. Regards, David Sebastien Pouliot wrote: Hello David, General note: Please review the Mono coding guidelines. http://www.mono-project.com/Coding_Guidelines E.g. use tab

Re: [Mono-dev] Question about Mono.Security.X509

2008-06-16 Thread Sebastien Pouliot
Hello David, General note: Please review the Mono coding guidelines. http://www.mono-project.com/Coding_Guidelines E.g. use tabs not spaces, add a space before '(' > diff -urpN > mono-1.9.1-old/mcs/class/Mono.Security/Mono.Security_test.dll.sources > mono-1.9.1/mcs/class/Mono.Security/Mono.Sec

Re: [Mono-dev] Question about Mono.Security.X509

2008-06-13 Thread Sebastien Pouliot
Hello David, On Fri, 2008-06-13 at 02:08 -0400, David Isaac Wolinsky wrote: > Attached is a patch to allow creation of the SubjectAltName Extension > using X509CertificateBuilder. There are some unit tests and I confirmed > using openssl, System.Security.Cryptography.X509Certificates, and > Mo

Re: [Mono-dev] Question about Mono.Security.X509

2008-06-12 Thread David Isaac Wolinsky
Attached is a patch to allow creation of the SubjectAltName Extension using X509CertificateBuilder. There are some unit tests and I confirmed using openssl, System.Security.Cryptography.X509Certificates, and Mono.Security.X509 to read the certificates. I also went ahead and fixed the IP Addre

Re: [Mono-dev] Question about Mono.Security.X509

2008-06-12 Thread Sebastien Pouliot
Hello David, On Thu, 2008-06-12 at 14:26 -0400, David Wolinsky wrote: > Is anyone working on X509CertificateBuilder. AFAIK no one. The actual class does everything that mono itself requires (mostly implementing the makecert tool). > I am putting together a > little work to add a single URI to

[Mono-dev] Question about Mono.Security.X509

2008-06-12 Thread David Wolinsky
Is anyone working on X509CertificateBuilder. I am putting together a little work to add a single URI to SubjectAltName and add the extension to the CertificateBuilder. It appears to work in both .Net and Mono. They were able to properly read the certificate and Identify the SubjectAltName.