Re: A branch to review: topic/strict-constructor

2010-02-28 Thread Goro Fuji
http://github.com/gfx/moose/commits/topic/strict-constructor2 I have implemented use Moose -strict command. How about it? -- Goro Fuji (藤 吾郎)

Re: A branch to review: topic/strict-constructor

2010-02-28 Thread Dave Rolsky
On Sun, 28 Feb 2010, Goro Fuji wrote: http://github.com/gfx/moose/commits/topic/strict-constructor2 I have implemented use Moose -strict command. How about it? I really wish you'd use the Moose repo like everyone else. It makes it a lot easier for me to review your code that way, and

Re: A branch to review: topic/strict-constructor

2010-02-28 Thread Ævar Arnfjörð Bjarmason
On Sun, Feb 28, 2010 at 15:21, Dave Rolsky auta...@urth.org wrote: On Sun, 28 Feb 2010, Goro Fuji wrote: http://github.com/gfx/moose/commits/topic/strict-constructor2 I have implemented use Moose -strict command.  How about it? I really wish you'd use the Moose repo like everyone else. It

RE: A branch to review: topic/strict-constructor

2010-02-28 Thread Alexander
Hello, Use Moose -strict looks very unusual. Why not something more usual for Perl like use Moose::Strict? -Original Message- From: Goro Fuji [mailto:g.psy...@gmail.com] Sent: Sunday, February 28, 2010 10:47 AM To: Dave Rolsky; Moose ML Subject: Re: A branch to review:

Re: A branch to review: topic/strict-constructor

2010-02-28 Thread Goro Fuji
Dave: I really wish you'd use the Moose repo like everyone else. It makes it a lot easier for me to review your code that way, and probably for others who aren't too git-savvy. Oh, sorry. I forked it from force of habit. Well, let's get back to the subject. Although I implemented the

Re: A branch to review: topic/strict-constructor

2010-02-28 Thread Hans Dieter Pearcey
Excerpts from Goro Fuji's message of Sun Feb 28 21:09:29 -0500 2010: Dave said that constructor strictness should not be tied to immutability, but I don't think so. This is because existing options to make_immutable, namely constructor_name and inline_construcotr, etc., are irrelevant to

Re: A branch to review: topic/strict-constructor

2010-02-28 Thread Ævar Arnfjörð Bjarmason
On Mon, Mar 1, 2010 at 02:35, Hans Dieter Pearcey h...@pobox.com wrote: I have to side with Dave on this one. Yeah on one hand the -import() namespace is being polluted and on the other hand meta-make_immutable() is being used to do something not relating to immutability. If it's going to be