Re: [mb-style] Pre-RFC: Make instruments entities

2014-01-05 Thread Nicolás Tamargo de Eguren
On 5 Jan 2014 14:56, "Maurits" wrote: > > Oh ok. I got the impression from the original Jira ticket that this > should be discussed somewhere, and I thought that would be here. Should > I take this somewhere else or just add my thought s to the Jira ticket > and forget about it for now? Discussio

Re: [mb-style] Pre-RFC: Make instruments entities

2014-01-05 Thread Maurits
Oh ok. I got the impression from the original Jira ticket that this should be discussed somewhere, and I thought that would be here. Should I take this somewhere else or just add my thought s to the Jira ticket and forget about it for now? ___ MusicBr

Re: [mb-style] Pre-RFC: Make instruments entities

2014-01-05 Thread Nicolás Tamargo de Eguren
Given this isn't a style issue, but a code-dependant schema change, I'm not sure what the point of an RFC would be :) How to eventually use them maybe, but that sounds like something to decide once we know how they'll be implemented... ___ MusicBrainz-sty

Re: [mb-style] Pre-RFC: Make instruments entities

2014-01-05 Thread Maurits
Looking through the comments so far I think most people would like to see instruments implemented as entities, though with some conditions. Mikhel want to be able to seed the aliases from the .pot files used for translations on Transifex. I think I agree on that one, since making an add alias ed

Re: [mb-style] Pre-RFC: Make instruments entities

2014-01-05 Thread Maurits
They could be, though I think most people adding a Stratocaster would know it's a model of electric guitar. They could also be implemented as sub-types of instruments, but that would mean a gazillion of new instruments and I'm not sure if that's worth it. Rachel Dwight schreef op 2-1-2014 21:51

Re: [mb-style] Pre-RFC: Make instruments entities

2014-01-02 Thread Rachel Dwight
Would specific instrument makes and models have to be implemented as aliases? Sent from my iPhone > On Jan 2, 2014, at 1:03 PM, "Frederik \"Freso\" S. Olesen" > wrote: > > Den 02-01-2014 15:02, Frederic Da Vitoria skrev: >> I don't know where what is the current situation about languages in th

Re: [mb-style] Pre-RFC: Make instruments entities

2014-01-02 Thread Frederik "Freso" S. Olesen
Den 02-01-2014 15:02, Frederic Da Vitoria skrev: > I don't know where what is the current situation about languages in the > DB. If it is far from handling languages correctly, and if instrument > entities are implemented before languages, we could temporarily restrict > the instrument language to

Re: [mb-style] Pre-RFC: Make instruments entities

2014-01-02 Thread Frederik "Freso" S. Olesen
Den 02-01-2014 13:44, Ben Ockmore skrev: > For instruments, the user would enter an instrument name into a free > text field, and this would be searched for among existing instrument > entities. If it's not found, then the user can proceed to use their entry. > > If other users enter the same name

Re: [mb-style] Pre-RFC: Make instruments entities

2014-01-02 Thread Frederic Da Vitoria
2014/1/2 Ben Ockmore > I think it would be helpful if we allow Instruments to have images, and > use these in search results to show graphically what each of the > suggestions looks like. > > All of your ideas for language selection/detection are good. Perhaps we > could also use the site languag

Re: [mb-style] Pre-RFC: Make instruments entities

2014-01-02 Thread Ben Ockmore
I think it would be helpful if we allow Instruments to have images, and use these in search results to show graphically what each of the suggestions looks like. All of your ideas for language selection/detection are good. Perhaps we could also use the site language that the user is using (once tha

Re: [mb-style] Pre-RFC: Make instruments entities

2014-01-02 Thread Frederic Da Vitoria
2014/1/2 Ben Ockmore > Of course, there wouldn't be an instrument -> ID3 genre mapping! That part > applies to genres only. :P > > For instruments, the user would enter an instrument name into a free text > field, and this would be searched for among existing instrument entities. > If it's not fo

Re: [mb-style] Pre-RFC: Make instruments entities

2014-01-02 Thread Ben Ockmore
Of course, there wouldn't be an instrument -> ID3 genre mapping! That part applies to genres only. :P For instruments, the user would enter an instrument name into a free text field, and this would be searched for among existing instrument entities. If it's not found, then the user can proceed to

Re: [mb-style] Pre-RFC: Make instruments entities

2014-01-02 Thread Frederic Da Vitoria
2014/1/1 Ben Ockmore > I still think that similar systems should be used for Genres and > Instruments (seeing as they're both tree-based systems), so I'd like to > wait until the developer decide on how they'll tackle Genres before > anything happens with instruments. > > What I'd like to see if

Re: [mb-style] Pre-RFC: Make instruments entities

2014-01-01 Thread Ben Ockmore
I still think that similar systems should be used for Genres and Instruments (seeing as they're both tree-based systems), so I'd like to wait until the developer decide on how they'll tackle Genres before anything happens with instruments. What I'd like to see if both Instruments and Genres as ent

Re: [mb-style] Pre-RFC: Make instruments entities

2013-12-28 Thread Maurits
Searching by instruments by their English name could be a solution too, I agree, though it would be more useful if you could search for all languages. And since I already translated most instrument names in Transifex, I wouldn't like to see that effort wasted either. How feasible would it be to

Re: [mb-style] Pre-RFC: Make instruments entities

2013-12-28 Thread Mihkel Tõnnov
2013/12/28 Maurits > Personally I'd love to have this feature because as a translator, I > wouldn't have to worry about translating the name of an instrument and > making it impossible for an end-user to find said instrument when > editing from a different-language release. > An entity-ified inst

Re: [mb-style] Pre-RFC: Make instruments entities

2013-12-28 Thread Rachel Dwight
On Dec 28, 2013, at 5:15 AM, Maurits wrote: > Hello, > > There is a ticket* in the bug tracker on turning instruments into > entities, but it doesn't seem to have been discussed on this mailing > list yet. > Obviously this would be a big feature and a schema change, and we'd have > to discus

[mb-style] Pre-RFC: Make instruments entities

2013-12-28 Thread Maurits
Hello, There is a ticket* in the bug tracker on turning instruments into entities, but it doesn't seem to have been discussed on this mailing list yet. Obviously this would be a big feature and a schema change, and we'd have to discuss the desirability of it first, so I didn't want to turn this