[Musicpd-dev-team] [PATCH] Set socket TCP keepalive option on incoming connections

2011-09-19 Thread Dan McGee
If a connected host disappears without our knowledge, as can happen over wireless or a hibernating machine, we continue to hold the port open waiting for messages. Because we never try to send anything down this now-broken pipe, the connection will sit idle taking up a slot in our allowed incoming

Re: [Musicpd-dev-team] [PATCH] Set socket TCP keepalive option on incoming connections

2011-09-19 Thread Jonathan Neuschäfer
Just some minor nitpicks here, I'm not an MPD core developer. On Mon, Sep 19, 2011 at 08:10:13AM -0500, Dan McGee wrote: + if (fd = 0) { + if (socket_keepalive(fd)) + g_warning(Could not set TCP keepalive option: %s, +

Re: [Musicpd-dev-team] [PATCH] Set socket TCP keepalive option on incoming connections

2011-09-19 Thread Max Kellermann
On 2011/09/19 15:10, Dan McGee d...@archlinux.org wrote: If a connected host disappears without our knowledge, as can happen over wireless or a hibernating machine, we continue to hold the port open waiting for messages. Because we never try to send anything down this now-broken pipe, the

[Musicpd-dev-team] FLAC Streams

2011-09-19 Thread Tomas Sironi
How can I stream my FLAC files in FLAC (not ogg), using Icecast? -- Tomas Sironi -- BlackBerryreg; DevCon Americas, Oct. 18-20, San Francisco, CA Learn about the latest advances in developing for the BlackBerryreg;

[Musicpd-dev-team] [PATCH] Add documentation and use bool return for socket_keepalive()

2011-09-19 Thread Dan McGee
Signed-off-by: Dan McGee d...@archlinux.org --- src/server_socket.c |2 +- src/socket_util.c |6 -- src/socket_util.h | 10 +- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/server_socket.c b/src/server_socket.c index fc8dbd1..e68b595 100644 ---

Re: [Musicpd-dev-team] [PATCH] Set socket TCP keepalive option on incoming connections

2011-09-19 Thread Jonathan Neuschäfer
On Mon, Sep 19, 2011 at 10:20:54AM -0500, Dan McGee wrote: On Mon, Sep 19, 2011 at 10:13 AM, Jonathan Neuschäfer j.neuschae...@gmx.net wrote: Just some minor nitpicks here, I'm not an MPD core developer. On Mon, Sep 19, 2011 at 08:10:13AM -0500, Dan McGee wrote: +     if (fd = 0) { +  

[Musicpd-dev-team] [PATCH] Simplify setsockopt() casting workaround

2011-09-19 Thread Dan McGee
On Win32, the third setsockopt parameter has type (char *) while on POSIX systems it is (void *). However, given that it is a no-op cast to go from a char pointer to a void pointer, we can cast to a char pointer (with a possible const modifier) on all platforms and satisfy the compiler.

Re: [Musicpd-dev-team] FLAC Streams

2011-09-19 Thread Max Kellermann
On 2011/09/19 17:21, Tomas Sironi sironito...@gmail.com wrote: How can I stream my FLAC files in FLAC (not ogg), using Icecast? By using the flac encoder plugin. Unfortunately, this re-encodes the file, i.e. it wastes some CPU.

[Musicpd-dev-team] [PATCH 1/3] utils: mark sockaddr_to_string() as G_GNUC_MALLOC

2011-09-19 Thread Jonathan Neuschäfer
--- src/socket_util.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/socket_util.h b/src/socket_util.h index f27751a..022be8a 100644 --- a/src/socket_util.h +++ b/src/socket_util.h @@ -40,6 +40,7 @@ struct sockaddr; * @param error location to store the error

[Musicpd-dev-team] [PATCH 2/3] utils: uri.h: fix a typo: schema

2011-09-19 Thread Jonathan Neuschäfer
--- src/uri.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/uri.h b/src/uri.h index 85eeebe..5a9b472 100644 --- a/src/uri.h +++ b/src/uri.h @@ -25,7 +25,7 @@ #include stdbool.h /** - * Checks whether the specified URI has a schema in the form + * Checks whether

Re: [Musicpd-dev-team] MPD queue support by using python

2011-09-19 Thread zw g
Anyone give me a clue? Gui On Sat, Aug 13, 2011 at 10:15 PM, zw g pekingmas...@gmail.com wrote: Dear List, Sorry if here was the wrong place to ask this question, but i couldn't find a way to resolve my question. Below was the mail i sent to the python-mpd maintainer JAT couple of days

Re: [Musicpd-dev-team] FLAC Streams

2011-09-19 Thread Eric Wollesen
Is the documentation deficient in this respect? I remember looking for this and not seeing it in the docs. If anyone knows where this is documented, could you please point me to it? Otherwise, perhaps I'll try to get it setup (since I'm interested in this as well) and then I'll see if I