[Musicpd-dev-team] [PATCH 2/2] decoder/modplug: Add loop_count parameter

2013-10-19 Thread Sebastian Thorarensen
The loop_count configuration parameter allows the user to set how many times a module with backward loops shall loop. 0 (the default) means a module is not allowed to use backward loops at all. -1 enables inifinite looping. --- NEWS | 1 + doc/user.xml

[Musicpd-dev-team] [PATCH 0/2] decoder/modplug: Add loop_count parameter

2013-10-19 Thread Sebastian Thorarensen
Hi again, This is a set of patches similiar to the patch I sent for the Mikmod decoder. It adds a configuration parameter called loop_count for the Modplug decoder, which allows the user to set how many times the decoder should loop modules which uses backward loops. Mikmod only allows for

Re: [Musicpd-dev-team] Tags in OGG httpd stream

2013-10-19 Thread Max Kellermann
On 2013/10/11 05:12, Ben Boeckel maths...@gmail.com wrote: the tag chunk is dropped because chunk-length is 0 for it. A patch which fixes the issue is attached. Merged, thanks. Sorry for letting you wait for so long.

Re: [Musicpd-dev-team] Tags in OGG httpd stream

2013-10-19 Thread Ben Boeckel
On Sat, Oct 19, 2013 at 15:47:25 +0200, Max Kellermann wrote: On 2013/10/11 05:12, Ben Boeckel maths...@gmail.com wrote: the tag chunk is dropped because chunk-length is 0 for it. A patch which fixes the issue is attached. Merged, thanks. Sorry for letting you wait for so long. Thanks!

Re: [Musicpd-dev-team] ProxyDatabase plugin

2013-10-19 Thread Max Kellermann
On 2013/10/11 16:26, j...@dockes.org wrote: Hi, I have fleshed out the code inside ProxyDatabasePlugin.cpp so that it now works. Your patch is hard to read because it's all in one big undocumented chunk. Please split the patch into smaller pieces and document the API changes.

Re: [Musicpd-dev-team] YouTube support plugin

2013-10-19 Thread Max Kellermann
On 2013/10/12 16:38, Oleg Omelyusik oleg.omelyu...@gmail.com wrote: Hello everyone, I've started implementing YouTube (and maybe some other same services in future) support plugin. (I saw feature request on MPD's bugtracker which were submitted a year ago

Re: [Musicpd-dev-team] [PATCH 1/2] ConfigData: Add support for signed integers

2013-10-19 Thread Max Kellermann
On 2013/10/19 15:38, Sebastian Thorarensen se...@naju.se wrote: +unsigned +block_param::GetUnsignedValue() const +{ + long value2 = GetIntValue(); This explicitly limits the range of unsigned integers to 2^31. Why that? I admit that the existing code is bad as well, by using strtol()

Re: [Musicpd-dev-team] [PATCH 1/2] ConfigData: Add support for signed integers

2013-10-19 Thread Sebastian Thorarensen
On Sat, 19 Oct 2013, Max Kellermann wrote: This explicitly limits the range of unsigned integers to 2^31. Why that? To save three lines of code and but I missed that it would limit the range, so it was by mistake. -- Sebastian Thorarensen