Re: [Musicpd-dev-team] libcue licensing problem

2009-04-23 Thread Jochen Keil
Hi Max, Max Kellermann wrote: Avuton forwarded a mail from Svend Sorensen to me: On Wed, Apr 22, 2009 at 10:53 AM, Svend Sorensen sv...@ciffer.net wrote: Did you give permission to change the license to libcue[1]? I did not. Jochen Keil sent me an email asking if he could relicense parts

Re: [Musicpd-dev-team] libcue licensing problem

2009-04-23 Thread Jochen Keil
, Jochen Keil' marks code which is released as 2-clause BSD license You added your name to all source files, even those which you didn't That's why i added this: (and only with this notice alone, if there is an additional copyright notice about Svend Sorensen, GPL applies!) touch at all (e.g. time.c

Re: [Musicpd-dev-team] Support for parsing/tagging flac files according to embedded cuesheets

2009-03-23 Thread Jochen Keil
Hi Max, Max Kellermann wrote: It's important to document what was written by the original author and what was modified by you. Media players are a dangerous area (regarding copyright and patents), and we need to have a reliable audit trail of everything, just in case. I understand that and

Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository)

2009-03-17 Thread Jochen Keil
Hi Mario Lenz wrote: So a non- standard solution involving a complex task like developing a cuesheet parser is superior to another non- standard solution that simply changes a handfull of lines in your code? If you consider this a complex task than this must not mean that it's a difficult job

Re: [Musicpd-dev-team] Flac embedded cuesheet support

2009-03-01 Thread Jochen Keil
Hi Max, Max Kellermann wrote: Do you know of a better way/have a better idea for enumerating the subtracks instead of track_xxx.flac like i did atm? No, although I'd probably just call it 1, 2, ... without any prefix/suffix. I figured with the prefix the files get sorted in a correct

Re: [Musicpd-dev-team] Flac embedded cuesheet support

2009-02-28 Thread Jochen Keil
Hello Max, Max Kellermann wrote: It's a hack, but I think if we cut off some rough edges, we can merge it anyway. Let's get the feature in if it doesn't break anything, and think about migrating to a clean solution after that. Currently i'm working on the scan_directory() method you proposed

Re: [Musicpd-dev-team] Flac embedded cuesheet support

2009-02-23 Thread Jochen Keil
Hello Max, as promised i send the patch against the latest git sources (cloned on Mo 23 Feb 2009 10:57:36 CET). This will add support for embedded cue sheets in flac files. Please send me any comments for improvement, critisim or bugs. I have commented some parts where i think more work has to