Re: [Musicpd-dev-team] [PATCH] Add support for DSF files to DSDIFF decoder - v3

2012-04-24 Thread Bart Nagel
At 2012-04-25 00:03:00 +0200, Jonathan Neuschäfer wrote: > On Mon, Apr 23, 2012 at 07:16:49PM +0200, Jurgen Kramer wrote: > > Please show me how I can check myself. It is getting a bit tiresome to > > hear about wrong tabs/indents. > > > > Jurgen > > If you use Vim, this little snippet will highl

Re: [Musicpd-dev-team] [PATCH] Add support for DSF files to DSDIFF decoder - v3

2012-04-24 Thread Jonathan Neuschäfer
On Mon, Apr 23, 2012 at 07:16:49PM +0200, Jurgen Kramer wrote: > Please show me how I can check myself. It is getting a bit tiresome to > hear about wrong tabs/indents. > > Jurgen If you use Vim, this little snippet will highlight all trailing white space: > au Syntax * > \ syn match Extra

Re: [Musicpd-dev-team] [PATCH] Add support for DSF files to DSDIFF decoder - v3

2012-04-23 Thread Max Kellermann
On 2012/04/21 13:29, Jurgen Kramer wrote: > - Adhered to max 80 colom width This is not doxygen syntax, and is barely readable. Please use doxygen syntax for documenting struct attributes. > - Fixed indents (hopefully correctly) What did you fix? Indentation dsdiff_read_metadata() is still al

Re: [Musicpd-dev-team] [PATCH] Add support for DSF files to DSDIFF decoder - v3

2012-04-23 Thread Jurgen Kramer
On Mon, 2012-04-23 at 19:09 +0200, Max Kellermann wrote: > On 2012/04/21 13:29, Jurgen Kramer wrote: > > - Adhered to max 80 colom width > > This is not doxygen syntax, and is barely readable. Please use > doxygen syntax for documenting struct attributes. > > > - Fixed indents (hopefully correc

Re: [Musicpd-dev-team] [PATCH] Add support for DSF files to DSDIFF decoder - v3

2012-04-22 Thread Max Kellermann
On 2012/04/21 19:21, Jonathan Neuschäfer wrote: > On Sat, Apr 21, 2012 at 01:29:37PM +0200, Jurgen Kramer wrote: > > +struct dsdiff_header_dsf { > > + struct dsdiff_id id;/* "DSD " */ > > + uint32_t size_low, size_high; /* DSD chunk size, including id = 28 */ > > + uint32_t fsi

Re: [Musicpd-dev-team] [PATCH] Add support for DSF files to DSDIFF decoder - v3

2012-04-21 Thread Jonathan Neuschäfer
On Sat, Apr 21, 2012 at 01:29:37PM +0200, Jurgen Kramer wrote: > +struct dsdiff_header_dsf { > + struct dsdiff_id id;/* "DSD " */ > + uint32_t size_low, size_high; /* DSD chunk size, including id = 28 */ > + uint32_t fsize_low, fsize_high; /* Total file size */ > + uin

[Musicpd-dev-team] [PATCH] Add support for DSF files to DSDIFF decoder - v3

2012-04-21 Thread Jurgen Kramer
Attached is version 3 of the patch which adds support for DSF files to the DSDIFF decoder. It can be used in conjunction with DSD2PCM and DSD-over-USB. This version should address the concerns with v2. Changes from v2 patch: - Adhered to max 80 colom width - Fixed indents (hopefully correctly) -