Re: [Musicpd-dev-team] ProxyDatabase plugin

2013-10-20 Thread Jean-Francois Dockes
Max Kellermann writes: On 2013/10/20 09:22, Jean-Francois Dockes j...@dockes.org wrote: The existing ProxyDatabase plugin is not configured in the default mpd, and not usable anyway. Why do you think so? I've been using it for a while. I have tried it with phpmp, and while I can't

Re: [Musicpd-dev-team] ProxyDatabase plugin

2013-10-20 Thread Max Kellermann
On 2013/10/20 20:11, Jean-Francois Dockes j...@dockes.org wrote: The thing that made me believe this is the recursive field of the selection parameter to Visit, and the fact that the existing implementation in ProxyDatabasePlugin.cxx was recursive. Actually, recursive does not mean the

Re: [Musicpd-dev-team] ProxyDatabase plugin

2013-10-19 Thread Max Kellermann
On 2013/10/11 16:26, j...@dockes.org wrote: Hi, I have fleshed out the code inside ProxyDatabasePlugin.cpp so that it now works. Your patch is hard to read because it's all in one big undocumented chunk. Please split the patch into smaller pieces and document the API changes.

[Musicpd-dev-team] ProxyDatabase plugin

2013-10-11 Thread jf
Hi, I have fleshed out the code inside ProxyDatabasePlugin.cpp so that it now works. I have only lightly tested this, on a basic setup, and I don't no a lot about mpd, so I can't be sure that everything is working as it should. One visible problem is a performance issue for the search