On Thu, Jul 23, 2020 at 02:10:50AM +0300, Maxim Tarasov wrote:
One suggestion might be to remove the mutt_attrset_cursor() calls before
print_enriched_string(,,1). And inside print_enriched_string() instead:
We can even go a step further an use this ATTRSET (base_color) inside
> One suggestion might be to remove the mutt_attrset_cursor() calls before
> print_enriched_string(,,1). And inside print_enriched_string() instead:
We can even go a step further an use this ATTRSET (base_color) inside
print_enriched_string() unconditionally. Then top-level ATTRSET in
both
> Maybe search?
Add support for $cursor_overlay in pager searches
diff --git a/pager.c b/pager.c
index 740803eb..28a4deed 100644
--- a/pager.c
+++ b/pager.c
@@ -313,7 +313,7 @@ resolve_color (struct line_t *lineInfo, int n, int cnt, int
flags, int special,
if (color != last_color)
{
-
On Wed, Jul 22, 2020 at 01:39:41PM -0700, Kevin J. McCarthy wrote:
On Wed, Jul 22, 2020 at 09:15:39AM -0700, Kevin J. McCarthy wrote:
It looks like this version is now changing behavior with
$cursor_overlay unset. The tree colors should not be drawn (with
$arrow_cursor unset)
in that case.
I'm sorry for the duplicate, it looks like I messed up my config while
testing patches and didn't use list-reply properly last time.
> I've only taken a quick look at the patch - I don't have time to look
> closely or test right now.
>
> It looks like this version is now changing behavior with
On Wed, Jul 22, 2020 at 09:15:39AM -0700, Kevin J. McCarthy wrote:
It looks like this version is now changing behavior with
$cursor_overlay unset. The tree colors should not be drawn (with
$arrow_cursor unset)
in that case. Would you confirm that is still the case.
Sorry, my mistake. I
On Wed, Jul 22, 2020 at 02:58:50PM +0300, Maxim Tarasov wrote:
> -static void print_enriched_string (int attr, unsigned char *s, int do_color)
> +static void print_enriched_string (int base_color, unsigned char *s, int
do_color, int is_current)
I don't like the parameter to be named is_current
> > -static void print_enriched_string (int attr, unsigned char *s, int
> > do_color)
> > +static void print_enriched_string (int base_color, unsigned char *s, int
> > do_color, int is_current)
>
> I don't like the parameter to be named is_current but doesn't reflect that
> fact in the callers.
