Re: [mythtv] [PATCH] MythMusic Compilation Artist patch (missing file)

2005-02-06 Thread Colin Guthrie
Isaac Richards wrote: On Saturday 05 February 2005 09:05 am, Colin Guthrie wrote: OK I was lying... my .cvsrc had loads of weird diff options... No idea why they are there weird. Anyways, I've regenerated and attached. I'll apply this (and fix the dbcheck stuff because of the smartplaylist pa

Re: [mythtv] [PATCH] MythMusic Compilation Artist patch (fixed diff opts)

2005-02-05 Thread Isaac Richards
On Saturday 05 February 2005 09:05 am, Colin Guthrie wrote: > OK I was lying... my .cvsrc had loads of weird diff options... No idea > why they are there weird. > > Anyways, I've regenerated and attached. I'll apply this (and fix the dbcheck stuff because of the smartplaylist patch), but I ne

[mythtv] [PATCH] MythMusic Compilation Artist patch (fixed diff opts)

2005-02-05 Thread Colin Guthrie
Colin Guthrie wrote: Isaac Richards wrote: Looked through this a bit, and, well, I can't apply this. The indentation is completely messed up in parts, probably because you generated the diff with -b -B. Sugar I'll double check my files and regenerate... only cvs diff options are -u but I'll

Re: [mythtv] [PATCH] MythMusic Compilation Artist patch

2005-02-05 Thread Colin Guthrie
Isaac Richards wrote: Looked through this a bit, and, well, I can't apply this. The indentation is completely messed up in parts, probably because you generated the diff with -b -B. Sugar I'll double check my files and regenerate... only cvs diff options are -u but I'll make sure the indent

Re: [mythtv] [PATCH] MythMusic Compilation Artist patch

2005-02-05 Thread Isaac Richards
On Thursday 03 February 2005 07:25 pm, Colin Guthrie wrote: > Hi, > > In my last patch, I stated: > > Colin Guthrie wrote: > > These are: > > - Metadata editor currently writes the Musicbrainz Album Artist TXXX > > comment field on each edit for MP3 files. Should only have one copy of > > this fra

Re: [mythtv] [PATCH] MythMusic Compilation Artist patch

2005-02-04 Thread Colin Guthrie
Lonnie Hutchinson wrote: don't worry about the AAC metaio stuff...I will be submitting a patch tomorrow (unless testing goes poorly) that will add AAC metaio support. The code is written, just needs to be tested. Great!! But I'm guessing your metaio stuff wont deal with Compilation Artist right?

Re: [mythtv] [PATCH] MythMusic Compilation Artist patch

2005-02-03 Thread Lonnie Hutchinson
don't worry about the AAC metaio stuff...I will be submitting a patch tomorrow (unless testing goes poorly) that will add AAC metaio support. The code is written, just needs to be tested. Colin Guthrie wrote: Hi, In my last patch, I stated: Colin Guthrie wrote: These are: - Metadata editor curr

Re: [mythtv] [PATCH] MythMusic Compilation Artist patch

2005-02-03 Thread Colin Guthrie
Hi, In my last patch, I stated: Colin Guthrie wrote: These are: - Metadata editor currently writes the Musicbrainz Album Artist TXXX comment field on each edit for MP3 files. Should only have one copy of this frame/description combo in the ID3. - Metadata editor currently does not update files

[mythtv] [PATCH] MythMusic Compilation Artist patch (still has a couple issues)

2005-02-02 Thread Colin Guthrie
Hi, Attached is the latest version of my Compilation Artist patch. I think it is almost ready for CVS, but there are a couple of minor outstanding issues that I still need to resolve. These are: - Metadata editor currently writes the Musicbrainz Album Artist TXXX comment field on each edit for