RE: [nant-dev] patch for FileSet extension

2005-05-06 Thread Martin Aliger
> I think you should await consensus that this feature is > indeed necessary, and as such will end up in NAnt cvs. That is what I'm waiting for. If more test-cases or some fine-tuning (like no 'asis') will be needed, I'll do it. That is also reason why I dont want change alot of things, just exte

Re: [nant-dev] patch for FileSet extension

2005-05-06 Thread Gary Feldman
Martin Aliger wrote: (Regardless of what the decision is, the test cases need to include all combinations of asis, include, exclude, fromdir, relative basedir, absolute basedir, and omitted basedir.) That would be really nice. Unfortunatelly possible combinations grow with factorial - noone

RE: [nant-dev] patch for FileSet extension

2005-05-06 Thread Gert Driesen
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On > Behalf Of Martin Aliger > Sent: vrijdag 6 mei 2005 11:54 > To: 'Gary Feldman'; [EMAIL PROTECTED] > Subject: RE: [nant-dev] patch for FileSet extension > > >Inter

RE: [nant-dev] patch for FileSet extension

2005-05-06 Thread Martin Aliger
>Interesting. I think there is an opportunity for optimizing this, to eliminate the asis by changing the synchronization point. >For example, if the contents of the foo1 fileset were not computed until actually needed, then you could do away with the asis and apply the exclude. I'm not sure I wan

Re: [nant-dev] patch for FileSet extension

2005-05-05 Thread Gary Feldman
Martin Aliger wrote: Hi Gary, as I implemented it, it converts scanned files from first fileset to full path asis includes. So becomes

RE: [nant-dev] patch for FileSet extension

2005-05-05 Thread Martin Aliger
Hi Gary, as I implemented it, it converts scanned files from first fileset to full path asis includes. So becomes

Re: [nant-dev] patch for FileSet extension

2005-05-04 Thread Gary Feldman
Martin Aliger wrote: Hi all, Attached is patch and test-case for extension for type. It allows to include another fileset in current one. E.g.: What does it do in the presence of excludes? There are at least two cases, one where the included fileset has an exclude - which should not affect

[nant-dev] patch for FileSet extension

2005-05-04 Thread Martin Aliger
Hi all,   Attached is patch and test-case for extension for type. It allows to include another fileset in current one. E.g.:     It works even recursivelly, so this is valid:       This solves RFE 1051752 [http://sourceforge.net/tracker/?group_id=31650&atid=402871&func=detail&ai