Re: Review request for JDK-8151515: $EXEC output is truncated

2016-03-09 Thread Jim Laskey (Oracle)
+1 > On Mar 9, 2016, at 10:31 AM, Hannes Wallnoefer > wrote: > > Please review JDK-8151515: $EXEC output is truncated. > > http://cr.openjdk.java.net/~hannesw/8151515/ > > Thanks, > Hannes

Re: Review request for JDK-8151515: $EXEC output is truncated

2016-03-09 Thread Sundararajan Athijegannathan
+1 On 3/9/2016 8:01 PM, Hannes Wallnoefer wrote: > Please review JDK-8151515: $EXEC output is truncated. > > http://cr.openjdk.java.net/~hannesw/8151515/ > > Thanks, > Hannes

Review request for JDK-8151515: $EXEC output is truncated

2016-03-09 Thread Hannes Wallnoefer
Please review JDK-8151515: $EXEC output is truncated. http://cr.openjdk.java.net/~hannesw/8151515/ Thanks, Hannes

Re: RFR(XS): 8151518: relax test requirements to reduce dependency on directory contents

2016-03-09 Thread Sundararajan Athijegannathan
+1 On 3/9/2016 6:55 PM, Michael Haupt wrote: > Dear all, > > please review this fix. > Bug: https://bugs.openjdk.java.net/browse/JDK-8151518 > Webrev: http://cr.openjdk.java.net/~mhaupt/8151518/webrev.00/ > > Thanks, > > Michael >

Re: RFR(XS): 8151518: relax test requirements to reduce dependency on directory contents

2016-03-09 Thread Hannes Wallnoefer
+1 Am 2016-03-09 um 14:25 schrieb Michael Haupt: Dear all, please review this fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8151518 Webrev: http://cr.openjdk.java.net/~mhaupt/8151518/webrev.00/ Thanks, Michael

RFR(XS): 8151518: relax test requirements to reduce dependency on directory contents

2016-03-09 Thread Michael Haupt
Dear all, please review this fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8151518 Webrev: http://cr.openjdk.java.net/~mhaupt/8151518/webrev.00/ Thanks, Michael -- Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200

Re: RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin

2016-03-09 Thread Michael Haupt
... yes, whitespace. The diff is in the patch. Thanks, Michael > Am 09.03.2016 um 13:44 schrieb Sundararajan Athijegannathan > : > > No diffs in ScriptingFunctions.java. Whitespace? > > +1 > > -Sundar -- Dr. Michael Haupt | Principal Member of Technical Staff Ph

Re: RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin

2016-03-09 Thread Sundararajan Athijegannathan
No diffs in ScriptingFunctions.java. Whitespace? +1 -Sundar On 3/9/2016 5:59 PM, Michael Haupt wrote: > All, > > the updated webrev is at > http://cr.openjdk.java.net/~mhaupt/8151291/webrev.01/ - please review. > > The issue is a bit deeper. The way the current working directory is > initialis

Re: RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin

2016-03-09 Thread Jim Laskey (Oracle)
+1 > On Mar 9, 2016, at 8:29 AM, Michael Haupt wrote: > > All, > > the updated webrev is at > http://cr.openjdk.java.net/~mhaupt/8151291/webrev.01/ - please review. > > The issue is a bit deeper. The way the current working directory is > initialised and subsequently handled was the root cau

Re: RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin

2016-03-09 Thread Michael Haupt
All, the updated webrev is at http://cr.openjdk.java.net/~mhaupt/8151291/webrev.01/ - please review. The issue is a bit deeper. The way the current working directory is initialised and subsequently handled was the root cause of the observed problems. Cygwin being a unixy environment somewhat f