Re: Http client API

2012-08-08 Thread Sean Chou
Hi Chris, That's exactly my concern. I agree this provides best flexibility and content convenient methods are not proper in this API. So, is there going to have content specific convenient APIs like java.nio.file.Files ? Although it is a wrapper, it may be useful and intuitive, and easy to u

Re: Http client API

2012-08-08 Thread David M. Lloyd
On 08/07/2012 06:09 PM, Michael McMahon wrote: Hi, A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like to review the api on this mailing list. So, all comments are welcome. Why not jav

Re: Http client API

2012-08-08 Thread Jed Wesley-Smith
Michael McMahon writes: > A new revision of the Http client API planned for jdk 8 can be viewed > at the following link > > http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ > > We would like to review the api on this mailing list. > So, all comments are welcome. Can you separate the domai

Re: Http client API

2012-08-08 Thread Mike Duigou
Hi Michael! I really look forward to using this API! It looks like you have made a lot of progress. Sorry for having so many comments on just one round. Mike General:: - It's probably already been mentioned but having the classes in the httpclient package and most of them begin with "Http" see

Re: Http client API

2012-08-08 Thread Chris Hegarty
Oh, my head hurts! ;-) There are already three setBody methods. I agree, a boolean like this can be confusing. A setBodyRestartable(Itr), and setBodyNonRestarable(Itr) may be a possible solution here. But ( what I think you are suggesting too ), Iterable implementations should do the right th

cross protocol redirects ( was:Re: Http client API )

2012-08-08 Thread Chris Hegarty
Great suggestion Anthony, This is something that comes up from time to time. With the clear distinction between java.net.HttpURLConnection and javax.net.ssl.HttpsURLConnection API's then it was a little difficult to do in the existing API, but there is a clear opportunity with the new API to

Re: Http client API

2012-08-08 Thread Ian Robertston
Instead of HttpRequest having void setBody(Iterable buffers, boolean isRestartable) what about having two methods: void setBody(Iterable buffers) // presumed restartable void setBody(Iterator buffers) // clearly not restartable Not only does this avoid a potentially confusing boolean par

Re: Http client API

2012-08-08 Thread Anthony Vanelverdinghe
Hi With the current API (java.net.HttpURLConnection) it 's not possible to follow redirects from one protocol to another (http to https & vice versa). This is a known problem ( http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4620571 ), but out of security concerns this feature was not added

hg: jdk8/tl/jdk: 7189944: (launcher) test/tools/launcher/Arrrrghs.java needs a couple of minor fixes

2012-08-08 Thread kumar . x . srinivasan
Changeset: a44671e0b6d7 Author:ksrini Date: 2012-08-08 09:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a44671e0b6d7 7189944: (launcher) test/tools/launcher/Aghs.java needs a couple of minor fixes Reviewed-by: darcy, jgish ! test/tools/launcher/Arrrghs.java ! test/t

hg: jdk8/tl/jdk: 7189886: (aio) Add test coverage for AsynchronousChannelGroup.withThreadPool

2012-08-08 Thread alan . bateman
Changeset: a50e92a980a5 Author:alanb Date: 2012-08-08 15:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a50e92a980a5 7189886: (aio) Add test coverage for AsynchronousChannelGroup.withThreadPool Reviewed-by: alanb Contributed-by: amy...@oracle.com ! test/java/nio/channels/

Re: Http client API

2012-08-08 Thread Xuelei Fan
>From JDK 7, JSSE introduces a new hostname verifying approach. It is call "endpoint identification" in JSSE context. It can be used to replace the HostnameVerifier on SSLSession. A typical user case looks like: 1. implement a X509ExtendedTrustManager. It is required to check the endpoint identifi

hg: jdk8/tl/jdk: 7189533: GetJavaProperties should free temporary file if subsequent allocations fails

2012-08-08 Thread ahughes
Changeset: d87e86aaf2b3 Author:andrew Date: 2012-08-08 12:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d87e86aaf2b3 7189533: GetJavaProperties should free temporary file if subsequent allocations fails Summary: Add missing calls to free Reviewed-by: alanb, dholmes, sher

Re: Http client API

2012-08-08 Thread Alan Bateman
On 08/08/2012 07:25, Sean Chou wrote: Is it possible to have methods like public abstract HTMLDocument getResponse(String request) in class HttpClient ? I see Chris has replied to this. One other point is that we also need to consider JDK modularization and I don't think we should have any

Re: Http client API

2012-08-08 Thread Chris Hegarty
On 08/08/2012 07:25, Sean Chou wrote: Is it possible to have methods like public abstract HTMLDocument getResponse(String request) in class HttpClient ? Hi Sean, I think what you are suggesting is content specific convenience methods, something akin to URLConnection.getContent(), right? In