Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-17 Thread Chris Hegarty
On 16/08/12 10:21, Frank Ding wrote: Hi Chris and Alan, Thank you for taking time to help this issue. I have built using latest openjdk 8 repo on Windows 64 and Linux 32/64. Since it's a macro change in path src/solaris, I only did jtreg tests for Linux 32 and 64 build. The jtreg

hg: jdk8/tl/jdk: 7191275: Cleanup OS specific blocks in PlainDatagramSocketImpl.c to support more unix-like platforms

2012-08-17 Thread luchsh
Changeset: 4993f8aa7f2e Author:dingxmin Date: 2012-08-17 17:10 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4993f8aa7f2e 7191275: Cleanup OS specific blocks in PlainDatagramSocketImpl.c to support more unix-like platforms Reviewed-by: chegar !

Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-17 Thread Jonathan Lu
On 08/17/2012 04:14 PM, Chris Hegarty wrote: On 16/08/12 10:21, Frank Ding wrote: Hi Chris and Alan, Thank you for taking time to help this issue. I have built using latest openjdk 8 repo on Windows 64 and Linux 32/64. Since it's a macro change in path src/solaris, I only did jtreg

Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-17 Thread Frank Ding
Hi Chris and Jonathan, Thank you all. The change set is OK. Best regards, Frank On 8/17/2012 5:20 PM, Jonathan Lu wrote: On 08/17/2012 04:14 PM, Chris Hegarty wrote: On 16/08/12 10:21, Frank Ding wrote: Hi Chris and Alan, Thank you for taking time to help this issue. I have built

Re: Http client API

2012-08-17 Thread Michael McMahon
Chris, Thanks for the comments. Some responses below: On 09/08/12 19:15, Chris Hegarty wrote: Michael, Looking good, some comments. 1) Why the use of CookieManager, rather than CookieHandler? I would expect that CookieHandler would be a cleaner API CookieHandler is a very low level

Re: Http client API

2012-08-17 Thread Frank Carver
On 17 August 2012 11:30, Michael McMahon michael.x.mcma...@oracle.com wrote: 2) What is the impact on the sendHeader, setBody for HEAD requests? Ah yes, HEAD needs special treatment - though not with respect to the methods above as HEAD is identical to GET except with respect to any returned

Re: Http client API

2012-08-17 Thread Michael McMahon
On 17/08/12 11:59, Frank Carver wrote: On 17 August 2012 11:30, Michael McMahonmichael.x.mcma...@oracle.com wrote: 2) What is the impact on the sendHeader, setBody for HEAD requests? Ah yes, HEAD needs special treatment - though not with respect to the methods above as HEAD is identical to

hg: jdk8/tl/jdk: 6500133: REGRESSION: CertificateParsingException for CRL Distribution Point with blank

2012-08-17 Thread sean . mullan
Changeset: 6b2ebf3c4964 Author:mullan Date: 2012-08-17 14:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b2ebf3c4964 6500133: REGRESSION: CertificateParsingException for CRL Distribution Point with blank Reviewed-by: mullan Contributed-by: jason...@oracle.com !

hg: jdk8/tl/jdk: 7191322: add test for 7064927 to java.lang.instrument

2012-08-17 Thread daniel . daugherty
Changeset: 509421263cdd Author:dcubed Date: 2012-08-17 12:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/509421263cdd 7191322: add test for 7064927 to java.lang.instrument Summary: Add support for canRetransform attribute to the test manager. Add test for 7064927.

hg: jdk8/tl/langtools: 7192449: fix up tests to accommodate jtreg spec change

2012-08-17 Thread jonathan . gibbons
Changeset: 5ac2e9ee969e Author:jjg Date: 2012-08-17 17:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5ac2e9ee969e 7192449: fix up tests to accommodate jtreg spec change Reviewed-by: darcy ! test/tools/javac/processing/6414633/T6414633.java !