hg: jdk8/tl/jdk: 8011038: sourceObj validation during desereliazation of RelationNotification should be relaxed

2013-08-06 Thread dmitry . samersoff
Changeset: fce446b29577 Author:dsamersoff Date: 2013-08-06 14:04 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fce446b29577 8011038: sourceObj validation during desereliazation of RelationNotification should be relaxed Summary: sourceObj could be set to null by setSource()

RFR Additional debug info for test/java/net/NetworkInterface/IndexTest.java

2013-08-06 Thread Chris Hegarty
This test has been seen to fail intermittently on a number of systems. This change proposes to add some additional debug information to help diagnose the failure when it appears again. The test remains silent until it encounters an issue. I need a reviewer before I can push this simple

Re: RFR Additional debug info for test/java/net/NetworkInterface/IndexTest.java

2013-08-06 Thread Michael McMahon
Looks fine, Chris Michael On 06/08/13 12:12, Chris Hegarty wrote: This test has been seen to fail intermittently on a number of systems. This change proposes to add some additional debug information to help diagnose the failure when it appears again. The test remains silent until it

Code review request, 8020842 IDN do not throw IAE when hostname ends with a trailing dot

2013-08-06 Thread Xuelei Fan
Hi, Please review the bug fix to strict the illegal input checking in IDN. webrev: http://cr.openjdk.java.net./~xuelei/8020842/webrev.00/ Here is two test cases, which are expected to get IAE. Case 1: String host = IDN.toASCII(., IDN.USE_STD3_ASCII_RULES); Exception in thread main

Re: RFR Additional debug info for test/java/net/NetworkInterface/IndexTest.java

2013-08-06 Thread Alan Bateman
On 06/08/2013 04:12, Chris Hegarty wrote: This test has been seen to fail intermittently on a number of systems. This change proposes to add some additional debug information to help diagnose the failure when it appears again. The test remains silent until it encounters an issue. I need a

Re: RFR Additional debug info for test/java/net/NetworkInterface/IndexTest.java

2013-08-06 Thread Chris Hegarty
On 06/08/2013 15:09, Alan Bateman wrote: On 06/08/2013 04:12, Chris Hegarty wrote: This test has been seen to fail intermittently on a number of systems. This change proposes to add some additional debug information to help diagnose the failure when it appears again. The test remains silent

hg: jdk8/tl/langtools: 8022186: javac generates dead code if a try with an empty body has a finalizer

2013-08-06 Thread vicente . romero
Changeset: 99b60bcf3862 Author:vromero Date: 2013-08-06 15:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/99b60bcf3862 8022186: javac generates dead code if a try with an empty body has a finalizer Reviewed-by: jjg !

hg: jdk8/tl/jdk: 8022344: Additional debug info for test/java/net/NetworkInterface/IndexTest.java

2013-08-06 Thread chris . hegarty
Changeset: 6773af0dda02 Author:chegar Date: 2013-08-06 15:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6773af0dda02 8022344: Additional debug info for test/java/net/NetworkInterface/IndexTest.java Reviewed-by: michaelm, alanb !

Re: Code review request, 8020842 IDN do not throw IAE when hostname ends with a trailing dot

2013-08-06 Thread Weijun Wang
I am not sure if IDN.java is the correct place to change. At least I've seen trailing dots in DNS entries. So maybe it's not so illegal. --Max On 8/6/13 7:44 PM, Xuelei Fan wrote: Hi, Please review the bug fix to strict the illegal input checking in IDN. webrev:

Re: Code review request, 8020842 IDN do not throw IAE when hostname ends with a trailing dot

2013-08-06 Thread Xuelei Fan
On Aug 6, 2013, at 23:08, Weijun Wang weijun.w...@oracle.com wrote: I am not sure if IDN.java is the correct place to change. At least I've seen trailing dots in DNS entries. So maybe it's not so illegal. Per RFC 1034, a domain name cannot end with dot. I will check other related

RFR 8022126: Remove throws SocketException from DatagramPacket constructors accepting SocketAddress

2013-08-06 Thread Chris Hegarty
This is a followup to the recent discussion on: http://mail.openjdk.java.net/pipermail/net-dev/2013-July/006889.html (cont'd) http://mail.openjdk.java.net/pipermail/net-dev/2013-August/006914.html Two DatagramPacket constructors declare that they throw SocketException.

hg: jdk8/tl/jdk: 2 new changesets

2013-08-06 Thread sean . mullan
Changeset: 1f4af3e0447e Author:mullan Date: 2013-08-06 08:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f4af3e0447e 8022120: JCK test api/javax_xml/crypto/dsig/TransformService/index_ParamMethods fails Summary: TransformService.init and marshalParams must throw

Re: RFR 8022126: Remove throws SocketException from DatagramPacket constructors accepting SocketAddress

2013-08-06 Thread Alan Bateman
On 06/08/2013 08:32, Chris Hegarty wrote: This is a followup to the recent discussion on: http://mail.openjdk.java.net/pipermail/net-dev/2013-July/006889.html (cont'd) http://mail.openjdk.java.net/pipermail/net-dev/2013-August/006914.html Two DatagramPacket constructors declare that they

Re: Code review request, 8020842 IDN do not throw IAE when hostname ends with a trailing dot

2013-08-06 Thread Matthew Hall
Trailing dots are allowed in plain DNS (thus almost surely in IDN), and the single dot represents the root zone. So you have to be careful making this sort of change to check the DNS RFCs first. Matthew. -- Sent from my mobile device. Weijun Wang weijun.w...@oracle.com wrote: I am not sure if

Re: Code review request, 8020842 IDN do not throw IAE when hostname ends with a trailing dot

2013-08-06 Thread Matthew Hall
Take a look here for more clarity: http://en.wikipedia.org/wiki/Fully_qualified_domain_name -- Sent from my mobile device. Matthew Hall mh...@mhcomputing.net wrote: Trailing dots are allowed in plain DNS (thus almost surely in IDN), and the single dot represents the root zone. So you have to be

Re: Code review request, 8020842 IDN do not throw IAE when hostname ends with a trailing dot

2013-08-06 Thread Dmitry Samersoff
Xuelei, . (dot) is perfectly valid domain name and it means root domain so com. is valid domain name as well. It thinks to me that in context of methods your change we should ignore trailing dots, rather than throw exception. -Dmitry On 2013-08-06 15:44, Xuelei Fan wrote: Hi, Please

Re: RFR 8022126: Remove throws SocketException from DatagramPacket constructors accepting SocketAddress

2013-08-06 Thread Michael McMahon
On 06/08/13 16:57, Alan Bateman wrote: On 06/08/2013 08:32, Chris Hegarty wrote: This is a followup to the recent discussion on: http://mail.openjdk.java.net/pipermail/net-dev/2013-July/006889.html (cont'd) http://mail.openjdk.java.net/pipermail/net-dev/2013-August/006914.html Two

Re: Code review request, 8020842 IDN do not throw IAE when hostname ends with a trailing dot

2013-08-06 Thread Michael McMahon
I don't really understand the reason for the restriction in SNIHostName But, I guess that is where it should be enforced if it is required. Michael. On 06/08/13 17:43, Dmitry Samersoff wrote: Xuelei, . (dot) is perfectly valid domain name and it means root domain so com. is valid domain name

Re: RFR 8022126: Remove throws SocketException from DatagramPacket constructors accepting SocketAddress

2013-08-06 Thread Matthew Hall
On Tue, Aug 06, 2013 at 06:18:39PM +0100, Michael McMahon wrote: Documenting in release notes is okay too, but I suspect developers are not likely to look there at first anyway. Thinking aloud, it would be nice if some kind of annotation could be associated with the affected constructors

hg: jdk8/tl/jdk: 8022174: Fix doclint warnings in javax.sound; ...

2013-08-06 Thread joe . darcy
Changeset: 98643f3ddf40 Author:darcy Date: 2013-08-06 13:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/98643f3ddf40 8022174: Fix doclint warnings in javax.sound 8022404: Fix doclint issues in java.applet Reviewed-by: prr !

hg: jdk8/tl/jdk: 8022412: Fixed warnings in java.util root, except for HashMap

2013-08-06 Thread stuart . marks
Changeset: 12c1b78acf9a Author:lagergren Date: 2013-08-06 12:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/12c1b78acf9a 8022412: Fixed warnings in java.util root, except for HashMap Reviewed-by: mduigou, darcy Contributed-by: marcus.lagerg...@oracle.com !

hg: jdk8/tl/jdk: 8022410: Fix Javac Warnings in com.sun.security.auth Package

2013-08-06 Thread dan . xu
Changeset: 4b8b811059db Author:dxu Date: 2013-08-06 14:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b8b811059db 8022410: Fix Javac Warnings in com.sun.security.auth Package Reviewed-by: darcy ! src/share/classes/com/sun/security/auth/PolicyFile.java !

hg: jdk8/tl/jdk: 8022440: suppress deprecation warnings in sun.rmi

2013-08-06 Thread stuart . marks
Changeset: 31e923842d49 Author:smarks Date: 2013-08-06 14:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31e923842d49 8022440: suppress deprecation warnings in sun.rmi Reviewed-by: mduigou ! src/share/classes/sun/rmi/runtime/Log.java !

hg: jdk8/tl/jdk: 8022406: Fix doclint issues in java.beans

2013-08-06 Thread joe . darcy
Changeset: d5694d78ebc6 Author:darcy Date: 2013-08-06 16:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5694d78ebc6 8022406: Fix doclint issues in java.beans Reviewed-by: prr ! src/share/classes/java/beans/AppletInitializer.java ! src/share/classes/java/beans/Beans.java

hg: jdk8/tl/jdk: 8022453: Fix doclint issues in javax.accessibility

2013-08-06 Thread joe . darcy
Changeset: 6cc8c2ad9804 Author:darcy Date: 2013-08-06 16:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6cc8c2ad9804 8022453: Fix doclint issues in javax.accessibility Reviewed-by: prr ! src/share/classes/javax/accessibility/Accessible.java !

hg: jdk8/tl/corba: 2 new changesets

2013-08-06 Thread lana . steuck
Changeset: 528c7e76eaee Author:cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/528c7e76eaee Added tag jdk8-b101 for changeset a013024b0747 ! .hgtags Changeset: 342a954b68f3 Author:lana Date: 2013-08-06 16:54 -0700 URL:

hg: jdk8/tl/jaxp: 2 new changesets

2013-08-06 Thread lana . steuck
Changeset: b8cd8b101ecb Author:cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b8cd8b101ecb Added tag jdk8-b101 for changeset 0a7432f898e5 ! .hgtags Changeset: 7cffafa606e9 Author:lana Date: 2013-08-06 10:02 -0700 URL:

hg: jdk8/tl/jaxws: Added tag jdk8-b101 for changeset 60b623a36164

2013-08-06 Thread lana . steuck
Changeset: 988a5f2ac559 Author:cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/988a5f2ac559 Added tag jdk8-b101 for changeset 60b623a36164 ! .hgtags

hg: jdk8/tl/langtools: 4 new changesets

2013-08-06 Thread lana . steuck
Changeset: 4c42fba7b0e7 Author:cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4c42fba7b0e7 Added tag jdk8-b101 for changeset 0324dbf07b0f ! .hgtags Changeset: 453a305e1165 Author:lana Date: 2013-08-06 10:03 -0700 URL:

hg: jdk8/tl/hotspot: 61 new changesets

2013-08-06 Thread lana . steuck
Changeset: 2285b4a0a4e6 Author:amurillo Date: 2013-07-18 09:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2285b4a0a4e6 8020797: new hotspot build - hs25-b43 Reviewed-by: jcoomes ! make/hotspot_version Changeset: dbc0b5dc08f5 Author:fparain Date: 2013-07-10

hg: jdk8/tl/jdk: 28 new changesets

2013-08-06 Thread lana . steuck
Changeset: b52a2ecdb803 Author:cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b52a2ecdb803 Added tag jdk8-b101 for changeset 690161232823 ! .hgtags Changeset: 2978c0a543ed Author:prr Date: 2013-07-22 12:52 -0700 URL:

hg: jdk8/tl: Added tag jdk8-b101 for changeset 9f74a220677d

2013-08-06 Thread lana . steuck
Changeset: 5eb3c1dc348f Author:cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/5eb3c1dc348f Added tag jdk8-b101 for changeset 9f74a220677d ! .hgtags

RFR:JDK-8022478 - Fix Warnings In sun.net.www.protocol.http Package

2013-08-06 Thread Dan Xu
Hi All, Please review the [serial] warning fix inside sun.net.www.protocol.http package. Webrev: http://cr.openjdk.java.net/~dxu/8022478/webrev/ Thanks, -Dan

Re: RFR:JDK-8022478 - Fix Warnings In sun.net.www.protocol.http Package

2013-08-06 Thread Joe Darcy
Hi Dan, As we discussed in person, since you are adding serial version uid that matches the existing type, this is fine. Approved to go back. Thanks, -Joe On 08/06/2013 05:57 PM, Dan Xu wrote: Hi All, Please review the [serial] warning fix inside sun.net.www.protocol.http package.

hg: jdk8/tl/jdk: 8022478: Fix Warnings In sun.net.www.protocol.http Package

2013-08-06 Thread dan . xu
Changeset: 1d21ff5c2b3f Author:dxu Date: 2013-08-06 18:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d21ff5c2b3f 8022478: Fix Warnings In sun.net.www.protocol.http Package Reviewed-by: darcy ! src/share/classes/sun/net/www/protocol/http/AuthCacheValue.java !

hg: jdk8/tl/jdk: 8022476: cleanup some raw types and unchecked warnings in java.util.stream

2013-08-06 Thread mike . duigou
Changeset: e117fcdd2176 Author:mduigou Date: 2013-08-06 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e117fcdd2176 8022476: cleanup some raw types and unchecked warnings in java.util.stream Reviewed-by: darcy Contributed-by: mike.dui...@oracle.com,