Rob,
Instead of iterating interfaces list twice you can maintain two indices,
as you already know exact number of addresses.
put_v4_at(i)
put_v6_at(j+v4count)
Also you can take a look at
solaris/native/java/net/NetworkInterface.c
and possibly re-use some logic from there.
-Dmitry
On 2013-09-
Hello,
I reported before, AI_CANONNAME is used in different places with no good
reason. If you use the flag, the result would be in res[0].ai_canonname,
which is not used. So you can remove it and safe the elaborate resolving
which comes with it.
And I also think the comment "skip DNS loo
Rob,
Did you try to remove
hints.ai_flags = AI_CANONNAME
this flag asks getaddreinfo to return FQDN, but the function behavior is
not clearly defined for the case where FQDN is not available.
-Dmitry
On 2013-09-03 19:18, Rob McKenna wrote:
> Hi folks,
>
> Mac seems to have trouble looking up
On 09/04/2013 02:49 PM, Rob McKenna wrote:
Indeed it did.
Great, so we should behave in a similar manner to that of Apple's JDK6.
I think I understand why you added lookupIfLocalhost before getaddrinfo,
in lookupAllHostAddr, but it has the consequence of retrieving the
hostname for every oth
Mark,
Looks good for me besides the fact that
if (((ptr->IfIndex != 0)&&(ptr->IfIndex == index)) ||
((ptr->Ipv6IfIndex !=0) && (ptr->Ipv6IfIndex == index))) {
could be written as:
ll. 129
if ( index == 0 )
return NULL;
if (ptr->IfIndex == index ||
ptr->Ipv6IfIndex == index) {
..
Changeset: 4c711ef41bfa
Author:naoto
Date: 2013-09-05 10:14 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4c711ef41bfa
8023943: Method description fix for String.toLower/UpperCase() methods
Reviewed-by: okutsu
! src/share/classes/java/lang/String.java
Looks good to me Mark.
I can sponsor this for you.
-Chris.
On 09/05/2013 05:07 PM, Mark Sheppard wrote:
Hi,
please oblige and review the latest version of the fix below to address
the issue in JDK-8021372:
NetworkInterface.getNetworkInterfaces() returns duplicate hardware address
This incorpo
Hi,
please oblige and review the latest version of the fix below to address
the issue in JDK-8021372:
NetworkInterface.getNetworkInterfaces() returns duplicate hardware address
This incorporates Chris' suggestions wrt amending the associated test.
http://cr.openjdk.java.net/~msheppar/8021372/w
