Re: [9] RFR: 8138990: Implementation of HTTP Digest authentication may be more flexible

2016-01-21 Thread Michael McMahon
Artem, The change looks fine. Thanks, Michael On 04/01/16 18:39, Artem Smotrakov wrote: Hi Michael, On 01/04/2016 02:28 AM, Michael McMahon wrote: On 30/12/15 03:22, Artem Smotrakov wrote: Hi Michael, Thanks for review, it looks like BNF notation uses only a comma as a separator

Re: ServerImpl misplaced null check

2016-01-21 Thread David Holmes
Hi Scott, cc'ing net-dev as this is not a build issue. David On 21/01/2016 4:18 AM, Scott Palmer wrote: I was searching for a way to set TCP_NODELAY for an Endpoint using the default HTTP server and after finally tracking down the existence of the “sun.net.httpserver.nodelay” system

RFR: 8147962: URL should handle lower-casing of protocol locale-independently

2016-01-21 Thread Claes Redestad
Hi, using String.toLowerCase() in URL allows some strings to lower-case to a string that'd be invalid, e.g. "FILE".toLowerCase() -> "f\u0131le" in turkish locales. This patch suggests using the locale-independent String.toLowerCase(Locale.ENGLISH) instead, since only a-z and A-Z are legal

Re: RFR 8065076/9, test/java/net/SocketPermission/SocketPermissionTest.java failed intermittently

2016-01-21 Thread Felix Yang
Hi Chris, your fix is cool. I will assign the bug to you:) a comment on this fix. The test changed system SecurityManager and it is not executed with othervm mode. I think you need to rollback the change after test. Otherwise it may affect other tests. Thanks, Felix > On Jan 20, 2016,

Re: RFR: 8147962: URL should handle lower-casing of protocol locale-independently

2016-01-21 Thread Naoto Sato
Hello, I'd suggest using Locale.ROOT instead of Locale.ENGLISH for this purpose. Naoto On 1/21/16 10:57 PM, Claes Redestad wrote: Hi, using String.toLowerCase() in URL allows some strings to lower-case to a string that'd be invalid, e.g. "FILE".toLowerCase() -> "f\u0131le" in turkish