Re: RFR JDK-8087113: Websocket API and implementation

Hi, On Tue, May 3, 2016 at 5:23 PM, Pavel Rappo wrote: > > Hello, > > Here's an updated webrev with the latest implementation: > >http://cr.openjdk.java.net/~prappo/8087113/webrev.04/ Can you please summarize what's different from the previous ? I had a very quick

Re: RFR JDK-8087113: Websocket API and implementation

Strictly speaking, not sending a Pong for every Ping is not against the protocol semantics [1]: If an endpoint receives a Ping frame and has not yet sent Pong frame(s) in response to previous Ping frame(s), the endpoint MAY elect to send a Pong frame for only the most recently processed

Re: RFR: 8153572: [JEP 110] IOException (connection closed for reading) is thrown when try to connect HTTPS service

Hi Michael, Looks fine. Editorial: test/java/net/httpclient/http2/java.httpclient/java/net/http/Http2TestExchange.java Line 8: wildcard import unnecdssary when only using SSLSession test/java/net/httpclient/http2/java.httpclient/java/net/http/Http2TestServerConnection.java Line 34:

RFR: 8153572: [JEP 110] IOException (connection closed for reading) is thrown when try to connect HTTPS service

Simple change to set default use of TLSv1.2 when the user has not specified which protocols to use. http://cr.openjdk.java.net/~michaelm/8153572/webrev.1/ The change is in HttpClientImpl.java but also includes some logging additions. Thanks Michael

Re: RFR JDK-8087113: Websocket API and implementation

On 3 May 2016, at 16:23, Pavel Rappo wrote: > Hello, > > Here's an updated webrev with the latest implementation: > > http://cr.openjdk.java.net/~prappo/8087113/webrev.04/ This looks much better, more straight forward. I will ignore any TODO’s and items mentioned in

Re: RFR JDK-8087113: Websocket API and implementation

> On 5 May 2016, at 00:20, Jitendra Kotamraju wrote: > > * I see that there is an issue for autoponging. May be this falls under it. > The default impl of onPing() doesn't send PONG for *every* received PING. Yes, that's correct. The default implementation sends a Pong in

RFR: 8155888: java/net/httpclient/QuickResponses.java intermittently failed with java.util.ConcurrentModificationException

Another occasional test case failure. It's a concurrent modification exception caused by modifying a list during processing of the list (by the same thread). The solution is to keep separate lists of the modifications and to process them after the iterator completes.

Re: RFR: 8155928: Remove hardcoded port numbers from httpclient/Security.java test

On 4 May 2016, at 23:59, Michael McMahon wrote: > I've just updated the webrev at > > http://cr.openjdk.java.net/~michaelm/8155928/webrev.3 > > to retry the tests in the unlikely event of a BindException Thanks Michael. This looks ok. -Chris. > - Michael > >