Re: RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9

2016-05-20 Thread Chris Hegarty
> On 20 May 2016, at 14:10, Alan Bateman wrote: > > On 20/05/2016 14:05, Svetlana Nikandrova wrote: >> Alan, >> >> another test related to this option is on the same level >> (test/jdk/net/SocketFlow) I added this recently, when working on a different issue, when I

Re: RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9

2016-05-20 Thread Alan Bateman
On 20/05/2016 14:05, Svetlana Nikandrova wrote: Alan, another test related to this option is on the same level (test/jdk/net/SocketFlow) so I thought it's ok to maintain the same hierarchy. I can move test to test/jdk/net/Sockets/ExtendedSocketOptions/SO_FLOW_SLA or to

Re: RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9

2016-05-20 Thread Svetlana Nikandrova
Alan, another test related to this option is on the same level (test/jdk/net/SocketFlow) so I thought it's ok to maintain the same hierarchy. I can move test to test/jdk/net/Sockets/ExtendedSocketOptions/SO_FLOW_SLA or to test/jdk/net/Sockets, but in that case won't it be a little bit

Re: RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9

2016-05-20 Thread Alan Bateman
On 20/05/2016 11:16, Svetlana Nikandrova wrote: Hi Artem, thank you for your comments. Please see updated review: http://cr.openjdk.java.net/~snikandrova/8136933/webrev.01/ I've moved version check to OSInfo.java and used

Re: RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9

2016-05-20 Thread Svetlana Nikandrova
Hi Artem, thank you for your comments. Please see updated review: http://cr.openjdk.java.net/~snikandrova/8136933/webrev.01/ I've moved version check to OSInfo.java and used ProcessTools. Also made a little change in

Re: RFR 8048520 :File Descriptor Leak in jdk/src/solaris/native/java/net/net_util_md.c

2016-05-20 Thread Chris Hegarty
Looks good Vyom. I will sponsor this for you. -Chris > On 20 May 2016, at 09:50, vyom wrote: > > Hi, > > Please review the simple fix for below issue. > > Bug: JDK-8048520 :File Descriptor Leak in > jdk/src/solaris/native/java/net/net_util_md.c > > Webrev:

Re: RFR 8048520 :File Descriptor Leak in jdk/src/solaris/native/java/net/net_util_md.c

2016-05-20 Thread Alan Bateman
On 20/05/2016 09:50, vyom wrote: Hi, Please review the simple fix for below issue. Bug: JDK-8048520 :File Descriptor Leak in jdk/src/solaris/native/java/net/net_util_md.c Webrev: http://cr.openjdk.java.net/~vtewari/8048520/webrev0.0/index.html