Re: RFR 8154525, java/net/ServerSocket/ThreadStop.java fails intermittently with error while cleaning up threads after test

> On 27 Sep 2016, at 03:08, Felix Yang wrote: > > Hi all, > >please review following test fix. > > Bug: > >https://bugs.openjdk.java.net/browse/JDK-8154525 > > Webrev: > >http://cr.openjdk.java.net/~xiaofeya/8154525/webrev.00/ > > This test has been observed to fail sometimes w

Re: RFR - 8166747: Add invalid network / computer name cases to isReachable known failure switch

On 27 Sep 2016, at 01:02, Mark Sheppard wrote: > > Hi Rob, >changes look reasonable … +1 > perhaps align the two additions below the existing ERROR_XXX set, all neat > and tidy :-) +1 -Chris. > regards > Mark > > On 27/09/2016 00:09, Rob McKenna wrote: >> Hi folks, >> >> Looking for a

Re: RFR(XS): 8166584: Remove obsolete utility function NET_ThrowSocketException in windows libnet

Christoph, On 26 Sep 2016, at 18:58, Langer, Christoph wrote: > > Hi Chris, > > I agree with your comment on the NPE. It would probably be wrong. So I > restored the old code and also removed the comments suggesting the NPE. Here > is my new webrev: http://cr.openjdk.java.net/~clanger/webrevs

Re: RFR 8154525, java/net/ServerSocket/ThreadStop.java fails intermittently with error while cleaning up threads after test

Hi Chris, updated as suggested http://cr.openjdk.java.net/~xiaofeya/8154525/webrev.01/ Thanks, Felix On 2016/9/27 15:55, Chris Hegarty wrote: On 27 Sep 2016, at 03:08, Felix Yang wrote: Hi all, please review following test fix. Bug: https://bugs.openjdk.java.net/browse/JDK-815

Re: RFR 8154525, java/net/ServerSocket/ThreadStop.java fails intermittently with error while cleaning up threads after test

On 27 Sep 2016, at 09:25, Felix Yang wrote: > > Hi Chris, > >updated as suggested > > http://cr.openjdk.java.net/~xiaofeya/8154525/webrev.01/ Looks good to me. Up to you, but with the thread join ( if my hunch is correct ) we may not actually need othervm, but of course it should be fine

Re: RFR 8154525, java/net/ServerSocket/ThreadStop.java fails intermittently with error while cleaning up threads after test

Chris, I will push without othervm -Felix On 2016/9/27 16:29, Chris Hegarty wrote: On 27 Sep 2016, at 09:25, Felix Yang wrote: Hi Chris, updated as suggested http://cr.openjdk.java.net/~xiaofeya/8154525/webrev.01/ Looks good to me. Up to you, but with the thread join ( if my hunch

Re: RFR 8154525, java/net/ServerSocket/ThreadStop.java fails intermittently with error while cleaning up threads after test

On 27 Sep 2016, at 09:35, Felix Yang wrote: > > Chris, > >I will push without othervm Thanks. If we see future issues with this test, then we can add it back. -Chris. > -Felix > On 2016/9/27 16:29, Chris Hegarty wrote: >> On 27 Sep 2016, at 09:25, Felix Yang wrote: >>> Hi Chris, >>> >>>

RFR(s): 8166791: Fix module dependencies for networking component tests

Hi team, Could you please review small fix for regression tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8166791 WebRev: http://cr.openjdk.java.net/~skovalev/8166791/webrev.00/ Issue: Severl network related tests failed in case of using "--limit-modules java.base" command line option.

RE: RFR(XS): 8166584: Remove obsolete utility function NET_ThrowSocketException in windows libnet

Chris, thanks for your input. If there's no objections I'd push it like this later tomorrow: http://cr.openjdk.java.net/~clanger/webrevs/8166584.2/ I've replaced the JNU_JAVANETPKG and JNU_JAVAIOPKG macros with the full exception class names. Best regards Christoph > -Original Message

Re: RFR(XS): 8166584: Remove obsolete utility function NET_ThrowSocketException in windows libnet

> On 27 Sep 2016, at 19:56, Langer, Christoph wrote: > > Chris, > > thanks for your input. > > If there's no objections I'd push it like this later tomorrow: > http://cr.openjdk.java.net/~clanger/webrevs/8166584.2/ Looks ok to me Christoph. Thanks, -Chris. > I've replaced the JNU_JAVANETPKG