Re: RFR: 8169068: Add a new method: java.net.Authenticator.getDefault()

On 03/11/16 17:54, Daniel Fuchs wrote: Hi Chris, Thanks a lot for the feedback. Here is a new webrev incorporating your comments: http://cr.openjdk.java.net/~dfuchs/webrev_8169068/webrev.01 Thanks Daniel, this looks good. -Chris. -- daniel On 03/11/16 14:40, Chris Hegarty wrote: Daniel

Re: RFR: 8169068: Add a new method: java.net.Authenticator.getDefault()

Hi Chris, Thanks a lot for the feedback. Here is a new webrev incorporating your comments: http://cr.openjdk.java.net/~dfuchs/webrev_8169068/webrev.01 -- daniel On 03/11/16 14:40, Chris Hegarty wrote: Daniel, On 03/11/16 10:20, Daniel Fuchs wrote: Hi, Please find below a patch for: RFR:

RE: RFR(M): 8167420: remove redundant code path in unix/native/libnet/Inet4AddressImpl.c

Hi again, I have to make one addition to my points: Java_java_net_Inet6AddressImpl_getLocalHostName: - made getaddrinfo/getnameinfo turnaround the default, before it was only used on solaris. But it should be the default since Inet4Addressimpl does it as well?? Or do we want to remove

Re: RFR(s): 8169196: [TESTBUG] Three tests from sun/net/www have undeclared dependencies

Daniel, I case I remove lines 218-223 and disable jdk.security.auth module the test fails with an Exception: Expect client to choose: Basic HTTP/1.1 401 Unauthorized Content-Length: 0 Connection: close WWW-Authenticate: Basic realm="wallyworld" WWW-Authenticate: NTLM Server received Authoriz

Re: RFR(s): 8169196: [TESTBUG] Three tests from sun/net/www have undeclared dependencies

Hi Sergey, Great to get rid of yet another shell script. The change looks good in general - except for NoNTLM.java: I don't think the test should have @modules jdk.security.auth as the test is precisely supposed to be able to run without it (+ lines 218-223 are probably obsolete and I suspect t

Re: RFR: 8169068: Add a new method: java.net.Authenticator.getDefault()

Daniel, On 03/11/16 10:20, Daniel Fuchs wrote: Hi, Please find below a patch for: RFR: 8169068: Add a new method: java.net.Authenticator.getDefault() https://bugs.openjdk.java.net/browse/JDK-8169068 > The method implementation itself is trivial. The API documentation is derived from that of

RFR(s): 8169196: [TESTBUG] Three tests from sun/net/www have undeclared dependencies

Hi Team, Please review one more small fix for module dependencies issue. Bug ID: https://bugs.openjdk.java.net/browse/JDK-8169196 WebRev: http://cr.openjdk.java.net/~skovalev/8169196/webrev.00/index.html Added missed dependency on jdk.httpserver. Also shell test converted to pure java test.

Re: RFR(s): 8169002: [TESTBUG] Several java/net/httpclient have undeclared dependency on java.logging module

Hi, Beside of listed in the review tests there are another tests in the folder. In case I'd update TEST.properties the not listed tests also will get unnecessary dependency from java.logging. -- With best regards, Sergei On 1 Nov 2016, at 18:40, Roger Riggs

RFR: 8169068: Add a new method: java.net.Authenticator.getDefault()

Hi, Please find below a patch for: RFR: 8169068: Add a new method: java.net.Authenticator.getDefault() https://bugs.openjdk.java.net/browse/JDK-8169068 The method implementation itself is trivial. The API documentation is derived from that of Authenticator::setDefault The method checks for the