Re: RFR: JDK-7155591 - [macosx] regression test java/net/MulticastSocket/SetOutgoingIf.java fail

2017-05-04 Thread Mark Sheppard
Thanks Brian On 04/05/2017 22:13, Brian Burkhalter wrote: Hi Mark, Not exactly my area but I did look over similar code that Chris wrote for [1] and your code here looks OK (aside from the more recent copyright year). Thanks, Brian [1] https://bugs.openjdk.java.net/browse/JDK-8158270 On

Re: RFR: JDK-7155591 - [macosx] regression test java/net/MulticastSocket/SetOutgoingIf.java fail

2017-05-04 Thread Brian Burkhalter
Hi Mark, Not exactly my area but I did look over similar code that Chris wrote for [1] and your code here looks OK (aside from the more recent copyright year). Thanks, Brian [1] https://bugs.openjdk.java.net/browse/JDK-8158270 On May 4, 2017, at 1:56 PM, Mark Sheppard

RFR: JDK-7155591 - [macosx] regression test java/net/MulticastSocket/SetOutgoingIf.java fail

2017-05-04 Thread Mark Sheppard
Hi, please oblige and review the following change http://cr.openjdk.java.net/~msheppar/7155591/webrev/ to address the issue raised in https://bugs.openjdk.java.net/browse/JDK-7155591 this identifies that the awdl interface causes issues for the SetOutgoingIf multicast socket test, and the

Re: RFR 8179602: Fix for JDK-8165437 is broken on 32-bit Linux

2017-05-04 Thread Chris Hegarty
> On 4 May 2017, at 17:58, Michael McMahon wrote: > > Hi Vyom, > > As discussed, I think there are still some issues including on 32 bit Linux > and since we don't > have too many of those machines left to debug with, it's probably best to > back out the

Re: RFR 8179602: Fix for JDK-8165437 is broken on 32-bit Linux

2017-05-04 Thread Michael McMahon
Hi Vyom, As discussed, I think there are still some issues including on 32 bit Linux and since we don't have too many of those machines left to debug with, it's probably best to back out the original change, and go back to the original webrev. We can then review an updated version which takes

Re: RFR 8179602: Fix for JDK-8165437 is broken on 32-bit Linux

2017-05-04 Thread Vyom Tewari
Hi All, please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8179602/webrev0.1/index.html) which fixed the Mac OS issued as well. Michael as we we discussed off line, i incorporated the changes suggested by you, Thanks, Vyom On Thursday 04 May 2017 03:11 PM, Michael

Re: RFR 8179602: Fix for JDK-8165437 is broken on 32-bit Linux

2017-05-04 Thread Michael McMahon
Hi Vyom, I notice this doesn't seem to fix the Mac OS problem. We may have to file a separate issue for that. - Michael On 04/05/2017, 09:50, Vyom Tewari wrote: Hi All, Please review the below change. Webrev: http://cr.openjdk.java.net/~vtewari/8179602/webrev0.0/index.html Bugid:

RFR 8179602: Fix for JDK-8165437 is broken on 32-bit Linux

2017-05-04 Thread Vyom Tewari
Hi All, Please review the below change. Webrev: http://cr.openjdk.java.net/~vtewari/8179602/webrev0.0/index.html Bugid: https://bugs.openjdk.java.net/browse/JDK-8179602 This issue is because of side effect of "JDK-8165437" where we are using "JVM_NanoTime" which returns a 64 bit jlong and