Re: RFR: 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic

Hi Daniel, a little feedback on the test and some observations. was curious about this test, mainly that debug wasn't synchronized and expected to see interleaved output from clients and servers. So ran the test … had look at the output, which wasn't interleaved and totals all seemed to matched

Re: [teststabilization] RFR: 8223798 : Replace wildcard address with loopback or local host in tests - part 7

Vyom, Daniel, Thanks for your reviews! Best Regards, Aleksei On 15/05/2019 18:51, Vyom Tiwari wrote: Hi Aleks, latest changes looks good to me . Thanks, Vyom On Wed, May 15, 2019 at 11:12 PM Aleks Efimov mailto:aleksej.efi...@oracle.com>> wrote: Hi Daniel, Thanks for the review.

Re: [teststabilization] RFR: 8223798 : Replace wildcard address with loopback or local host in tests - part 7

Hi Aleks, latest changes looks good to me . Thanks, Vyom On Wed, May 15, 2019 at 11:12 PM Aleks Efimov wrote: > Hi Daniel, > > Thanks for the review. I've modified Socket_getInputStream_[read|write] > to follow your suggestion: > -ServerSocket ss = new ServerSocket(0); >

Re: [teststabilization] RFR: 8223798 : Replace wildcard address with loopback or local host in tests - part 7

On 15/05/2019 18:41, Aleks Efimov wrote: Hi Daniel, Thanks for the review. I've modified Socket_getInputStream_[read|write] to follow your suggestion: -    ServerSocket ss = new ServerSocket(0); InetAddress lh = InetAddress.getLocalHost(); +    ServerSocket ss =

Re: [teststabilization] RFR: 8223798 : Replace wildcard address with loopback or local host in tests - part 7

Hi Daniel, Thanks for the review. I've modified Socket_getInputStream_[read|write] to follow your suggestion: -    ServerSocket ss = new ServerSocket(0); InetAddress lh = InetAddress.getLocalHost(); +    ServerSocket ss = new ServerSocket(0, 0, lh); Also I've

Re: RFR: 8223880: Update sun/net/ftp/FtpURL.java and sun/net/ftp/FtpURLConnectionLeak.java to work with IPv6 addresses

Hi Daniel, latest change looks good to me. Even i wanted to remove duplicate "FtpServer code" that we had copy and pasted but somehow I did not got time do it. Thanks, Vyom On Wed, May 15, 2019 at 7:08 PM Daniel Fuchs wrote: > Hi Vyom, > > On 15/05/2019 11:25, Vyom Tiwari wrote: > > Hi

Re: [teststabilization] RFR: 8223798 : Replace wildcard address with loopback or local host in tests - part 7

Hi Aleksei, On 15/05/2019 17:07, Aleks Efimov wrote: Hi, Another part of test fixes to address intermittent networking test failures can be viewed here: http://cr.openjdk.java.net/~aefimov/8223798/00/ Socket_getInputStream_read.java: Socket_getOutputStream_write.java: I think you could

Re: [ipv6] RFR: 8223532: Don't try creating IPv4 sockets in NetworkInterface.c if IPv4 is not supported

Hi Arthur, On 15/05/2019 17:11, Arthur Eubanks wrote: I thought I always needed two people to say the change looks good. Is only needing one reviewer a JDK policy or a net-dev policy? It depends on the project/group rules. AFAIK you only need two reviewers when you contribute changes to

[teststabilization] RFR: 8223798 : Replace wildcard address with loopback or local host in tests - part 7

Hi, Another part of test fixes to address intermittent networking test failures can be viewed here: http://cr.openjdk.java.net/~aefimov/8223798/00/ Could I please ask for the help to review it? JBS: https://bugs.openjdk.java.net/browse/JDK-8223798 With Best Regards, Aleksei

Re: [ipv6] RFR: 8223214: Inet6AddressImpl.loopbackAddress() should choose loopback address that is available

Arthur, > On 15 May 2019, at 16:19, Arthur Eubanks wrote: > > Ping. > > From: Arthur Eubanks mailto:aeuba...@google.com>google.com> wrote: > New webrev: http://cr.openjdk.java.net/~aeubanks/8223214/webrev.01/ > You have my Review.

Re: [ipv6] RFR: 8223532: Don't try creating IPv4 sockets in NetworkInterface.c if IPv4 is not supported

On 15/05/2019 16:19, Arthur Eubanks wrote: New webrev: http://cr.openjdk.java.net/~aeubanks/8223532/webrev.03/ All good. I see no issues when running various tests. -Chris. Thanks, still need one more reviewer. Hi Arthur, This is not hotspot - I don't think you do :-) But

Re: RFR: 8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic

Daniel On 13/05/2019 19:29, Daniel Fuchs wrote: ... http://cr.openjdk.java.net/~dfuchs/webrev_8223716/webrev.00/ I think the approach of pushing this improvement, and filing a separate issue to track the minor loosening of the constraints is reasonable. I believe workers should be

RE: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

Hi David, Martin, thanks for looking into this. Generally I share your view on this. It's not nice at all. However, it's the only way I can see currently to get rid of the Errors in the Eclipse IDE. Maybe an idea would be to get this in but at the same time open a ticket to evaluate this code

Re: RFR: 8223880: Update sun/net/ftp/FtpURL.java and sun/net/ftp/FtpURLConnectionLeak.java to work with IPv6 addresses

Hi Vyom, On 15/05/2019 11:25, Vyom Tiwari wrote: Hi Daniel, Changes looks good to me, Thanks! as you said code is copied from one test to another, i found FtpGetContent.java where same FtpServer code is copied.  Are you planning to fix FtpGetContent.java as well  ?. Well - I wasn't

Re: RFR: 8223880: Update sun/net/ftp/FtpURL.java and sun/net/ftp/FtpURLConnectionLeak.java to work with IPv6 addresses

Hi Daniel, Changes looks good to me, as you said code is copied from one test to another, i found FtpGetContent.java where same FtpServer code is copied. Are you planning to fix FtpGetContent.java as well ?. Thanks, Vyom On Wed, May 15, 2019 at 2:18 PM Daniel Fuchs wrote: > Hi Arthue, > > On

Re: PING: Re: RFR: JDK-8184770: JDWP support for IPv6

Alex, On 13/05/2019 22:06, Alex Menkov wrote: Hi Chris, Serguei, Updated webrev: http://cr.openjdk.java.net/~amenkov/IPv6/webrev.05/ I'm ok with this version. CSR (approved): https://bugs.openjdk.java.net/browse/JDK-8223104 Changes (vs. webrev.04): - setsockopt(IPV6_V6ONLY) was moved

Re: [ipv6] RFR: 8223737: HostsFileNameService doesn't handle IPv6 literal addresses correctly

Hi Arthur, yes all good  thanks regards Mark From: Arthur Eubanks Sent: Wednesday 15 May 2019 02:06 To: mark sheppard Cc: Chris Hegarty; OpenJDK Network Dev list Subject: Re: [ipv6] RFR: 8223737: HostsFileNameService doesn't handle IPv6 literal addresses

Re: RFR: 8223880: Update sun/net/ftp/FtpURL.java and sun/net/ftp/FtpURLConnectionLeak.java to work with IPv6 addresses

Hi Arthue, On 14/05/2019 23:57, Arthur Eubanks wrote: In test/jdk/sun/net/ftp/FtpURL.java, extendedEnabled is always true. Same with portEnabled and pasvEnabled. Yes - I left them there as they were preexisting. The bits that handles EPSV is a copy paste from another test and that minimized