Re: RFR[8243507]: 'DatagramSocket constructors don’t always specify what happens when passed invalid parameters'

Hi Daniel, Patrick, I wonder is there an opportunity here to refine the constructor descriptions a little, also The wording associated with wildcard addressing includes * an IP address chosen by the kernel. which is not actually correct, and maybe it should be omitted from the various cons

Re: RFR 15 8243099: Adding ADQ support to JDK

On 28/04/2020 01:33, Ivanov, Vladimir A wrote: The changes for ADq doc update that includes explanation for this technology: /** * ADQ (Application Device Queues) is an open technology to help address network traffic challenges by improving application * throughput and latency, and, most impor

Re: RFR 15 8243099: Adding ADQ support to JDK

Hello, If you query the queue Id from a central dispatcher thread is there any benefit in knowing that ID as the context change already happens. So without being able to bind a thread for accepting to such a queue (which might not be so easy with emulated async NIO) this api feature seems to no

RE: RFR 15 8243099: Adding ADQ support to JDK

Updated version of the webrev available as http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.03/ The tests run results for the " test/jdk/java/net test/jdk/java/nio/channels test/jdk/javax/net test/jdk/jdk/net test/jdk/sun/net" same as for non-patched version. Changes: 1. commen

Re: RFR 15 8243099: Adding ADQ support to JDK

Hi Ivan, Minor editorial suggestion in ExtendedSocketOptions.java:177    ...that +an+ application can use... $.02, Roger On 4/29/20 2:11 PM, Ivanov, Vladimir A wrote: Updated version of the webrev available as http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.03/ The tests run

RE: RFR 15 8243099: Adding ADQ support to JDK

Most applications, for example web servers, kafka, Netty etc, have one master thread and multiple worker threads to service incoming connections. Master thread accept these connections and dispatch to one of the worker threads using some load balancing policies like round/robin,. With this new s

Re: RFR[8243507]: 'DatagramSocket constructors don’t always specify what happens when passed invalid parameters'

Hi Daniel and Mark, WRT what happens when `laddr` is null: it has been filed as a separate issue, i.e. JDK-8243999 , and has been assigned to me. Thanks for the wording suggestions, Mark. I will take a closer look once this patch is out of th

Re: RFR[8243507]: 'DatagramSocket constructors don’t always specify what happens when passed invalid parameters'

On 29/04/2020 21:08, Patrick Concannon wrote: webrev: http://cr.openjdk.java.net/~pconcannon/8243507/webrevs/webrev.01/ Thanks Patrick. LGTM. Pedantically, this test might temporarily leak instances of DatagramSocket when it detects a bug. That is, for instance - in the case where `new Datagra

Re: RFR 15 8243099: Adding ADQ support to JDK

Hi Vladimir, Latest webrev(03) looks ok to me , one minor bit, method signature(Signature: (I)I;) is not correct in incomingNapiIdSupported0. Thanks, Vyom ++/*+ * Class: jdk_net_LinuxSocketOptions+ * Method: incomingNapiIdSupported0+ * Signature: (I)I;+ */+JNIEXPORT jboolean JNICALL Java_j