Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

> On 12 Jun 2020, at 17:55, Rahul Yadav wrote: > > ... > > http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html > This looks v. good Rahul. A few, mostly pedantic, comments on the test: 1) In recent times, we’ve been bi

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

Hi Rahul, On 15/06/2020 09:52, Chris Hegarty wrote: On 12 Jun 2020, at 17:55, Rahul Yadav > wrote: ... http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html 2) While not wrong, I don’t think that the @library tag is needed, or at least I cannot see

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

Hi, CSR: https://bugs.openjdk.java.net/browse/JDK-8244650 On 06/13/2020 10:49 PM, mark sheppard wrote: Hi, For JDK-8132359 it now addresses the issue: Amend JarURLConnection::getJarFile() to return JarFile object reference for nonexistent JAR file entry URL The scenario addressed is that

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

Hi Chris, Daniel Thank you for the comments. I have included the feedback and updated webrev. http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html - rahul On 15/06/2020 10:28, Daniel Fuchs wrote: Hi Rahul, On 15/06/2020 09:52, Chris Hegarty wrote: On 12 Jun 2020, at 17:55, Rahul Ya

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

> On 15 Jun 2020, at 11:41, Rahul Yadav wrote: > > Hi Chris, Daniel > > Thank you for the comments. > I have included the feedback and updated webrev. > > http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html > > LGTM. Sh

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

Thanks Rahul! Looks good to me too :-) best regards, -- daniel On 15/06/2020 11:41, Rahul Yadav wrote: Hi Chris, Daniel Thank you for the comments. I have included the feedback and updated webrev. http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html - rahul

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

Hi Alex, I think there is some other work planned in this area, so it may be best to place this item on hold for a bit. There should be an update on this shortly. regards Mark From: Alex Kashchenko Sent: Monday 15 June 2020 10:35 To: mark sheppard ; OpenJDK Ne

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

Hi Alex, Mark, While I think that change for this issue is good, I would like to request that we please put it on hold temporarily. I will experiment with possible solutions for 8246714 - the URLClassLoader issue. It may result in no overlap with this issue, 8132359, but it seems prudent to al

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

Hi Rahul, Sorry I didn't catch that earlier, but your test has the wrong copyright notice. We do not have the "Classpath" exception in tests. best regards, -- daniel On 15/06/2020 11:41, Rahul Yadav wrote: Hi Chris, Daniel Thank you for the comments. I have included the feedback and updated

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

Hi Daniel, I have updated the copyright notice. On 15/06/2020 16:23, Daniel Fuchs wrote: Hi Rahul, Sorry I didn't catch that earlier, but your test has the wrong copyright notice. We do not have the "Classpath" exception in tests. best regards, -- daniel On 15/06/2020 11:41, Rahul Yadav wro

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

Hi Chris, sounds good thanks for the update regards Mark - Original Message - From: chris.hega...@oracle.com To: akash...@redhat.com, net-dev@openjdk.java.net, mark.shepp...@oracle.com Sent: Monday, 15 June, 2020 1:46:06 PM GMT +00:00 GMT Britain, Ireland, Portugal Subjec